From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 740D7C369C2 for ; Thu, 24 Apr 2025 12:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xc6/3bX1nq87CgdZ/91SCSSri+FvGnmfn2iiscmuuiA=; b=zwMIhbrbwSjnTu 6sr/W+SmR4P6ErraPlR+hnlHw4aJZ4gZqSk8L5Qtjr8GJZSBgrFjIHbjvhHF+UBtytqx+CCtsMzu/ Hm+yNy9jaHOtfmAdBqOfc0oMvB5L1zZULAp7VRYQeUcNuSu8EAszSJg7oHcAtFFhlTPo+fyYYM2B/ 833Jgms64QFlzfuHY+rGUCQ4qKMYzaJLqNUmC68HdY1JcHxmTWWOWDDUBi+7gcbUnYq8im2JYu60y 1i1wqthaehKnPIsl5CHxFZsnnSoU1orkqZOsJz7G1pNHBUYI2O8HijLZeQ082dGF8vhabJYKWFv4y kFH6ipTymuGo1eLT/rtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7w67-0000000E6Uq-2Jhb; Thu, 24 Apr 2025 12:54:35 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7uPd-0000000DnSF-0IqR for linux-riscv@bombadil.infradead.org; Thu, 24 Apr 2025 11:06:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=xaFlU49KHj/WqsyzkJFZpLzZkQa35ucQoiXjJp4Ub20=; b=oR97CFrJeF1J3O5WyYlOqujDV2 bGNkCOGtKVnHqhHUdW2GgK2+V20SU0lPyVxFSGmAJNBVedegdBmxdZx6LekAJKNyyFH1l59UpMg1k 3DYGAJy6jW9r+VNuEq/CPl/UiDwGa7UgeWOm+r4+i2A4l8eBawGF9Jn4w+ieegb2kmQstUoxrZvDf jc1w6hrYysfNymPPzO6huSDBPf0rVO0lKE/44LfYg6F3ewjwA7wAhqzNHbkkESmxsbbMmTn8u/i9U D8YSQW16R5tA2SBw/ZKXTqN/rjIBmkf0OzRnZHwoGH3drdGCxBAWsGtAdYElSov7iXsQPEfvAlu4q Dtdb3Zug==; Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by desiato.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u7uPZ-0000000BlDL-3LJp for linux-riscv@lists.infradead.org; Thu, 24 Apr 2025 11:06:35 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43cf257158fso5111435e9.2 for ; Thu, 24 Apr 2025 04:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1745492792; x=1746097592; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xaFlU49KHj/WqsyzkJFZpLzZkQa35ucQoiXjJp4Ub20=; b=fQG2yGzIsrUibzkE05eEuN7UcqmD6iJFOvsPe4YdltpTxQRrsnZMF+syPWXHqb3R// zCmWrpC6JO9N3FKJ2OkcbCDC3ve5rBLleZ5Hkga7lVhHyYOBeNnKFSdsm3heYt2BfGFX QYCQTm8QjeLlkSgtkdOrJZ1C8JZ04v+ypiHEyQcjkgen7D6LarlUz5si3hsc+SscZ9q/ 3XinazjHHxwkOp6VXCu0B8dW2jZAPIKCgaNx0Ooi9SDwaHv3jMuE51rHMMpS9ZACIVNA yNIYHoLy0euQpm3D1b4aYJfOGSRGys4U39wrVClolSSGWCSD6FWeEPkg8EE4cBPOOiUV pr3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745492792; x=1746097592; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xaFlU49KHj/WqsyzkJFZpLzZkQa35ucQoiXjJp4Ub20=; b=VFmTMWpXoHPGrZxQLcal/s20SYa5In8XmsO8TNEG8cdpkg3cQvzw2dIz7VHmCyWGRS 9jVcjw8uw8z6u4+t6W2sNApRtKGcO6eyz/3bkq0e4T/EaaZUUvXiEigv+wGQQFjz5MoM l5rBTM5q/F5lsZ0QqnoaWlSB1jpzHZlslPL/XVf/J0UYUJXCIiTr2rhkd7SuYY4RgG0s WLylwW8/P8j4DXily46r/6zg6pGkid/GmfIZAmWi0vc1b3Y7jFvsiQZ9jMfpRcoRR1yD 5J6tpMETTp6q2HW4HSBvYoWEl+JNqOMNfMK3gYxG+o3F0KZilqMyzSFbqdUhmau39tF+ 4GKA== X-Forwarded-Encrypted: i=1; AJvYcCXAI+5YjlTYtFn1trqfQAI8ZJ5sRXkhsXa7KxCWGBaE+73DyUh/Oq7k/n8Ps27QlLwPpLns+LSaqkXMZw==@lists.infradead.org X-Gm-Message-State: AOJu0YxZ0YbTjw29Hxh15cMo6QpOPkPfIb/DRv3J/cBhD+pLrUinxov0 Ipv6JOJO0XI5GYcmBM2n1wmId+esGG8PVAxhkHPG47Fc+0KY6G8cWBuYefIZBy0= X-Gm-Gg: ASbGncvZc0qCQeDpU/pa18voFarYSwVTerkfJchdvjAAw/GIwenZkDmONk1C+8h0uI+ n4wV2oEuwQu0HMNKt06mnc3feiiYp52CdKc8410SRtSwIWVMEw0XftUwzdnoUo9qkZmf07Alm3D ht/ITx9RgChSKWaq6P7aY3kJWdaTPpIrFerLQja+hft5mfOUvs6N2Jdipe5E/LxuLmyypGVAkUj 1iyj12xK/aQiXVdMtrhythP0PqvmE9ChzBDANCaacsOVBRqLvnsJOZEN30h93kOqRSQDBeG6Hdh RdREZuBut2B6czPYU4Vqy3+yey8M X-Google-Smtp-Source: AGHT+IGdWaGhxvTRb6GutdDIuLG/aiIZCV4CCAGWlaD0KDkW+nhzZtqNPgORxU7ENnJYG2P45T9aiQ== X-Received: by 2002:a05:600c:1c93:b0:43c:fded:9654 with SMTP id 5b1f17b1804b1-4409bd32458mr16398415e9.19.1745492791956; Thu, 24 Apr 2025 04:06:31 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200::f716]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2a13bdsm16546245e9.9.2025.04.24.04.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 04:06:31 -0700 (PDT) Date: Thu, 24 Apr 2025 13:06:30 +0200 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v5 04/13] riscv: sbi: add SBI FWFT extension calls Message-ID: <20250424-c0700f89bcd29438d6d8d65c@orel> References: <20250417122337.547969-1-cleger@rivosinc.com> <20250417122337.547969-5-cleger@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250417122337.547969-5-cleger@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250424_120634_120674_62243D2F X-CRM114-Status: GOOD ( 22.33 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Apr 17, 2025 at 02:19:51PM +0200, Cl=E9ment L=E9ger wrote: > Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is > provided as a separate commit that can be left out if needed. > = > Signed-off-by: Cl=E9ment L=E9ger > --- > arch/riscv/kernel/sbi.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > = > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 379981c2bb21..7b062189b184 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -299,6 +299,8 @@ static int __sbi_rfence_v02(int fid, const struct cpu= mask *cpu_mask, > return 0; > } > = > +static bool sbi_fwft_supported; At some point we may want an SBI extension bitmap, but this is only the second SBI extension supported boolean that I'm aware of, so I guess we're still OK for now. > + > /** > * sbi_fwft_set() - Set a feature on the local hart > * @feature: The feature ID to be set > @@ -309,7 +311,15 @@ static int __sbi_rfence_v02(int fid, const struct cp= umask *cpu_mask, > */ > int sbi_fwft_set(u32 feature, unsigned long value, unsigned long flags) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret =3D sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_SET, > + feature, value, flags, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); > } > = > struct fwft_set_req { > @@ -348,6 +358,9 @@ int sbi_fwft_local_set_cpumask(const cpumask_t *mask,= u32 feature, > .error =3D ATOMIC_INIT(0), > }; > = > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > if (feature & SBI_FWFT_GLOBAL_FEATURE_BIT) > return -EINVAL; > = > @@ -679,6 +692,11 @@ void __init sbi_init(void) > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available =3D true; > } > + if ((sbi_spec_version >=3D sbi_mk_version(3, 0)) && > + (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { Unnecessary (), but I see it's consistent with the expressions above. > + pr_info("SBI FWFT extension detected\n"); > + sbi_fwft_supported =3D true; > + } > } else { > __sbi_set_timer =3D __sbi_set_timer_v01; > __sbi_send_ipi =3D __sbi_send_ipi_v01; > -- = > 2.49.0 > Besides the () nit Reviewed-by: Andrew Jones _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv