From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BFB0C369D1 for ; Sun, 27 Apr 2025 13:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JtSufu0kPfSZpjhzjojqnOtq0WVrXHKeAJ7eyFQNN0o=; b=WNladlv6AeZgxL T3i46iAfyGcZIFVVuQhoUGWmHqGaAxkY0BQlJeSuLvkaAF3OPRiyhjND2Mrgq7hlx+NSmrlZiowd7 SrzYjfKNpIzTte/z84AHycFEuQMTdYc/TSsdpeNF9dpG0iQ2yoDbA4SvkXer8QobPKjrhugEwqt6j tZcZ6PwmpGu3GGkR+HFlwVcoK6Xi8kyBkMKCJ7xmzmcq7CvrA0uK9qi4A0EGmVngfE9ARSvtdq3GU 4hdw2MTkE2k2CWmAYHrZkZZUf2/+l7H3MOLSHOTR6hBbtZrLyPI2dREVLfwZzUTjufBs2fC3pfY7O 4H56hLyHtcbKu/rgdItA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u91fi-00000003ZWV-3AhP; Sun, 27 Apr 2025 13:03:50 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u91Yj-00000003YQi-09qM; Sun, 27 Apr 2025 12:56:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id CFCA544F7A; Sun, 27 Apr 2025 12:56:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BD42C4CEE3; Sun, 27 Apr 2025 12:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745758596; bh=AgqV1hMsSjVwY25pYZciWVxf7VAWpBvP9JfqHyR35EI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qV/qYJttnMqF/e8OqPLChbglT+OXe0BUI3C3XJkFZdTZhhNyHpOmlW5bb+1pxLyao gwGGLC+l03/YlzGd5+J56KHsYr0ohKSxDi747S0hGoCacZJ2qaaZmYUqJ2US3FnkyK Tu/o38Ex6SQrwWRr+GMMtqdU70l2SZNmFzlAG7PYaH28iELmPY1EI0osYVw1sYYhyG uGzqeuOneXyF0+JHSk9mnATjjGPRJIaqEHig6iKUkyyMDrwIc+ilmnaGMs99Mvxqgv 8h/Ac2RS79Wo+V7nYuNH9MBFb5lhQYMARyeMIsV0ibobHTJbQn5pg36EgAkKZDDFP6 PxMIuzZeFmMsQ== Date: Sun, 27 Apr 2025 05:56:41 -0700 From: Eric Biggers To: Herbert Xu Cc: Linux Crypto Mailing List , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, Ard Biesheuvel , "Jason A . Donenfeld " , Linus Torvalds Subject: Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API Message-ID: <20250427125641.GB1161@quark> References: <20250427123514.GA1161@quark> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250427_055637_100358_635530DA X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Apr 27, 2025 at 08:41:38PM +0800, Herbert Xu wrote: > On Sun, Apr 27, 2025 at 05:35:14AM -0700, Eric Biggers wrote: > > > > Well, barely a day and you've already ruined my patch series. Now instead of a > > clean design where the crypto_shash API is built on top of the normal library > > API (sha256_update() etc.), there's now a special low-level API > > "sha256_choose_blocks()" just for shash that it's built on top of instead, for > > no good reason. You're also still pushing your broken BLOCK_HASH_UPDATE_BLOCKS > > macro that doesn't work with size_t, and putting my name on your broken code > > that uses it. > > Your design is unacceptable because you're forcing the partial block > handling on shash where it's not needed, Excuse me? It's the other way around. In my version the partial block handling is only in the library, not shash. In your version you've forced it into the shash layer, even though the library does it already. I understand that you've added support for partial block handling to crypto/shash.c and you want to feel like your work is useful, but in this case it's not, since the libray has to handle arbitrary-length inputs anyway. > just as you're forcing the hardirq support on everything. If you want crypto_shash to warn on hardirq usage you should just put a WARN_ON(in_hardirq()) in crypto_shash_*(), which will actually achieve that. Not add a shash-specific non-hardirq-safe low-level API to the library that can silently corrupt random tasks' SIMD registers on production systems. - Eric _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv