linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Basavaraj Natikar" <Basavaraj.Natikar@amd.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Patrick Venture" <venture@google.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Sean Wang" <sean.wang@kernel.org>,
	"Jesper Nilsson" <jesper.nilsson@axis.com>,
	"Lars Persson" <lars.persson@axis.com>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Vladimir Zapolskiy" <vz@mleia.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Emil Renner Berthing" <kernel@esmil.dk>,
	"Jianlong Huang" <jianlong.huang@starfivetech.com>,
	"Hal Feng" <hal.feng@starfivetech.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,  linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com,
	 linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com,
	 linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org,
	 linux-stm32@st-md-mailman.stormreply.com,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v2 12/17] pinctrl: max77620: Move fixed assignments to 'pinctrl_desc' definition
Date: Wed, 11 Jun 2025 08:13:44 +0200	[thread overview]
Message-ID: <20250611-pinctrl-const-desc-v2-12-b11c1d650384@linaro.org> (raw)
In-Reply-To: <20250611-pinctrl-const-desc-v2-0-b11c1d650384@linaro.org>

Assign 'struct pinctrl_desc' .pins, .npins and other members in
definition to make clear that number of pins is fixed and have less code
in the probe.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/pinctrl/pinctrl-max77620.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-max77620.c b/drivers/pinctrl/pinctrl-max77620.c
index d236daa7c13ebbcaf7c4a8d1a8bed751aa111c0f..acb945a2574368b2e34659a902c34df8aad193d7 100644
--- a/drivers/pinctrl/pinctrl-max77620.c
+++ b/drivers/pinctrl/pinctrl-max77620.c
@@ -543,6 +543,10 @@ static struct pinctrl_desc max77620_pinctrl_desc = {
 	.pctlops = &max77620_pinctrl_ops,
 	.pmxops = &max77620_pinmux_ops,
 	.confops = &max77620_pinconf_ops,
+	.pins = max77620_pins_desc,
+	.npins = ARRAY_SIZE(max77620_pins_desc),
+	.num_custom_params = ARRAY_SIZE(max77620_cfg_params),
+	.custom_params = max77620_cfg_params,
 };
 
 static int max77620_pinctrl_probe(struct platform_device *pdev)
@@ -569,11 +573,6 @@ static int max77620_pinctrl_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, mpci);
 
 	max77620_pinctrl_desc.name = dev_name(&pdev->dev);
-	max77620_pinctrl_desc.pins = max77620_pins_desc;
-	max77620_pinctrl_desc.npins = ARRAY_SIZE(max77620_pins_desc);
-	max77620_pinctrl_desc.num_custom_params =
-				ARRAY_SIZE(max77620_cfg_params);
-	max77620_pinctrl_desc.custom_params = max77620_cfg_params;
 
 	for (i = 0; i < MAX77620_PIN_NUM; ++i) {
 		mpci->fps_config[i].active_fps_src = -1;

-- 
2.45.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-06-11  7:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11  6:13 [PATCH v2 00/17] pinctrl: Constify pointers to 'pinctrl_desc' and more Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 01/17] pinctrl: starfive: Allow compile testing on other platforms Krzysztof Kozlowski
2025-06-11  7:49   ` Hal Feng
2025-06-11 12:48   ` Emil Renner Berthing
2025-06-11  6:13 ` [PATCH v2 02/17] pinctrl: Allow compile testing for K210, TB10X and ZYNQ Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 03/17] pinctrl: amd: Constify pointers to 'pinctrl_desc' Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 04/17] pinctrl: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 05/17] pinctrl: aspeed: Constify static 'pinctrl_desc' Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 06/17] pinctrl: nuvoton: " Krzysztof Kozlowski
2025-06-14 11:17   ` J. Neuschäfer
2025-06-11  6:13 ` [PATCH v2 07/17] pinctrl: bcm: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 08/17] pinctrl: bcm: cygnus-mux: Move fixed assignments to 'pinctrl_desc' definition Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 09/17] pinctrl: bcm: cygnus-ns2: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 10/17] pinctrl: bcm: cygnus-nsp: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 11/17] pinctrl: as3722: " Krzysztof Kozlowski
2025-06-11  6:13 ` Krzysztof Kozlowski [this message]
2025-06-11  6:13 ` [PATCH v2 13/17] pinctrl: palmas: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 14/17] pinctrl: renesas: " Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 15/17] pinctrl: pistachio: Constify static 'pinctrl_desc' Krzysztof Kozlowski
2025-06-11  6:13 ` [PATCH v2 16/17] pinctrl: " Krzysztof Kozlowski
2025-06-11  9:54   ` Vladimir Zapolskiy
2025-06-11 12:49   ` Emil Renner Berthing
2025-06-12  3:00   ` Hal Feng
2025-06-11  6:13 ` [PATCH v2 17/17] rtc: stm32: " Krzysztof Kozlowski
2025-06-11  7:35   ` Alexandre Belloni
2025-06-18 11:27 ` [PATCH v2 00/17] pinctrl: Constify pointers to 'pinctrl_desc' and more Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250611-pinctrl-const-desc-v2-12-b11c1d650384@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=avifishman70@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=benjaminfair@google.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=david.rhodes@cirrus.com \
    --cc=dlemoal@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=hal.feng@starfivetech.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=jesper.nilsson@axis.com \
    --cc=jianlong.huang@starfivetech.com \
    --cc=joel@jms.id.au \
    --cc=kernel@esmil.dk \
    --cc=lars.persson@axis.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=lorenzo@kernel.org \
    --cc=mani@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rafal@milecki.pl \
    --cc=rf@opensource.cirrus.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=sean.wang@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=vz@mleia.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).