linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] riscv: sophgo: rename compatible string of the USB device for cv18xx
@ 2025-06-18  3:11 Inochi Amaoto
  2025-06-18  3:11 ` [PATCH 1/2] dt-bindings: usb: dwc2: rename sophgo usb compatible string Inochi Amaoto
  2025-06-18  3:11 ` [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC Inochi Amaoto
  0 siblings, 2 replies; 4+ messages in thread
From: Inochi Amaoto @ 2025-06-18  3:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Minas Harutyunyan, Paul Walmsley, Palmer Dabbelt,
	Albert Ou, Alexandre Ghiti, Chen Wang, Inochi Amaoto
  Cc: linux-usb, devicetree, linux-kernel, linux-riscv, sophgo,
	Yixun Lan, Longbin Li

Old days I added the USB support with a wildcard compatible string.
It is not formal and it is more clear to use a compatible for a
real world SoC. As the usb device is not used in any board device
tree (The patch for USB phy is under review), I think it is good
to correct this mistake before submitting the device node.

Inochi Amaoto (2):
  dt-bindings: usb: dwc2: rename sophgo usb compatible string
  usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X
    series SoC

 Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
 drivers/usb/dwc2/params.c                       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] dt-bindings: usb: dwc2: rename sophgo usb compatible string
  2025-06-18  3:11 [PATCH 0/2] riscv: sophgo: rename compatible string of the USB device for cv18xx Inochi Amaoto
@ 2025-06-18  3:11 ` Inochi Amaoto
  2025-06-18  3:11 ` [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC Inochi Amaoto
  1 sibling, 0 replies; 4+ messages in thread
From: Inochi Amaoto @ 2025-06-18  3:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Minas Harutyunyan, Paul Walmsley, Palmer Dabbelt,
	Albert Ou, Alexandre Ghiti, Chen Wang, Inochi Amaoto
  Cc: linux-usb, devicetree, linux-kernel, linux-riscv, sophgo,
	Yixun Lan, Longbin Li

The support for Sophgo CV1800 series SoC introduces a wildcard compatible
string "sophgo,cv1800-usb", rename it to sophgo,cv1800b-usb to match a
real world SoC. As the compatible string is not used in any board dts.
It is safe to rename it.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index e83d30a91b88..6c3a10991b8b 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -59,7 +59,7 @@ properties:
       - const: amcc,dwc-otg
       - const: apm,apm82181-dwc-otg
       - const: snps,dwc2
-      - const: sophgo,cv1800-usb
+      - const: sophgo,cv1800b-usb
       - const: st,stm32f4x9-fsotg
       - const: st,stm32f4x9-hsotg
       - const: st,stm32f7-hsotg
-- 
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC
  2025-06-18  3:11 [PATCH 0/2] riscv: sophgo: rename compatible string of the USB device for cv18xx Inochi Amaoto
  2025-06-18  3:11 ` [PATCH 1/2] dt-bindings: usb: dwc2: rename sophgo usb compatible string Inochi Amaoto
@ 2025-06-18  3:11 ` Inochi Amaoto
  2025-06-20  5:50   ` Minas Harutyunyan
  1 sibling, 1 reply; 4+ messages in thread
From: Inochi Amaoto @ 2025-06-18  3:11 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Minas Harutyunyan, Paul Walmsley, Palmer Dabbelt,
	Albert Ou, Alexandre Ghiti, Chen Wang, Inochi Amaoto
  Cc: linux-usb, devicetree, linux-kernel, linux-riscv, sophgo,
	Yixun Lan, Longbin Li

As the wildcard name is dropped and favor new compatible string
which match a real SoC, and it is not used for any board at now.

Rename it to sophgo,cv1800b-usb to match the binding change.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/usb/dwc2/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 4d73fae80b12..ea6bd537e337 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -334,7 +334,7 @@ const struct of_device_id dwc2_of_match_table[] = {
 	  .data = dwc2_set_amlogic_a1_params },
 	{ .compatible = "amcc,dwc-otg", .data = dwc2_set_amcc_params },
 	{ .compatible = "apm,apm82181-dwc-otg", .data = dwc2_set_amcc_params },
-	{ .compatible = "sophgo,cv1800-usb",
+	{ .compatible = "sophgo,cv1800b-usb",
 	  .data = dwc2_set_cv1800_params },
 	{ .compatible = "st,stm32f4x9-fsotg",
 	  .data = dwc2_set_stm32f4x9_fsotg_params },
-- 
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC
  2025-06-18  3:11 ` [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC Inochi Amaoto
@ 2025-06-20  5:50   ` Minas Harutyunyan
  0 siblings, 0 replies; 4+ messages in thread
From: Minas Harutyunyan @ 2025-06-20  5:50 UTC (permalink / raw)
  To: Inochi Amaoto, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Minas Harutyunyan,
	Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
	Chen Wang
  Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	sophgo@lists.linux.dev, Yixun Lan, Longbin Li



On 6/18/25 07:11, Inochi Amaoto wrote:
> As the wildcard name is dropped and favor new compatible string
> which match a real SoC, and it is not used for any board at now.
> 
> Rename it to sophgo,cv1800b-usb to match the binding change.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
>   drivers/usb/dwc2/params.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 4d73fae80b12..ea6bd537e337 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -334,7 +334,7 @@ const struct of_device_id dwc2_of_match_table[] = {
>   	  .data = dwc2_set_amlogic_a1_params },
>   	{ .compatible = "amcc,dwc-otg", .data = dwc2_set_amcc_params },
>   	{ .compatible = "apm,apm82181-dwc-otg", .data = dwc2_set_amcc_params },
> -	{ .compatible = "sophgo,cv1800-usb",
> +	{ .compatible = "sophgo,cv1800b-usb",
>   	  .data = dwc2_set_cv1800_params },
>   	{ .compatible = "st,stm32f4x9-fsotg",
>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-06-20  5:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-18  3:11 [PATCH 0/2] riscv: sophgo: rename compatible string of the USB device for cv18xx Inochi Amaoto
2025-06-18  3:11 ` [PATCH 1/2] dt-bindings: usb: dwc2: rename sophgo usb compatible string Inochi Amaoto
2025-06-18  3:11 ` [PATCH 2/2] usb: dwc2: follow compatible string change for Sophgo CV18XX/SG200X series SoC Inochi Amaoto
2025-06-20  5:50   ` Minas Harutyunyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).