From: Marc Zyngier <maz@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Rob Herring" <robh@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Janne Grunau" <j@jannau.net>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] PCI: host-generic: Fix driver_data overwriting bugs
Date: Wed, 25 Jun 2025 12:18:03 +0100 [thread overview]
Message-ID: <20250625111806.4153773-1-maz@kernel.org> (raw)
Geert reports that some drivers do rely on the device driver_data
field containing a pointer to the bridge structure at the point of
initialising the root port, while this has been recently changed to
contain some other data for the benefit of the Apple PCIe driver.
This small series builds on top of Geert previously posted (and
included as a prefix for reference) fix for the Microchip driver,
which breaks the Apple driver. This is basically swapping a regression
for another, which isn't a massive deal at this stage, as the
follow-up patch fixes things for the Apple driver by adding extra
tracking.
Finally, we can revert a one-liner that glued the whole thing
together, and that isn't needed anymore.
All of this is candidate for 6.16, as we have regressed the Microchip
driver in -rc1, and that fixing it breaks the Apple driver.
Geert Uytterhoeven (1):
PCI: host-generic: Set driver_data before calling gen_pci_init()
Marc Zyngier (2):
PCI: apple: Add tracking of probed root ports
Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root
port device"
drivers/pci/controller/pci-host-common.c | 4 +-
drivers/pci/controller/pcie-apple.c | 53 ++++++++++++++++++++++--
drivers/pci/ecam.c | 2 -
3 files changed, 51 insertions(+), 8 deletions(-)
--
2.39.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2025-06-25 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 11:18 Marc Zyngier [this message]
2025-06-25 11:18 ` [PATCH 1/3] PCI: host-generic: Set driver_data before calling gen_pci_init() Marc Zyngier
2025-06-25 11:18 ` [PATCH 2/3] PCI: apple: Add tracking of probed root ports Marc Zyngier
2025-06-25 12:32 ` Geert Uytterhoeven
2025-06-25 11:18 ` [PATCH 3/3] Revert "PCI: ecam: Allow cfg->priv to be pre-populated from the root port device" Marc Zyngier
2025-06-25 12:32 ` Geert Uytterhoeven
2025-06-25 12:39 ` [PATCH 0/3] PCI: host-generic: Fix driver_data overwriting bugs Geert Uytterhoeven
2025-06-30 17:06 ` Bjorn Helgaas
2025-06-30 17:23 ` Marc Zyngier
2025-06-30 17:34 ` Bjorn Helgaas
2025-07-01 10:54 ` Marc Zyngier
2025-07-16 15:21 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625111806.4153773-1-maz@kernel.org \
--to=maz@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=j@jannau.net \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox