[PATCH net-next RFC v4 0/4] riscv: dts: sophgo: Add ethernet support for cv18xx

[PATCH net-next RFC v4 0/4] riscv: dts: sophgo: Add ethernet support for cv18xx

[Inochi Amaoto]

Add device binding and dts for CV18XX series SoC, this dts change series
required the reset patch [1] for the dts, which is already taken.

[1] https://lore.kernel.org/all/20250617070144.1149926-1-inochiama@gmail.com

The patch is marked as RFC as it require reset dts.

Change from RFC v3:
- https://lore.kernel.org/all/20250626080056.325496-1-inochiama@gmail.com
1. patch 3: change internal phy id from 0 to 1

Change from RFC v2:
- https://lore.kernel.org/all/20250623003049.574821-1-inochiama@gmail.com
1. patch 1: fix wrong binding title
2. patch 3: fix unmatched mdio bus number
3. patch 4: remove setting phy-mode and phy-handle in board dts and move
	    them into patch 3.

Change from RFC v1:
- https://lore.kernel.org/all/20250611080709.1182183-1-inochiama@gmail.com
1. patch 3: switch to mdio-mux-mmioreg
2. patch 4: add configuration for Huashan Pi

Inochi Amaoto (4):
  dt-bindings: net: Add support for Sophgo CV1800 dwmac
  riscv: dts: sophgo: Add ethernet device for cv18xx
  riscv: dts: sophgo: Add mdio multiplexer device for cv18xx
  riscv: dts: sophgo: Enable ethernet device for Huashan Pi

 .../bindings/net/sophgo,cv1800b-dwmac.yaml    | 113 ++++++++++++++++++
 arch/riscv/boot/dts/sophgo/cv180x.dtsi        |  73 +++++++++++
 .../boot/dts/sophgo/cv1812h-huashan-pi.dts    |   8 ++
 3 files changed, 194 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml

--
2.50.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH net-next RFC v4 1/4] dt-bindings: net: Add support for Sophgo CV1800 dwmac

[Inochi Amaoto]

The GMAC IP on CV1800 series SoC is a standard Synopsys
DesignWare MAC (version 3.70a).

Add necessary compatible string for this device.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/net/sophgo,cv1800b-dwmac.yaml    | 113 ++++++++++++++++++
 1 file changed, 113 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml

diff --git a/Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml b/Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml
new file mode 100644
index 000000000000..8abd2cf06e2c
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml
@@ -0,0 +1,113 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/sophgo,cv1800b-dwmac.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sophgo CV1800B DWMAC glue layer
+
+maintainers:
+  - Inochi Amaoto <inochiama@gmail.com>
+
+select:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - sophgo,cv1800b-dwmac
+  required:
+    - compatible
+
+properties:
+  compatible:
+    items:
+      - const: sophgo,cv1800b-dwmac
+      - const: snps,dwmac-3.70a
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: GMAC main clock
+      - description: PTP clock
+
+  clock-names:
+    items:
+      - const: stmmaceth
+      - const: ptp_ref
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: stmmaceth
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+  - interrupt-names
+  - resets
+  - reset-names
+
+allOf:
+  - $ref: snps,dwmac.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    ethernet@4070000 {
+      compatible = "sophgo,cv1800b-dwmac", "snps,dwmac-3.70a";
+      reg = <0x04070000 0x10000>;
+      clocks = <&clk 35>, <&clk 36>;
+      clock-names = "stmmaceth", "ptp_ref";
+      interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
+      interrupt-names = "macirq";
+      resets = <&rst 12>;
+      reset-names = "stmmaceth";
+      rx-fifo-depth = <8192>;
+      tx-fifo-depth = <8192>;
+      snps,multicast-filter-bins = <0>;
+      snps,perfect-filter-entries = <1>;
+      snps,aal;
+      snps,txpbl = <8>;
+      snps,rxpbl = <8>;
+      snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
+      snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
+      snps,axi-config = <&gmac0_stmmac_axi_setup>;
+      status = "disabled";
+
+      mdio {
+        compatible = "snps,dwmac-mdio";
+        #address-cells = <1>;
+        #size-cells = <0>;
+      };
+
+      gmac0_mtl_rx_setup: rx-queues-config {
+        snps,rx-queues-to-use = <1>;
+        queue0 {};
+      };
+
+      gmac0_mtl_tx_setup: tx-queues-config {
+        snps,tx-queues-to-use = <1>;
+        queue0 {};
+      };
+
+      gmac0_stmmac_axi_setup: stmmac-axi-config {
+        snps,blen = <16 8 4 0 0 0 0>;
+        snps,rd_osr_lmt = <2>;
+        snps,wr_osr_lmt = <1>;
+      };
+    };
-- 
2.50.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH net-next RFC v4 1/4] dt-bindings: net: Add support for Sophgo CV1800 dwmac

[Krzysztof Kozlowski]

On 01/07/2025 03:17, Inochi Amaoto wrote:
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    ethernet@4070000 {
> +      compatible = "sophgo,cv1800b-dwmac", "snps,dwmac-3.70a";
> +      reg = <0x04070000 0x10000>;
> +      clocks = <&clk 35>, <&clk 36>;
> +      clock-names = "stmmaceth", "ptp_ref";
> +      interrupts = <31 IRQ_TYPE_LEVEL_HIGH>;
> +      interrupt-names = "macirq";
> +      resets = <&rst 12>;
> +      reset-names = "stmmaceth";
> +      rx-fifo-depth = <8192>;
> +      tx-fifo-depth = <8192>;
> +      snps,multicast-filter-bins = <0>;
> +      snps,perfect-filter-entries = <1>;
> +      snps,aal;
> +      snps,txpbl = <8>;
> +      snps,rxpbl = <8>;
> +      snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> +      snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> +      snps,axi-config = <&gmac0_stmmac_axi_setup>;
> +      status = "disabled";

This cannot be disabled.

Also means it was not really tested.

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH net-next RFC v4 2/4] riscv: dts: sophgo: Add ethernet device for cv18xx

[Inochi Amaoto]

Add ethernet controller device node for cv18xx SoC.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 arch/riscv/boot/dts/sophgo/cv180x.dtsi | 44 ++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
index e91bb512b099..7eecc67f896e 100644
--- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
+++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
@@ -189,6 +189,50 @@ i2c4: i2c@4040000 {
 			status = "disabled";
 		};
 
+		gmac0: ethernet@4070000 {
+			compatible = "sophgo,cv1800b-dwmac", "snps,dwmac-3.70a";
+			reg = <0x04070000 0x10000>;
+			clocks = <&clk CLK_AXI4_ETH0>, <&clk CLK_ETH0_500M>;
+			clock-names = "stmmaceth", "ptp_ref";
+			interrupts = <SOC_PERIPHERAL_IRQ(15) IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "macirq";
+			resets = <&rst RST_ETH0>;
+			reset-names = "stmmaceth";
+			rx-fifo-depth = <8192>;
+			tx-fifo-depth = <8192>;
+			snps,multicast-filter-bins = <0>;
+			snps,perfect-filter-entries = <1>;
+			snps,aal;
+			snps,txpbl = <8>;
+			snps,rxpbl = <8>;
+			snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
+			snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
+			snps,axi-config = <&gmac0_stmmac_axi_setup>;
+			status = "disabled";
+
+			gmac0_mdio: mdio {
+				compatible = "snps,dwmac-mdio";
+				#address-cells = <1>;
+				#size-cells = <0>;
+			};
+
+			gmac0_mtl_rx_setup: rx-queues-config {
+				snps,rx-queues-to-use = <1>;
+				queue0 {};
+			};
+
+			gmac0_mtl_tx_setup: tx-queues-config {
+				snps,tx-queues-to-use = <1>;
+				queue0 {};
+			};
+
+			gmac0_stmmac_axi_setup: stmmac-axi-config {
+				snps,blen = <16 8 4 0 0 0 0>;
+				snps,rd_osr_lmt = <2>;
+				snps,wr_osr_lmt = <1>;
+			};
+		};
+
 		uart0: serial@4140000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x04140000 0x100>;
-- 
2.50.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH net-next RFC v4 3/4] riscv: dts: sophgo: Add mdio multiplexer device for cv18xx

[Inochi Amaoto]

Add DT device node of mdio multiplexer device for cv18xx SoC.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 arch/riscv/boot/dts/sophgo/cv180x.dtsi | 29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
index 7eecc67f896e..3a82cc40ea1a 100644
--- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
+++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
@@ -31,6 +31,33 @@ rst: reset-controller@3003000 {
 			#reset-cells = <1>;
 		};
 
+		mdio: mdio@3009800 {
+			compatible = "mdio-mux-mmioreg", "mdio-mux";
+			reg = <0x3009800 0x4>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			mdio-parent-bus = <&gmac0_mdio>;
+			mux-mask = <0x80>;
+			status = "disabled";
+
+			internal_mdio: mdio@0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				reg = <0>;
+
+				internal_ephy: phy@0 {
+					compatible = "ethernet-phy-ieee802.3-c22";
+					reg = <1>;
+				};
+			};
+
+			external_mdio: mdio@80 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				reg = <0x80>;
+			};
+		};
+
 		gpio0: gpio@3020000 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0x3020000 0x1000>;
@@ -196,6 +223,8 @@ gmac0: ethernet@4070000 {
 			clock-names = "stmmaceth", "ptp_ref";
 			interrupts = <SOC_PERIPHERAL_IRQ(15) IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "macirq";
+			phy-handle = <&internal_ephy>;
+			phy-mode = "internal";
 			resets = <&rst RST_ETH0>;
 			reset-names = "stmmaceth";
 			rx-fifo-depth = <8192>;
-- 
2.50.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH net-next RFC v4 4/4] riscv: dts: sophgo: Enable ethernet device for Huashan Pi

[Inochi Amaoto]

Enable ethernet controller and mdio multiplexer device on Huashan Pi.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts b/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
index 26b57e15adc1..4a5835fa9e96 100644
--- a/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
+++ b/arch/riscv/boot/dts/sophgo/cv1812h-huashan-pi.dts
@@ -55,6 +55,14 @@ &emmc {
 	non-removable;
 };
 
+&gmac0 {
+	status = "okay";
+};
+
+&mdio {
+	status = "okay";
+};
+
 &sdhci0 {
 	status = "okay";
 	bus-width = <4>;
-- 
2.50.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH net-next RFC v4 0/4] riscv: dts: sophgo: Add ethernet support for cv18xx

[Inochi Amaoto]

On Tue, Jul 01, 2025 at 09:17:25AM +0800, Inochi Amaoto wrote:
> Add device binding and dts for CV18XX series SoC, this dts change series
> required the reset patch [1] for the dts, which is already taken.
> 
> [1] https://lore.kernel.org/all/20250617070144.1149926-1-inochiama@gmail.com
> 
> The patch is marked as RFC as it require reset dts.
> 
> Change from RFC v3:
> - https://lore.kernel.org/all/20250626080056.325496-1-inochiama@gmail.com
> 1. patch 3: change internal phy id from 0 to 1
> 
> Change from RFC v2:
> - https://lore.kernel.org/all/20250623003049.574821-1-inochiama@gmail.com
> 1. patch 1: fix wrong binding title
> 2. patch 3: fix unmatched mdio bus number
> 3. patch 4: remove setting phy-mode and phy-handle in board dts and move
> 	    them into patch 3.
> 
> Change from RFC v1:
> - https://lore.kernel.org/all/20250611080709.1182183-1-inochiama@gmail.com
> 1. patch 3: switch to mdio-mux-mmioreg
> 2. patch 4: add configuration for Huashan Pi
> 
> Inochi Amaoto (4):
>   dt-bindings: net: Add support for Sophgo CV1800 dwmac
>   riscv: dts: sophgo: Add ethernet device for cv18xx
>   riscv: dts: sophgo: Add mdio multiplexer device for cv18xx
>   riscv: dts: sophgo: Enable ethernet device for Huashan Pi
> 
>  .../bindings/net/sophgo,cv1800b-dwmac.yaml    | 113 ++++++++++++++++++
>  arch/riscv/boot/dts/sophgo/cv180x.dtsi        |  73 +++++++++++
>  .../boot/dts/sophgo/cv1812h-huashan-pi.dts    |   8 ++
>  3 files changed, 194 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml
> 
> --
> 2.50.0
> 

As this is mark as RFC due to the reset dependency, now it is OK
to merge it as the reset patch is taken and this patch is a minor
change . I hopeif anyone can take the binding patch so I can take
the devicetree patches.

Regards,
Inochi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH net-next RFC v4 0/4] riscv: dts: sophgo: Add ethernet support for cv18xx

[Krzysztof Kozlowski]

On 01/07/2025 03:23, Inochi Amaoto wrote:
> On Tue, Jul 01, 2025 at 09:17:25AM +0800, Inochi Amaoto wrote:
>> Add device binding and dts for CV18XX series SoC, this dts change series
>> required the reset patch [1] for the dts, which is already taken.
>>
>> [1] https://lore.kernel.org/all/20250617070144.1149926-1-inochiama@gmail.com
>>
>> The patch is marked as RFC as it require reset dts.
>>
>> Change from RFC v3:
>> - https://lore.kernel.org/all/20250626080056.325496-1-inochiama@gmail.com
>> 1. patch 3: change internal phy id from 0 to 1
>>
>> Change from RFC v2:
>> - https://lore.kernel.org/all/20250623003049.574821-1-inochiama@gmail.com
>> 1. patch 1: fix wrong binding title
>> 2. patch 3: fix unmatched mdio bus number
>> 3. patch 4: remove setting phy-mode and phy-handle in board dts and move
>> 	    them into patch 3.
>>
>> Change from RFC v1:
>> - https://lore.kernel.org/all/20250611080709.1182183-1-inochiama@gmail.com
>> 1. patch 3: switch to mdio-mux-mmioreg
>> 2. patch 4: add configuration for Huashan Pi
>>
>> Inochi Amaoto (4):
>>   dt-bindings: net: Add support for Sophgo CV1800 dwmac
>>   riscv: dts: sophgo: Add ethernet device for cv18xx
>>   riscv: dts: sophgo: Add mdio multiplexer device for cv18xx
>>   riscv: dts: sophgo: Enable ethernet device for Huashan Pi
>>
>>  .../bindings/net/sophgo,cv1800b-dwmac.yaml    | 113 ++++++++++++++++++
>>  arch/riscv/boot/dts/sophgo/cv180x.dtsi        |  73 +++++++++++
>>  .../boot/dts/sophgo/cv1812h-huashan-pi.dts    |   8 ++
>>  3 files changed, 194 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml
>>
>> --
>> 2.50.0
>>
> 
> As this is mark as RFC due to the reset dependency, now it is OK
> to merge it as the reset patch is taken and this patch is a minor
> change . I hopeif anyone can take the binding patch so I can take
> the devicetree patches.

I don't understand why you target net-next with your DTS patches. The
subject prefix is here not correct and probably this should be split.
Anyway, bindings have issues, so no, it cannot be merged.

Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH net-next RFC v4 0/4] riscv: dts: sophgo: Add ethernet support for cv18xx

[Inochi Amaoto]

On Tue, Jul 01, 2025 at 08:26:31AM +0200, Krzysztof Kozlowski wrote:
> On 01/07/2025 03:23, Inochi Amaoto wrote:
> > On Tue, Jul 01, 2025 at 09:17:25AM +0800, Inochi Amaoto wrote:
> >> Add device binding and dts for CV18XX series SoC, this dts change series
> >> required the reset patch [1] for the dts, which is already taken.
> >>
> >> [1] https://lore.kernel.org/all/20250617070144.1149926-1-inochiama@gmail.com
> >>
> >> The patch is marked as RFC as it require reset dts.
> >>
> >> Change from RFC v3:
> >> - https://lore.kernel.org/all/20250626080056.325496-1-inochiama@gmail.com
> >> 1. patch 3: change internal phy id from 0 to 1
> >>
> >> Change from RFC v2:
> >> - https://lore.kernel.org/all/20250623003049.574821-1-inochiama@gmail.com
> >> 1. patch 1: fix wrong binding title
> >> 2. patch 3: fix unmatched mdio bus number
> >> 3. patch 4: remove setting phy-mode and phy-handle in board dts and move
> >> 	    them into patch 3.
> >>
> >> Change from RFC v1:
> >> - https://lore.kernel.org/all/20250611080709.1182183-1-inochiama@gmail.com
> >> 1. patch 3: switch to mdio-mux-mmioreg
> >> 2. patch 4: add configuration for Huashan Pi
> >>
> >> Inochi Amaoto (4):
> >>   dt-bindings: net: Add support for Sophgo CV1800 dwmac
> >>   riscv: dts: sophgo: Add ethernet device for cv18xx
> >>   riscv: dts: sophgo: Add mdio multiplexer device for cv18xx
> >>   riscv: dts: sophgo: Enable ethernet device for Huashan Pi
> >>
> >>  .../bindings/net/sophgo,cv1800b-dwmac.yaml    | 113 ++++++++++++++++++
> >>  arch/riscv/boot/dts/sophgo/cv180x.dtsi        |  73 +++++++++++
> >>  .../boot/dts/sophgo/cv1812h-huashan-pi.dts    |   8 ++
> >>  3 files changed, 194 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/net/sophgo,cv1800b-dwmac.yaml
> >>
> >> --
> >> 2.50.0
> >>
> > 
> > As this is mark as RFC due to the reset dependency, now it is OK
> > to merge it as the reset patch is taken and this patch is a minor
> > change . I hopeif anyone can take the binding patch so I can take
> > the devicetree patches.
> 
> I don't understand why you target net-next with your DTS patches.

I just want to make them all get reviewed, as the dts patch is
related to the binding.
 
> The subject prefix is here not correct and probably this should be
> split. Anyway, bindings have issues, so no, it cannot be merged.
> 

Thanks, I will separate the binding patch and fix the issue.

Regards,
Inochi



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv