Re: [PATCH] riscv: dts: starfive: jh7110-common: drop no-sdio property from mmc1

From: Conor Dooley <conor@kernel.org>
To: E Shattow <e@freeshell.de>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	William Qiu <william.qiu@starfivetech.com>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Hal Feng <hal.feng@starfivetech.com>,
	Minda Chen <minda.chen@starfivetech.com>
Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: drop no-sdio property from mmc1
Date: Mon, 28 Jul 2025 20:36:57 +0100	[thread overview]
Message-ID: <20250728-urethane-backside-52dfb7b96b3b@spud> (raw)
In-Reply-To: <8841923c-cbb6-4cce-97f4-a851783b6102@freeshell.de>

[-- Attachment #1.1: Type: text/plain, Size: 1397 bytes --]

On Sun, Jul 27, 2025 at 08:52:50PM -0700, E Shattow wrote:

> >> Yes, I can rephrase a bit like "relax no-sdio restriction on mmc1 for
> >> jh7110 boards", or else reconsider the approach. I was going to approach
> >> with `/delete-property/ no-sdio;` later elsewhere but after testing on
> >> Pine64 Star64 with similar configuration to VisionFive2 mmc interfaces,
> >> and knowing that Milk-V Mars CM Lite WiFi detects AP6256 SDIO peripheral
> >> at mmc1 when this property is dropped (and with a few additional
> >> things)... I prefer to reduce the problems that would need to be avoided.
> > 
> > I think using /delete-property/ would be unwise, properties shouldn't be
> > in the common dtsi if they are not, in fact, common.
> > 
> 
> Ack, you wanted these moved out into each board dts? That would be okay
> with me. I suspected that `no-sdio` `no-mmc` don't belong so I'm still
> in favor of dropping them overall. I think nothing will break but I want
> more data from users.

Ye, moved out to the board dts is my preference over using /delete-property/.
Things that aren't actually common shouldn't be in the common file. I do
agree that in this case, removal entirely is probably the right call.
There's some sdio wifi cards that can go into sd card slots, so just
because the mmc controller is connected to a sd card slot doesn't mean
no-sdio should be used.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv