From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4184C87FCE for ; Mon, 28 Jul 2025 09:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yT8mUP7/t4BC7yeQNIQZ+U2FMyL7YvpNs+Q0f+WzVX0=; b=LJ97UzEAZ4jeZV BePD7OYWnwIQVcByTyvVZ5nHsC6RgtUW1u282A4J1vzbJ8OXfALpzzQ9dT9e6wdwWg3vRVN7OrtC/ 97FeUTALm3mX+gchW5clyiiClnmHl2cC28WCGiku1C9RSvaM9tomLcga5ZAh3EQvOBhZ1jzTGqGNL LNTmn2KZlPPNz7x7bJ1KNZhLzhfgilpm5cVUW+W+3jsJUgL1uSzMgijYMync9Xd+OZzEqHSmlMc8I jVjZY9hPszgmIna5AnGO0gbe2P9UEJqEbi1bxaNn8VbumPKIGXyu2n263BI/jsb+eNqdMOBXU3MRF XLdPnjC30JtOWFFG5M/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugKMg-0000000E7u8-0pYA; Mon, 28 Jul 2025 09:41:50 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugKMe-0000000E7se-0aSw for linux-riscv@lists.infradead.org; Mon, 28 Jul 2025 09:41:49 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-23636167afeso36104055ad.3 for ; Mon, 28 Jul 2025 02:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1753695707; x=1754300507; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TIg/1GBTKsBFC54o9wzP/NH34EZtppmVu7UpxaXegaQ=; b=mQGciuW49gOSPoHAQDznzJVj8FSB+rrv1a2srHlY4bno7yIEIM5+HCwIUnJNRuWyWt 6/4XRbat3OF7qPdu56y2p2c8Su2F9NQCzL/4Wd4VT+6sYzKnIobxxrfpEUvWWYmW6Vt0 OKShLVJCwW2eyl/7M3YjSISu/w3WtUwtuvdhs1eqCQwlLJ/H8cEKTPDj5tbPo2t4nnXl XjbOttw8lNYGt5cIcekd3aUHuReU3xLh64AU0C0AKkgiHMoEAnSY0kAlHxioZlVGXSZl PyMHyIU30qiClStVthCLS7l1PLgJxg+53Ia4LDM1W5ZbhYp4Uh+g5lWhIsC89pu2cWsG vapA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753695707; x=1754300507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TIg/1GBTKsBFC54o9wzP/NH34EZtppmVu7UpxaXegaQ=; b=f1/ghbdd8hIFUypfaRvvVVQzjA78Z70sCcGQ0gQyah/6Dstbdq/0EOsjjzjR4xi2pe JLyugGhxsXEBcjbIkzqFpgqAza+Si7bRoIIAKsGqQCKm1EWhdNgLoCF2xTKiYQM0nqlc ib1NWX5cuXA4NLqIB805iiFBdY8unxbBarfQRcIQLcdz1z+nZLruIeEMB7ezBP4I9tFe 28RbOmdFeTeSK0iKrPtofSEO1AIGIOUvO3aMUQdD2lE/R4+ADWePMdDIRplOzPQlayE2 S8o3oSgYQ6jV5SMLE5DNVtFCaUx96Fh91h9lossTc6lR1TC/KBtMmqakhoAx2QO3Cetm 5HOg== X-Forwarded-Encrypted: i=1; AJvYcCV1eKNQf2q9IF8vUImV4tBpsF7tnG2rfQWf1vHmm6qwzFKiN8b7/H2xFj7AgS84HQocykY3Y7u5NIg+nw==@lists.infradead.org X-Gm-Message-State: AOJu0YyFfkIwABCj242D2Jk2w/DpffXUXuEjDgg9jtz9Wk84sb2bOpb4 +qHv2MP9i6zyPpM/SMJEnElHDmeuTp9r1X4dvemHM/686NR3kDusJQieXIiEp4u+gdQ= X-Gm-Gg: ASbGncsHaDYq5sbk0IqaQzqfBNsET+2mMYLJU0dT/tilhYe3M3fQe9MFAu56YaQdMP6 lgOtzl6umXfwUaC1DnPX/ES61+OqGrIw/teLP3LJDGQyHQ0lLAJ/uk9qQH/BSrsxZ2Nkgn1EVLa 93+yvxh2+/tYkEl1ZXZULV7kYPCbZ2cZkyoo27VN30fCewPAyEVtUsJRlJvKSzn8Gfu5JXdiuFV 8sz/LK9NJ+2c0Fk/v3Vj6JrG7EqXTKNnS50T1dICccPuoxEbpspBb1x7z2yHRoorxMiNnSmoSHZ IXicWFTeeHKxjKOOPdTHTFNOL1IEMe0Haei5NgPjA3Na4Ovnyo4wzf1Ik+ayieKJpikkHGlRsrl aVfDAy8Cn+ZnMiIOve2r40Q+BqRCJYhGZBcFBq8ihioKePrZv5n23d49YscLF X-Google-Smtp-Source: AGHT+IFlHjmFiEXU2dJH97grCLi/iSNAvTJn9LNOpuW/QlLPoDnHitMrBp8pd3yh4EaT11w8/znf0A== X-Received: by 2002:a17:902:f652:b0:23c:8f4c:6658 with SMTP id d9443c01a7336-23fb315ab2bmr140862815ad.25.1753695707124; Mon, 28 Jul 2025 02:41:47 -0700 (PDT) Received: from anup-ubuntu-vm.localdomain ([122.171.19.28]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31e832fbf99sm5396230a91.1.2025.07.28.02.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jul 2025 02:41:46 -0700 (PDT) From: Anup Patel To: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , "Rafael J . Wysocki" , Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH v9 05/24] mailbox: Allow controller specific mapping using fwnode Date: Mon, 28 Jul 2025 15:10:13 +0530 Message-ID: <20250728094032.63545-6-apatel@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250728094032.63545-1-apatel@ventanamicro.com> References: <20250728094032.63545-1-apatel@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250728_024148_179856_6C03FBE5 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , devicetree@vger.kernel.org, Andrew Jones , Alexandre Ghiti , Atish Patra , Leyfoon Tan , Anup Patel , linux-kernel@vger.kernel.org, Samuel Holland , linux-acpi@vger.kernel.org, Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, Len Brown , linux-clk@vger.kernel.org, Rahul Pathak Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Introduce optional fw_node() callback which allows a mailbox controller driver to provide controller specific mapping using fwnode. The Linux OF framework already implements fwnode operations for the Linux DD framework so the fw_xlate() callback works fine with device tree as well. Acked-by: Jassi Brar Reviewed-by: Andy Shevchenko Signed-off-by: Anup Patel --- drivers/mailbox/mailbox.c | 65 ++++++++++++++++++------------ include/linux/mailbox_controller.h | 3 ++ 2 files changed, 43 insertions(+), 25 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 5cd8ae222073..2acc6ec229a4 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include "mailbox.h" @@ -383,34 +384,56 @@ EXPORT_SYMBOL_GPL(mbox_bind_client); */ struct mbox_chan *mbox_request_channel(struct mbox_client *cl, int index) { - struct device *dev = cl->dev; + struct fwnode_reference_args fwspec; + struct fwnode_handle *fwnode; struct mbox_controller *mbox; struct of_phandle_args spec; struct mbox_chan *chan; + struct device *dev; + unsigned int i; int ret; - if (!dev || !dev->of_node) { - pr_debug("%s: No owner device node\n", __func__); + dev = cl->dev; + if (!dev) { + pr_debug("No owner device\n"); return ERR_PTR(-ENODEV); } - ret = of_parse_phandle_with_args(dev->of_node, "mboxes", "#mbox-cells", - index, &spec); + fwnode = dev_fwnode(dev); + if (!fwnode) { + dev_dbg(dev, "No owner fwnode\n"); + return ERR_PTR(-ENODEV); + } + + ret = fwnode_property_get_reference_args(fwnode, "mboxes", "#mbox-cells", + 0, index, &fwspec); if (ret) { - dev_err(dev, "%s: can't parse \"mboxes\" property\n", __func__); + dev_err(dev, "%s: can't parse \"%s\" property\n", __func__, "mboxes"); return ERR_PTR(ret); } + spec.np = to_of_node(fwspec.fwnode); + spec.args_count = fwspec.nargs; + for (i = 0; i < spec.args_count; i++) + spec.args[i] = fwspec.args[i]; + scoped_guard(mutex, &con_mutex) { chan = ERR_PTR(-EPROBE_DEFER); - list_for_each_entry(mbox, &mbox_cons, node) - if (mbox->dev->of_node == spec.np) { - chan = mbox->of_xlate(mbox, &spec); - if (!IS_ERR(chan)) - break; + list_for_each_entry(mbox, &mbox_cons, node) { + if (device_match_fwnode(mbox->dev, fwspec.fwnode)) { + if (mbox->fw_xlate) { + chan = mbox->fw_xlate(mbox, &fwspec); + if (!IS_ERR(chan)) + break; + } else if (mbox->of_xlate) { + chan = mbox->of_xlate(mbox, &spec); + if (!IS_ERR(chan)) + break; + } } + } - of_node_put(spec.np); + fwnode_handle_put(fwspec.fwnode); if (IS_ERR(chan)) return chan; @@ -427,15 +450,8 @@ EXPORT_SYMBOL_GPL(mbox_request_channel); struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl, const char *name) { - struct device_node *np = cl->dev->of_node; - int index; - - if (!np) { - dev_err(cl->dev, "%s() currently only supports DT\n", __func__); - return ERR_PTR(-EINVAL); - } + int index = device_property_match_string(cl->dev, "mbox-names", name); - index = of_property_match_string(np, "mbox-names", name); if (index < 0) { dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n", __func__, name); @@ -470,9 +486,8 @@ void mbox_free_channel(struct mbox_chan *chan) } EXPORT_SYMBOL_GPL(mbox_free_channel); -static struct mbox_chan * -of_mbox_index_xlate(struct mbox_controller *mbox, - const struct of_phandle_args *sp) +static struct mbox_chan *fw_mbox_index_xlate(struct mbox_controller *mbox, + const struct fwnode_reference_args *sp) { int ind = sp->args[0]; @@ -523,8 +538,8 @@ int mbox_controller_register(struct mbox_controller *mbox) spin_lock_init(&chan->lock); } - if (!mbox->of_xlate) - mbox->of_xlate = of_mbox_index_xlate; + if (!mbox->fw_xlate && !mbox->of_xlate) + mbox->fw_xlate = fw_mbox_index_xlate; scoped_guard(mutex, &con_mutex) list_add_tail(&mbox->node, &mbox_cons); diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index ad01c4082358..80a427c7ca29 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -66,6 +66,7 @@ struct mbox_chan_ops { * no interrupt rises. Ignored if 'txdone_irq' is set. * @txpoll_period: If 'txdone_poll' is in effect, the API polls for * last TX's status after these many millisecs + * @fw_xlate: Controller driver specific mapping of channel via fwnode * @of_xlate: Controller driver specific mapping of channel via DT * @poll_hrt: API private. hrtimer used to poll for TXDONE on all * channels. @@ -79,6 +80,8 @@ struct mbox_controller { bool txdone_irq; bool txdone_poll; unsigned txpoll_period; + struct mbox_chan *(*fw_xlate)(struct mbox_controller *mbox, + const struct fwnode_reference_args *sp); struct mbox_chan *(*of_xlate)(struct mbox_controller *mbox, const struct of_phandle_args *sp); /* Internal to API */ -- 2.43.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv