linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI
@ 2025-08-13  8:17 Icenowy Zheng
  2025-08-13  8:17 ` [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets Icenowy Zheng
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Icenowy Zheng @ 2025-08-13  8:17 UTC (permalink / raw)
  To: Drew Fustini, Guo Ren, Fu Wei, Philipp Zabel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Michal Wilczynski, Yao Zi, Han Gao, linux-riscv, devicetree,
	linux-kernel, Icenowy Zheng

The VOSYS subsystem of T-Head TH1520 SoC contains a set of display
pipeline in addition to the GPU. The display pipeline contains a DPU
(display controller), a HDMI controller and 2 DSI controllers.

This patchset adds reset controls for these devices.

Icenowy Zheng (2):
  dt-bindings: reset: thead,th1520-reset: add more VOSYS resets
  reset: th1520: add resets for display pipeline

 drivers/reset/reset-th1520.c                  | 40 ++++++++++++++++++-
 .../dt-bindings/reset/thead,th1520-reset.h    |  7 ++++
 2 files changed, 46 insertions(+), 1 deletion(-)

-- 
2.50.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets
  2025-08-13  8:17 [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Icenowy Zheng
@ 2025-08-13  8:17 ` Icenowy Zheng
  2025-08-13 17:00   ` Conor Dooley
  2025-08-13  8:17 ` [PATCH 2/2] reset: th1520: add resets for display pipeline Icenowy Zheng
  2025-08-14 10:55 ` [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Philipp Zabel
  2 siblings, 1 reply; 6+ messages in thread
From: Icenowy Zheng @ 2025-08-13  8:17 UTC (permalink / raw)
  To: Drew Fustini, Guo Ren, Fu Wei, Philipp Zabel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Michal Wilczynski, Yao Zi, Han Gao, linux-riscv, devicetree,
	linux-kernel, Icenowy Zheng

VOSYS contains more resets for a display pipeline, includes ones for the
display controller (called DPU in the manual), the HDMI controller and 2
MIPI DSI controllers.

Allocate IDs for these resets in the dt binding header file.

Now all peripheral related VOSYS reset controls are here, only the bus
matrix / IOPMP ones are missing, which shouldn't be messed with.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
 include/dt-bindings/reset/thead,th1520-reset.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/dt-bindings/reset/thead,th1520-reset.h b/include/dt-bindings/reset/thead,th1520-reset.h
index 00459f1604897..ee799286c1754 100644
--- a/include/dt-bindings/reset/thead,th1520-reset.h
+++ b/include/dt-bindings/reset/thead,th1520-reset.h
@@ -12,5 +12,12 @@
 #define TH1520_RESET_ID_NPU		2
 #define TH1520_RESET_ID_WDT0		3
 #define TH1520_RESET_ID_WDT1		4
+#define TH1520_RESET_ID_DPU_AHB		5
+#define TH1520_RESET_ID_DPU_AXI		6
+#define TH1520_RESET_ID_DPU_CORE	7
+#define TH1520_RESET_ID_DSI0_APB	8
+#define TH1520_RESET_ID_DSI1_APB	9
+#define TH1520_RESET_ID_HDMI		10
+#define TH1520_RESET_ID_HDMI_APB	11
 
 #endif /* _DT_BINDINGS_TH1520_RESET_H */
-- 
2.50.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] reset: th1520: add resets for display pipeline
  2025-08-13  8:17 [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Icenowy Zheng
  2025-08-13  8:17 ` [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets Icenowy Zheng
@ 2025-08-13  8:17 ` Icenowy Zheng
  2025-08-14  7:11   ` Philipp Zabel
  2025-08-14 10:55 ` [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Philipp Zabel
  2 siblings, 1 reply; 6+ messages in thread
From: Icenowy Zheng @ 2025-08-13  8:17 UTC (permalink / raw)
  To: Drew Fustini, Guo Ren, Fu Wei, Philipp Zabel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Michal Wilczynski, Yao Zi, Han Gao, linux-riscv, devicetree,
	linux-kernel, Icenowy Zheng

The VO subsystem of TH1520 contains a few resets for the display
pipeline -- display, MIPI DSI and HDMI controllers.

Add support for them to the reset-th1520 driver.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
 drivers/reset/reset-th1520.c | 40 +++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/reset-th1520.c b/drivers/reset/reset-th1520.c
index 7874f0693e1b4..06e5dff7c524d 100644
--- a/drivers/reset/reset-th1520.c
+++ b/drivers/reset/reset-th1520.c
@@ -14,10 +14,20 @@
  /* register offset in VOSYS_REGMAP */
 #define TH1520_GPU_RST_CFG		0x0
 #define TH1520_GPU_RST_CFG_MASK		GENMASK(1, 0)
+#define TH1520_DPU_RST_CFG		0x4
+#define TH1520_DSI0_RST_CFG		0x8
+#define TH1520_DSI1_RST_CFG		0xc
+#define TH1520_HDMI_RST_CFG		0x14
 
 /* register values */
 #define TH1520_GPU_SW_GPU_RST		BIT(0)
 #define TH1520_GPU_SW_CLKGEN_RST	BIT(1)
+#define TH1520_DPU_SW_DPU_HRST		BIT(0)
+#define TH1520_DPU_SW_DPU_ARST		BIT(1)
+#define TH1520_DPU_SW_DPU_CRST		BIT(2)
+#define TH1520_DSI_SW_DSI_PRST		BIT(0)
+#define TH1520_HDMI_SW_MAIN_RST		BIT(0)
+#define TH1520_HDMI_SW_PRST		BIT(1)
 
 struct th1520_reset_priv {
 	struct reset_controller_dev rcdev;
@@ -37,7 +47,35 @@ static const struct th1520_reset_map th1520_resets[] = {
 	[TH1520_RESET_ID_GPU_CLKGEN] = {
 		.bit = TH1520_GPU_SW_CLKGEN_RST,
 		.reg = TH1520_GPU_RST_CFG,
-	}
+	},
+	[TH1520_RESET_ID_DPU_AHB] = {
+		.bit = TH1520_DPU_SW_DPU_HRST,
+		.reg = TH1520_DPU_RST_CFG,
+	},
+	[TH1520_RESET_ID_DPU_AXI] = {
+		.bit = TH1520_DPU_SW_DPU_ARST,
+		.reg = TH1520_DPU_RST_CFG,
+	},
+	[TH1520_RESET_ID_DPU_CORE] = {
+		.bit = TH1520_DPU_SW_DPU_CRST,
+		.reg = TH1520_DPU_RST_CFG,
+	},
+	[TH1520_RESET_ID_DSI0_APB] = {
+		.bit = TH1520_DSI_SW_DSI_PRST,
+		.reg = TH1520_DSI0_RST_CFG,
+	},
+	[TH1520_RESET_ID_DSI1_APB] = {
+		.bit = TH1520_DSI_SW_DSI_PRST,
+		.reg = TH1520_DSI1_RST_CFG,
+	},
+	[TH1520_RESET_ID_HDMI] = {
+		.bit = TH1520_HDMI_SW_MAIN_RST,
+		.reg = TH1520_HDMI_RST_CFG,
+	},
+	[TH1520_RESET_ID_HDMI_APB] = {
+		.bit = TH1520_HDMI_SW_PRST,
+		.reg = TH1520_HDMI_RST_CFG,
+	},
 };
 
 static inline struct th1520_reset_priv *
-- 
2.50.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets
  2025-08-13  8:17 ` [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets Icenowy Zheng
@ 2025-08-13 17:00   ` Conor Dooley
  0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2025-08-13 17:00 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Drew Fustini, Guo Ren, Fu Wei, Philipp Zabel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Michal Wilczynski, Yao Zi,
	Han Gao, linux-riscv, devicetree, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

On Wed, Aug 13, 2025 at 04:17:15PM +0800, Icenowy Zheng wrote:
> VOSYS contains more resets for a display pipeline, includes ones for the
> display controller (called DPU in the manual), the HDMI controller and 2
> MIPI DSI controllers.
> 
> Allocate IDs for these resets in the dt binding header file.
> 
> Now all peripheral related VOSYS reset controls are here, only the bus
> matrix / IOPMP ones are missing, which shouldn't be messed with.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] reset: th1520: add resets for display pipeline
  2025-08-13  8:17 ` [PATCH 2/2] reset: th1520: add resets for display pipeline Icenowy Zheng
@ 2025-08-14  7:11   ` Philipp Zabel
  0 siblings, 0 replies; 6+ messages in thread
From: Philipp Zabel @ 2025-08-14  7:11 UTC (permalink / raw)
  To: Icenowy Zheng, Drew Fustini, Guo Ren, Fu Wei, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Michal Wilczynski, Yao Zi, Han Gao, linux-riscv, devicetree,
	linux-kernel

On Mi, 2025-08-13 at 16:17 +0800, Icenowy Zheng wrote:
> The VO subsystem of TH1520 contains a few resets for the display
> pipeline -- display, MIPI DSI and HDMI controllers.
> 
> Add support for them to the reset-th1520 driver.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI
  2025-08-13  8:17 [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Icenowy Zheng
  2025-08-13  8:17 ` [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets Icenowy Zheng
  2025-08-13  8:17 ` [PATCH 2/2] reset: th1520: add resets for display pipeline Icenowy Zheng
@ 2025-08-14 10:55 ` Philipp Zabel
  2 siblings, 0 replies; 6+ messages in thread
From: Philipp Zabel @ 2025-08-14 10:55 UTC (permalink / raw)
  To: Icenowy Zheng, Drew Fustini, Guo Ren, Fu Wei, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Michal Wilczynski, Yao Zi, Han Gao, linux-riscv, devicetree,
	linux-kernel

On Mi, 2025-08-13 at 16:17 +0800, Icenowy Zheng wrote:
> The VOSYS subsystem of T-Head TH1520 SoC contains a set of display
> pipeline in addition to the GPU. The display pipeline contains a DPU
> (display controller), a HDMI controller and 2 DSI controllers.
> 
> This patchset adds reset controls for these devices.
> 
> Icenowy Zheng (2):
>   dt-bindings: reset: thead,th1520-reset: add more VOSYS resets
>   reset: th1520: add resets for display pipeline
[...]

Applied to reset/next, thanks!

[1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=f443d7c9ed46
[2/2] reset: th1520: add resets for display pipeline
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=d342031a5238

regards
Philipp


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-08-14 15:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13  8:17 [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Icenowy Zheng
2025-08-13  8:17 ` [PATCH 1/2] dt-bindings: reset: thead,th1520-reset: add more VOSYS resets Icenowy Zheng
2025-08-13 17:00   ` Conor Dooley
2025-08-13  8:17 ` [PATCH 2/2] reset: th1520: add resets for display pipeline Icenowy Zheng
2025-08-14  7:11   ` Philipp Zabel
2025-08-14 10:55 ` [PATCH 0/2] reset: th1520: add VOSYS resets for DPU/HDMI/DSI Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).