From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE137CA0EFA for ; Fri, 22 Aug 2025 03:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dt2QSUJ3YOU+zdYPPNLlRYRtXgsTs+YHt+K0auVPYTA=; b=I8wt1ulrMzlV/A z4AOpMY4uzZNAsOqwbT3vWq4qoYZ8fKKlMzNy+j6PuQjHLx5R09hXk8PYwCkd2CChWzNCD65TCidk ZcoCtlSWaeSMsTlQk3kLnh+K184OPFaakrSItaUdelRlpjOcPgDw1D4aUcZUeIg+83wn1aJfWtT4v MO10c6yQgZM07TivAX87jD2aVI7itgRhqPdadvGROs4Fycb20YAK7pKXLrdl9LrG8Ko36baE0K8br sT8rXiCFAJ7iD1VYP4HCb9gTyoq9MDUkqU+Oe90XcDBLoVT2b1K1ke9qDyEcRJmFwoIUOUGu4e80T R6U3QfCJrD6ZPQtOxVjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1upIWb-00000001OaA-0rrC; Fri, 22 Aug 2025 03:33:09 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1upDOe-00000000iBa-0xEp for linux-riscv@lists.infradead.org; Thu, 21 Aug 2025 22:04:37 +0000 Received: from localhost (unknown [180.158.240.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id AD411340441; Thu, 21 Aug 2025 22:04:34 +0000 (UTC) Date: Fri, 22 Aug 2025 06:04:30 +0800 From: Yixun Lan To: Hendrik Hamerlinck Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] riscv: dts: spacemit: add UART resets for Soc K1 Message-ID: <20250821220430-GYA1070455@gentoo> References: <20250821152619.597051-1-hendrik.hamerlinck@hammernet.be> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250821152619.597051-1-hendrik.hamerlinck@hammernet.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250821_150436_290014_DBA45F81 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 17:26 Thu 21 Aug , Hendrik Hamerlinck wrote: > The UARTs in the SpacemiT K1 device tree are probed by the 8250_of driver, > but without reset lines they remain non-functional. > > Add reset control entries so that the UARTs can operate when mapped to > devices. UART0 is already de-asserted by the bootloader, but include its > reset as well to avoid relying on bootloader state. > > Tested on Orange Pi RV2 and Banana Pi BPI-F3 boards, with UART9 enabled > and verified functional. > > Signed-off-by: Hendrik Hamerlinck Reviewed-by: Yixun Lan > --- > Changes in v2: > - Improved changelog > - Omitted current-speed property for UART0 > --- > arch/riscv/boot/dts/spacemit/k1.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi > index abde8bb07c95..6c68b2e54675 100644 > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > @@ -667,6 +667,7 @@ uart0: serial@d4017000 { > clocks = <&syscon_apbc CLK_UART0>, > <&syscon_apbc CLK_UART0_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART0>; > interrupts = <42>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -680,6 +681,7 @@ uart2: serial@d4017100 { > clocks = <&syscon_apbc CLK_UART2>, > <&syscon_apbc CLK_UART2_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART2>; > interrupts = <44>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -693,6 +695,7 @@ uart3: serial@d4017200 { > clocks = <&syscon_apbc CLK_UART3>, > <&syscon_apbc CLK_UART3_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART3>; > interrupts = <45>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -706,6 +709,7 @@ uart4: serial@d4017300 { > clocks = <&syscon_apbc CLK_UART4>, > <&syscon_apbc CLK_UART4_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART4>; > interrupts = <46>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -719,6 +723,7 @@ uart5: serial@d4017400 { > clocks = <&syscon_apbc CLK_UART5>, > <&syscon_apbc CLK_UART5_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART5>; > interrupts = <47>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -732,6 +737,7 @@ uart6: serial@d4017500 { > clocks = <&syscon_apbc CLK_UART6>, > <&syscon_apbc CLK_UART6_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART6>; > interrupts = <48>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -745,6 +751,7 @@ uart7: serial@d4017600 { > clocks = <&syscon_apbc CLK_UART7>, > <&syscon_apbc CLK_UART7_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART7>; > interrupts = <49>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -758,6 +765,7 @@ uart8: serial@d4017700 { > clocks = <&syscon_apbc CLK_UART8>, > <&syscon_apbc CLK_UART8_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART8>; > interrupts = <50>; > reg-shift = <2>; > reg-io-width = <4>; > @@ -771,6 +779,7 @@ uart9: serial@d4017800 { > clocks = <&syscon_apbc CLK_UART9>, > <&syscon_apbc CLK_UART9_BUS>; > clock-names = "core", "bus"; > + resets = <&syscon_apbc RESET_UART9>; > interrupts = <51>; > reg-shift = <2>; > reg-io-width = <4>; > -- > 2.43.0 > -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv