From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C711CA0FE1 for ; Mon, 25 Aug 2025 08:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/eZxayObKH295QGaPzxXEpHklfOfbhMw5PVFoo3Wz8=; b=X1K/ydN7mpSGQi wvmV3kaaG6Ad26nPZpBst65tTfU1RWYziwMavwyCMxfMMviS4MFSDZYxsMAlLjkPGyq7Xz25YkqoC wygED8+uFfZCp1S0Ja+JExMS8bcZ1IUmWcwXQmfFejczjqsp4LNqS9EELB1ppZckLuUrL2faOuX3x w+8O4EMJxiWMm24J6WIqMF+kxnIsw0ZXVhzNyoVmXA9D5xolg9sT/rgTmidEF3rg/1D5tVfOyP4cB C6gedWCYTJ7loQuhCEZdxXcm4lE7WdYr4y3l0uKx2t2wy6c31PrFYhRz8i/IXrMKGGI6AiYzR5Ar7 Nhk9kPm+LBPw4mShwg9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqSzS-00000007PdV-1AlV; Mon, 25 Aug 2025 08:55:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqSlL-00000007MGh-2jND; Mon, 25 Aug 2025 08:41:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 956795C4C29; Mon, 25 Aug 2025 08:41:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7064FC4CEF1; Mon, 25 Aug 2025 08:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756111270; bh=YvGhFydXbrmE9yimRweNKCZChGzfZ1CATQpB6bIekEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOMZ2uUVb/0wo3syOidoV1f0HRnUy2RJHSLMdGqk7yLVCovHqwhjwaAlh5RRjGhHZ vntVwdIrQaIPc6RHyWqxDvKuJf4yALVzvwSkz6MQRZOCjYqhY5PmaPIKYrOPpB1p8u ZQQcgaSOLbnXSBweKyIJlNLbQ4eko+2s1j1Kyd2DdcthL3uR+6Q+zm9V6VZoqVXEwk YjSDNkhA9rZ9AoJyJlfQ5AVgcfN/tGkd589lOdTPjxZRJZFSYBmnMyeGFXPtEjvyYF AaBOk5ZqAGeb9e0X69QoM8YFdfSFRB83tOPM4vDNmgfhRwb0C+7Wd6fILQWTsgyp8c FHQseDkSJrtGw== Date: Mon, 25 Aug 2025 16:41:07 +0800 From: Yixun Lan To: bmasney@redhat.com Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 050/114] clk: spacemit: ccu_mix: convert from round_rate() to determine_rate() Message-ID: <20250825084107-GYB1096417@kernel.org> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-50-b3bf97b038dc@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-50-b3bf97b038dc@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250825_014111_771530_D4A167CA X-CRM114-Status: GOOD ( 19.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Brian, On 11:18 Mon 11 Aug , Brian Masney via B4 Relay wrote: > From: Brian Masney > > The round_rate() clk ops is deprecated, so migrate this driver from > round_rate() to determine_rate() using the Coccinelle semantic patch > on the cover letter of this series. > > Signed-off-by: Brian Masney Reviewed-by: Yixun Lan > --- > drivers/clk/spacemit/ccu_mix.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/spacemit/ccu_mix.c b/drivers/clk/spacemit/ccu_mix.c > index 9b852aa61f78aed5256bfe6fc3b01932d6db6256..7b7990875372314dce131295af7f40267d0a127a 100644 > --- a/drivers/clk/spacemit/ccu_mix.c > +++ b/drivers/clk/spacemit/ccu_mix.c > @@ -80,10 +80,12 @@ static int ccu_mix_trigger_fc(struct clk_hw *hw) > MIX_FC_TIMEOUT_US); > } > > -static long ccu_factor_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *prate) > +static int ccu_factor_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > - return ccu_factor_recalc_rate(hw, *prate); > + req->rate = ccu_factor_recalc_rate(hw, req->best_parent_rate); > + > + return 0; > } > > static int ccu_factor_set_rate(struct clk_hw *hw, unsigned long rate, > @@ -198,7 +200,7 @@ const struct clk_ops spacemit_ccu_gate_ops = { > }; > > const struct clk_ops spacemit_ccu_factor_ops = { > - .round_rate = ccu_factor_round_rate, > + .determine_rate = ccu_factor_determine_rate, > .recalc_rate = ccu_factor_recalc_rate, > .set_rate = ccu_factor_set_rate, > }; > @@ -220,7 +222,7 @@ const struct clk_ops spacemit_ccu_factor_gate_ops = { > .enable = ccu_gate_enable, > .is_enabled = ccu_gate_is_enabled, > > - .round_rate = ccu_factor_round_rate, > + .determine_rate = ccu_factor_determine_rate, > .recalc_rate = ccu_factor_recalc_rate, > .set_rate = ccu_factor_set_rate, > }; > > -- > 2.50.1 > > -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv