From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46217CA0FF9 for ; Fri, 29 Aug 2025 01:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Y9XrL7vOUpZdtz6Duc3HiwWp46ge3kl9ThbDj1dR9s=; b=Za8vYvQ8/BlGcO S1DwbquDrEVQdvhHYYJF/5kVOh/lc4/rG3TLs2xnAWOz1BqdviH0AB8xXvb3K1AYTatoNTc6BvI8V PWJq6Nj8u2uJYQOUjJQdK/Tz/66Js4vESFBIy4v+Tby/SHCwC9t4uvzRVOC9x9i6fnFNP3zJP2/CQ adTKSWGSkiXGB/kYXgTmKQr2YihdjL30tv6W32xMKgSI6VqPtyxPfNeH7mhFQLU2qc988eskYAWM8 UjbGHqKHp+GNsUXT/53JhUUsznKE9M6Dony3JVTOyZQphRAtvMe700PdeeNSVFAEP8iHVyupd8kbu bxtF+W3QCoIS1DQkxLXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urndM-00000003xO0-2O9K; Fri, 29 Aug 2025 01:10:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urhk4-00000002s3z-3OPA for linux-riscv@lists.infradead.org; Thu, 28 Aug 2025 18:53:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756407178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ox+fdqHLvqvHkCQcV7jSITHMPKa6EWT2tpRcTnamaBA=; b=E5WBwKoGQo9zqO/HLEpsrkpXIOyUZpErlYEJrl85UZI+vKSRJUAQwMGOSSx7lqmu1cb2CU 5fJc4OMGF0GVr4Wi8tvBRYFzTmMWW2MwRdrH7RZy/1YiuyYZ25Najtv/JZrrWbeSqGya4e 4F4ikQb7l52dvkvpxswwKeBKqLFNOfA= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-Aj9YJjKjOiuqassiH1pw8w-1; Thu, 28 Aug 2025 14:52:57 -0400 X-MC-Unique: Aj9YJjKjOiuqassiH1pw8w-1 X-Mimecast-MFC-AGG-ID: Aj9YJjKjOiuqassiH1pw8w_1756407177 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-3e8dffcf41eso1108185ab.0 for ; Thu, 28 Aug 2025 11:52:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756407176; x=1757011976; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ox+fdqHLvqvHkCQcV7jSITHMPKa6EWT2tpRcTnamaBA=; b=wb5dju4cD28q16al0719SPHuLFIbAshEvdpr+wb9u2f6JdjnDKXxjyOJfNsEWZy/dQ Q3z/HVz80hv96ZjTkNuoN79IxZmmzLSATfj3l+nyHj4iRV4IUH3yMeCjzJMaogb1Db2q LSngwbTu5wSog6e8u88ZfaMvN0eUzpsTBgX4A2Ec4d6eSCwpxpBWzq9cz+M39TpaGCV/ /HQbWNkUJkanqLpq01cvj3ziN72YKok/Sln0yyo8COGG/F73UursamMGQj7HtVeFFRJW rcIp0PmFFrrDit3AVb+ZievFr+S+9wqKYTKcgOgh5rSnW86xv9xcOaA3edP318o0HF6Q iDKQ== X-Forwarded-Encrypted: i=1; AJvYcCVOhmfi9ND4bgzPRQv4LbK89ilgIGbPZn5YHLrJrI6rZl1cOPeRfPu0OU2LByWu2gUQgs4EOyNJ9ouhnw==@lists.infradead.org X-Gm-Message-State: AOJu0Yy7H73yhxS45tWq7YKhILogYh7pKCJnwhGQZYFb1kuow5f0FJFv SPKRZR37uCjxACxCTcfBBZdDhfcN/HVzG859cV6ZjT4YKWrZu7BhYCMV8ks6IN+6S06sP3sfM2I xdvZIq1bwnxOfe1rYK115c8x5emDpBYR/uPFElRvBx2BTljkuMMFRDztdqozsujRarvYSgg== X-Gm-Gg: ASbGncuAtaGAZibMcRX0fKKv8ynou0ql21vEiFZwHfpkuwixsc2k9SZE65wfyYztaWA aajSVsEyPi+2dYsQR0loT53+X+u6gIfgE8fE/Nc3KivbSBcE+j4+P5paJHV5cgqUQgXjuDmjVPI NWZlFd26Y5wCesNeyA7WOTsUcEGScCG160wHgOkFK/p55E9X36bI5e/jrFQ1A4cGTcDwW++jMrp 467j2OdnOIWvJhPs9nG1loKKZ1yaSRaRo/JBU31WlQ6Atl7VrhDDYGxkRGySnfuWvXM9MC51nL5 BOl2VYAGo3jtt3hVYD852R5nNCgyRhhLM0WZ8it6VZM= X-Received: by 2002:a05:6e02:1a86:b0:3ee:cb14:e90f with SMTP id e9e14a558f8ab-3eecb14ea03mr61889105ab.7.1756407176447; Thu, 28 Aug 2025 11:52:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEP6X5C8fKyFwSWmjzqPdfkbd7PprjZnYQm1xQXLb3Ss2KjE+y/MhfTqxlaUhO3jzRNfBiTrg== X-Received: by 2002:a05:6e02:1a86:b0:3ee:cb14:e90f with SMTP id e9e14a558f8ab-3eecb14ea03mr61888495ab.7.1756407175934; Thu, 28 Aug 2025 11:52:55 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50d78c67b4dsm47783173.7.2025.08.28.11.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 11:52:54 -0700 (PDT) Date: Thu, 28 Aug 2025 12:52:51 -0600 From: Alex Williamson To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Brett Creeley , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: Re: [PATCH v1 31/36] vfio/pci: drop nth_page() usage within SG entry Message-ID: <20250828125251.08e4a429.alex.williamson@redhat.com> In-Reply-To: <20250827220141.262669-32-david@redhat.com> References: <20250827220141.262669-1-david@redhat.com> <20250827220141.262669-32-david@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GENyUp7DXhDnBSPZBvs0cT3AKycsH42WtielerDgcSc_1756407177 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_115300_929097_E7402E3D X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, 28 Aug 2025 00:01:35 +0200 David Hildenbrand wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Cc: Brett Creeley > Cc: Jason Gunthorpe > Cc: Yishai Hadas > Cc: Shameer Kolothum > Cc: Kevin Tian > Cc: Alex Williamson > Signed-off-by: David Hildenbrand > --- > drivers/vfio/pci/pds/lm.c | 3 +-- > drivers/vfio/pci/virtio/migrate.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c > index f2673d395236a..4d70c833fa32e 100644 > --- a/drivers/vfio/pci/pds/lm.c > +++ b/drivers/vfio/pci/pds/lm.c > @@ -151,8 +151,7 @@ static struct page *pds_vfio_get_file_page(struct pds_vfio_lm_file *lm_file, > lm_file->last_offset_sg = sg; > lm_file->sg_last_entry += i; > lm_file->last_offset = cur_offset; > - return nth_page(sg_page(sg), > - (offset - cur_offset) / PAGE_SIZE); > + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; > } > cur_offset += sg->length; > } > diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c > index ba92bb4e9af94..7dd0ac866461d 100644 > --- a/drivers/vfio/pci/virtio/migrate.c > +++ b/drivers/vfio/pci/virtio/migrate.c > @@ -53,8 +53,7 @@ virtiovf_get_migration_page(struct virtiovf_data_buffer *buf, > buf->last_offset_sg = sg; > buf->sg_last_entry += i; > buf->last_offset = cur_offset; > - return nth_page(sg_page(sg), > - (offset - cur_offset) / PAGE_SIZE); > + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; > } > cur_offset += sg->length; > } Reviewed-by: Alex Williamson _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv