From: Rob Herring <robh@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Add bindings for SpacemiT K1
Date: Fri, 29 Aug 2025 12:16:24 -0500 [thread overview]
Message-ID: <20250829171624.GA1027608-robh@kernel.org> (raw)
In-Reply-To: <20250828-k1-i2s-v2-1-09e7b40f002c@linux.spacemit.com>
On Thu, Aug 28, 2025 at 11:37:32AM +0800, Troy Mitchell wrote:
> Add dt-binding for the i2s driver of SpacemiT's K1 SoC.
>
> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> ---
> .../devicetree/bindings/sound/spacemit,k1-i2s.yaml | 88 ++++++++++++++++++++++
> 1 file changed, 88 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/spacemit,k1-i2s.yaml b/Documentation/devicetree/bindings/sound/spacemit,k1-i2s.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..042001c38ed8d434889183831e44289ea9c5aef2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/spacemit,k1-i2s.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/spacemit,k1-i2s.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: K1 I2S controller
> +
> +description:
> + The I2S bus (Inter-IC sound bus) is a serial link for digital
> + audio data transfer between devices in the system.
> +
> +maintainers:
> + - Troy Mitchell <troy.mitchell@linux.spacemit.com>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: spacemit,k1-i2s
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: clock for I2S sysclk
> + - description: clock for I2S bclk
> + - description: clock for I2S bus
> + - description: clock for I2S controller
> +
> + clock-names:
> + items:
> + - const: sysclk
> + - const: bclk
> + - const: bus
> + - const: func
> +
> + dmas:
> + minItems: 1
> + maxItems: 2
> +
> + dma-names:
> + oneOf:
> + - const: rx
> + - items:
> + - const: tx
> + - const: rx
If tx is optional, wouldn't this be simpler:
minItems: 1
items:
- const: rx
- const: tx
> +
> + resets:
> + maxItems: 1
> +
> + port:
> + $ref: audio-graph-port.yaml#
> + unevaluatedProperties: false
> +
> + "#sound-dai-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - dmas
> + - dma-names
> + - resets
> + - "#sound-dai-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/spacemit,k1-syscon.h>
> + i2s@d4026000 {
> + compatible = "spacemit,k1-i2s";
> + reg = <0xd4026000 0x30>;
> + clocks = <&syscon_mpmu CLK_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_I2S_BCLK>,
> + <&syscon_apbc CLK_SSPA0_BUS>,
> + <&syscon_apbc CLK_SSPA0>;
> + clock-names = "sysclk", "bclk", "bus", "func";
> + dmas = <&pdma0 21>, <&pdma0 22>;
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_SSPA0>;
> + #sound-dai-cells = <0>;
> + };
>
> --
> 2.50.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-08-29 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 3:37 [PATCH v2 0/2] ASoC: spacemit: add i2s support to K1 SoC Troy Mitchell
2025-08-28 3:37 ` [PATCH v2 1/2] ASoC: dt-bindings: Add bindings for SpacemiT K1 Troy Mitchell
2025-08-29 17:16 ` Rob Herring [this message]
2025-09-02 1:36 ` Troy Mitchell
2025-08-28 3:37 ` [PATCH v2 2/2] ASoC: spacemit: add i2s support for K1 SoC Troy Mitchell
2025-08-28 9:04 ` Mark Brown
2025-09-02 1:39 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829171624.GA1027608-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).