From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Valentina.FernandezAlanis@microchip.com,
Conor.Dooley@microchip.com, Daire.McNamara@microchip.com,
paul.walmsley@sifive.com, palmer@dabbelt.com, robh@kernel.org,
krzk+dt@kernel.org, aou@eecs.berkeley.edu, alex@ghiti.fr,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v1 5/5] riscv: dts: microchip: add a device tree for Discovery Kit
Date: Tue, 2 Sep 2025 09:31:55 +0100 [thread overview]
Message-ID: <20250902-affair-scrambler-2771df16372e@spud> (raw)
In-Reply-To: <0d90eeb4-e6ac-459c-a6b1-26368f102e0e@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]
On Tue, Sep 02, 2025 at 08:22:02AM +0200, Krzysztof Kozlowski wrote:
> >>> + refclk_ccc: cccrefclk {
> >>
> >> Please use name for all fixed clocks which matches current format
> >> recommendation: 'clock-<freq>' (see also the pattern in the binding for
> >> any other options).
> >>
> >> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > The fabric dtsi describes elements configured by the FPGA bitstream.
> > This node is named as such because the Clock Conditioner Circuit CCC's
> > reference clock source is set by the FPGA bitstream, while its frequency
> > is determined by an on-board oscillator.
> >
> > Hope this clarifies the rationale behind the node name.
> No, because there is no style naming clocks like this. Neither proper
> suffix, nor prefix. Use standard naming.
So you want all fixed frequency clocks to be named "clk-foo" when
"clk-<freq>" is not suitable? Fine if you do, but I didn't realise that
it was required and haven't been keeping an eye out for it.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-02 8:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 16:19 [PATCH v1 0/5] Icicle Kit with prod device and Discovery Kit support Valentina Fernandez
2025-08-25 16:19 ` [PATCH v1 1/5] riscv: dts: microchip: add common board dtsi for icicle kit variants Valentina Fernandez
2025-08-25 16:19 ` [PATCH v1 2/5] dt-bindings: riscv: microchip: document icicle kit with production device Valentina Fernandez
2025-08-25 16:19 ` [PATCH v1 3/5] riscv: dts: microchip: add " Valentina Fernandez
2025-08-25 16:19 ` [PATCH v1 4/5] dt-bindings: riscv: microchip: document Discovery Kit Valentina Fernandez
2025-08-25 16:19 ` [PATCH v1 5/5] riscv: dts: microchip: add a device tree for " Valentina Fernandez
2025-08-28 17:46 ` Krzysztof Kozlowski
2025-09-01 15:28 ` Valentina.FernandezAlanis
2025-09-02 6:22 ` Krzysztof Kozlowski
2025-09-02 8:31 ` Conor Dooley [this message]
2025-09-02 13:47 ` Krzysztof Kozlowski
2025-09-02 16:38 ` Conor Dooley
2025-09-02 8:39 ` Valentina.FernandezAlanis
2025-08-28 16:14 ` [PATCH v1 0/5] Icicle Kit with prod device and Discovery Kit support Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902-affair-scrambler-2771df16372e@spud \
--to=conor@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Valentina.FernandezAlanis@microchip.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox