From: Yixun Lan <dlan@gentoo.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Cc: linus.walleij@linaro.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev, linux-gpio@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name
Date: Wed, 3 Sep 2025 18:18:33 +0800 [thread overview]
Message-ID: <20250903101833-GYB1155728@gentoo.org> (raw)
In-Reply-To: <20250903100104.360637-1-hendrik.hamerlinck@hammernet.be>
Hi Hendrik,
On 12:01 Wed 03 Sep , Hendrik Hamerlinck wrote:
> The datasheet lists this signal as PRI_TDI, not PRI_DTI.
> Fix the pin name to match the documentation and JTAG naming
> convention (TDI = Test Data In).
>
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
> drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 9996b1c4a07e..a3f433b611f7 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
> @@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = {
> PINCTRL_PIN(67, "GPIO_67"),
> PINCTRL_PIN(68, "GPIO_68"),
> PINCTRL_PIN(69, "GPIO_69"),
> - PINCTRL_PIN(70, "GPIO_70/PRI_DTI"),
> + PINCTRL_PIN(70, "GPIO_70/PRI_TDI"),
> PINCTRL_PIN(71, "GPIO_71/PRI_TMS"),
> PINCTRL_PIN(72, "GPIO_72/PRI_TCK"),
> PINCTRL_PIN(73, "GPIO_73/PRI_TDO"),
> --
> 2.43.0
>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-09-03 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 10:01 [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name Hendrik Hamerlinck
2025-09-03 10:18 ` Yixun Lan [this message]
2025-09-04 19:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903101833-GYB1155728@gentoo.org \
--to=dlan@gentoo.org \
--cc=hendrik.hamerlinck@hammernet.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox