Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: Yao Zihong <zihong.plct@isrc.iscas.ac.cn>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	 zihongyao@outlook.com, zhangyin2018@iscas.ac.cn,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Subject: Re: [PATCH v1 0/2] riscv: hwprobe: add Zicbop support
Date: Wed, 24 Sep 2025 14:14:32 -0500	[thread overview]
Message-ID: <20250924-b6258c49a33a07d027bdc04b@orel> (raw)
In-Reply-To: <20250911121219.20243-1-zihong.plct@isrc.iscas.ac.cn>

On Thu, Sep 11, 2025 at 08:12:07PM +0800, Yao Zihong wrote:
> Add UAPI and kernel plumbing to expose the Zicbop extension presence
> and its block size through sys_hwprobe(). The interface mirrors
> Zicbom/Zicboz.

Yes, the changes to add Zicbop support should closely resemble those
of Zicbom/Zicboz. So I suggest you grep / git-blame, etc. one or both of
those extensions in order to read how they were done.

With a quick look at this series I can see several changes are missing,
such as

 - an update to the documentation, Documentation/arch/riscv/hwprobe.rst
 - a bump to RISCV_HWPROBE_MAX_KEY (as the comment below the change
   this patch makes says to do)
 - test(s) added to tools/testing/selftests/riscv/hwprobe/cbo.c

Thanks,
drew

> This allows userspace to safely discover and optimize
> for Zicbop when available.
> 
> Yao Zihong (2):
>   uapi: riscv: hwprobe: add Zicbop extension bit and block-size key
>   riscv: hwprobe: report Zicbop presence and block size
> 
>  arch/riscv/include/uapi/asm/hwprobe.h | 2 ++
>  arch/riscv/kernel/sys_hwprobe.c       | 6 ++++++
>  2 files changed, 8 insertions(+)
> 
> -- 
> 2.47.2
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      parent reply	other threads:[~2025-09-24 19:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 12:12 [PATCH v1 0/2] riscv: hwprobe: add Zicbop support Yao Zihong
2025-09-11 12:12 ` [PATCH v1 1/2] uapi: riscv: hwprobe: add Zicbop extension bit and block-size key Yao Zihong
2025-09-11 12:12 ` [PATCH v1 2/2] riscv: hwprobe: report Zicbop presence and block size Yao Zihong
2025-09-22 13:53 ` [PATCH v1 0/2] riscv: hwprobe: add Zicbop support Yao Zihong
2025-09-24 19:14 ` Andrew Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924-b6258c49a33a07d027bdc04b@orel \
    --to=ajones@ventanamicro.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=zhangyin2018@iscas.ac.cn \
    --cc=zihong.plct@isrc.iscas.ac.cn \
    --cc=zihongyao@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox