From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 083E6CAC5BD for ; Sun, 28 Sep 2025 00:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=edub2aP7vDWhwUNJF/vVD5uVZlUyP5mP7sur/RYBWw4=; b=TJSHrHN4Z6iqhA bKHHba1LaBBS0FEpWJVBy/sTpRWZZBhwpKs9URDjr2ihlVT+fIq6RtoTvbLp2VfrOlJBOS3TMNVdk QinBgk8Tb1SWrDjz2v2HEh8DYmHVCGr0iHBVY2fuLx1bUyVAbjwUAtESFGpUBpz1HXds/enEBs+M/ BNMLw58V8kYcSvjLj8RZdyvuuHmqVMeJYV3ETRfSWM/D0hIvTe/Iaw/VZJFJeoOLcQxhyNYpUq9FR 5TS8sjlY6Mj/qVN13tnqsqfdEahABTT/t/zIxWmToZtnpc5ooZTAQHsdAffrnR9T3D0LkYRKRE8oy n4xKkXLPHtoRv492AgEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v2esb-0000000DBq9-3szs; Sun, 28 Sep 2025 00:03:05 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v2esZ-0000000DBpj-35be for linux-riscv@lists.infradead.org; Sun, 28 Sep 2025 00:03:05 +0000 Received: from localhost (unknown [180.158.240.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 7DF62340B28; Sun, 28 Sep 2025 00:02:59 +0000 (UTC) Date: Sun, 28 Sep 2025 08:02:55 +0800 From: Yixun Lan To: Aurelien Jarno Cc: linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH 1/2] driver: reset: spacemit-p1: add driver for poweroff/reboot Message-ID: <20250928000255-GYA1342640@gentoo.org> References: <20250927220824.1267318-1-aurelien@aurel32.net> <20250927220824.1267318-2-aurelien@aurel32.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250927220824.1267318-2-aurelien@aurel32.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250927_170303_811712_F2DE6C0F X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Aurelien, On 00:07 Sun 28 Sep , Aurelien Jarno wrote: > This driver implements poweroff/reboot support for the SpacemiT P1 PMIC > chip, which is commonly paired with the SpacemiT K1 SoC. > > The SpacemiT P1 support is implemented as a MFD driver, so the access is > done directly through the regmap interface. Reboot or poweroff is > triggered by setting a specific bit in a control register, which is > automatically cleared by the hardware afterwards. > > Signed-off-by: Aurelien Jarno > --- > drivers/power/reset/Kconfig | 9 +++ > drivers/power/reset/Makefile | 1 + > drivers/power/reset/spacemit-p1-reboot.c | 88 ++++++++++++++++++++++++ > 3 files changed, 98 insertions(+) > create mode 100644 drivers/power/reset/spacemit-p1-reboot.c > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 77ea3129c7080..5afef049760d6 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig [snip].. > + > +static int spacemit_p1_reboot_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct regmap *regmap; > + int ret; > + > + regmap = dev_get_regmap(dev->parent, NULL); > + if (!regmap) > + return -ENODEV; > + > + ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler, regmap); > + if (ret) { > + dev_err(dev, "Failed to register power off handler: %d\n", ret); > + return ret; suggest to simplify with dev_err_probe(), which will save few lines > + } > + > + ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler, regmap); > + if (ret) { > + dev_err(dev, "Failed to register restart handler: %d\n", ret); > + return ret; ditto > + } > + > + return 0; > +} > + > +static const struct platform_device_id spacemit_p1_reboot_id_table[] = { > + { "spacemit-p1-reboot", }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(platform, spacemit_p1_reboot_id_table); > + > +static struct platform_driver spacemit_p1_reboot_driver = { > + .driver = { > + .name = "spacemit-p1-reboot", > + }, > + .probe = spacemit_p1_reboot_probe, > + .id_table = spacemit_p1_reboot_id_table, > +}; > +module_platform_driver(spacemit_p1_reboot_driver); > + > +MODULE_DESCRIPTION("SpacemiT P1 reboot/poweroff driver"); > +MODULE_LICENSE("GPL"); > -- > 2.47.2 > -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv