From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Randolph Lin <randolph@andestech.com>,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, jingoohan1@gmail.com,
mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org,
robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org,
conor+dt@kernel.org, alex@ghiti.fr, aou@eecs.berkeley.edu,
palmer@dabbelt.com, paul.walmsley@sifive.com,
ben717@andestech.com, inochiama@gmail.com,
thippeswamy.havalige@amd.com, namcao@linutronix.de,
shradha.t@samsung.com, pjw@kernel.org, randolph.sklin@gmail.com,
tim609@andestech.com, Randolph Lin <randolph@andestech.com>
Subject: Re: [PATCH v6 4/5] PCI: andes: Add Andes QiLai SoC PCIe host driver support
Date: Tue, 14 Oct 2025 10:33:51 +0300 [thread overview]
Message-ID: <202510092111.fZmvx6jO-lkp@intel.com> (raw)
In-Reply-To: <20251003023527.3284787-5-randolph@andestech.com>
Hi Randolph,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Randolph-Lin/PCI-dwc-Allow-adjusting-the-number-of-ob-ib-windows-in-glue-driver/20251003-104100
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20251003023527.3284787-5-randolph%40andestech.com
patch subject: [PATCH v6 4/5] PCI: andes: Add Andes QiLai SoC PCIe host driver support
config: powerpc-randconfig-r071-20251009 (https://download.01.org/0day-ci/archive/20251009/202510092111.fZmvx6jO-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 39f292ffa13d7ca0d1edff27ac8fd55024bb4d19)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202510092111.fZmvx6jO-lkp@intel.com/
smatch warnings:
drivers/pci/controller/dwc/pcie-andes-qilai.c:157 qilai_pcie_host_fix_ob_iatu_count() error: uninitialized symbol 'ranges_32bits'.
vim +/ranges_32bits +157 drivers/pci/controller/dwc/pcie-andes-qilai.c
816cad1ac60166 Randolph Lin 2025-10-03 133 static int qilai_pcie_host_fix_ob_iatu_count(struct dw_pcie_rp *pp)
816cad1ac60166 Randolph Lin 2025-10-03 134 {
816cad1ac60166 Randolph Lin 2025-10-03 135 struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
816cad1ac60166 Randolph Lin 2025-10-03 136 struct device *dev = pci->dev;
816cad1ac60166 Randolph Lin 2025-10-03 137 struct resource_entry *entry;
816cad1ac60166 Randolph Lin 2025-10-03 138 /* Reserved 1 ob iATU for config space */
816cad1ac60166 Randolph Lin 2025-10-03 139 int count = 1;
816cad1ac60166 Randolph Lin 2025-10-03 140 int ranges_32bits;
This should be bool and initialized to false.
816cad1ac60166 Randolph Lin 2025-10-03 141 u64 pci_addr;
816cad1ac60166 Randolph Lin 2025-10-03 142 u64 size;
816cad1ac60166 Randolph Lin 2025-10-03 143
816cad1ac60166 Randolph Lin 2025-10-03 144 resource_list_for_each_entry(entry, &pp->bridge->windows) {
816cad1ac60166 Randolph Lin 2025-10-03 145 if (resource_type(entry->res) != IORESOURCE_MEM)
816cad1ac60166 Randolph Lin 2025-10-03 146 continue;
816cad1ac60166 Randolph Lin 2025-10-03 147
816cad1ac60166 Randolph Lin 2025-10-03 148 size = resource_size(entry->res);
816cad1ac60166 Randolph Lin 2025-10-03 149 if (size < SZ_4G)
816cad1ac60166 Randolph Lin 2025-10-03 150 count++;
816cad1ac60166 Randolph Lin 2025-10-03 151
816cad1ac60166 Randolph Lin 2025-10-03 152 pci_addr = entry->res->start - entry->offset;
816cad1ac60166 Randolph Lin 2025-10-03 153 if (pci_addr < SZ_4G)
816cad1ac60166 Randolph Lin 2025-10-03 154 ranges_32bits = true;
816cad1ac60166 Randolph Lin 2025-10-03 155 }
816cad1ac60166 Randolph Lin 2025-10-03 156
816cad1ac60166 Randolph Lin 2025-10-03 @157 if (!ranges_32bits) {
816cad1ac60166 Randolph Lin 2025-10-03 158 dev_err(dev, "Bridge window must contain 32-bits address\n");
816cad1ac60166 Randolph Lin 2025-10-03 159 return -EINVAL;
816cad1ac60166 Randolph Lin 2025-10-03 160 }
816cad1ac60166 Randolph Lin 2025-10-03 161
816cad1ac60166 Randolph Lin 2025-10-03 162 pci->num_ob_windows = count;
816cad1ac60166 Randolph Lin 2025-10-03 163
816cad1ac60166 Randolph Lin 2025-10-03 164 return 0;
816cad1ac60166 Randolph Lin 2025-10-03 165 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-10-14 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 2:35 [PATCH v6 0/5] Add support for Andes Qilai SoC PCIe controller Randolph Lin
2025-10-03 2:35 ` [PATCH v6 1/5] PCI: dwc: Allow adjusting the number of ob/ib windows in glue driver Randolph Lin
2025-10-14 9:43 ` Niklas Cassel
2025-10-16 11:12 ` Randolph Lin
2025-10-16 11:54 ` Niklas Cassel
2025-10-20 11:35 ` Randolph Lin
2025-10-03 2:35 ` [PATCH v6 2/5] dt-bindings: PCI: Add Andes QiLai PCIe support Randolph Lin
2025-10-06 18:52 ` Rob Herring
2025-10-03 2:35 ` [PATCH v6 3/5] riscv: dts: andes: Add PCIe node into the QiLai SoC Randolph Lin
2025-10-03 2:35 ` [PATCH v6 4/5] PCI: andes: Add Andes QiLai SoC PCIe host driver support Randolph Lin
2025-10-14 7:33 ` Dan Carpenter [this message]
2025-10-03 2:35 ` [PATCH v6 5/5] MAINTAINERS: Add maintainers for Andes QiLai PCIe driver Randolph Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510092111.fZmvx6jO-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=ben717@andestech.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=namcao@linutronix.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pjw@kernel.org \
--cc=randolph.sklin@gmail.com \
--cc=randolph@andestech.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
--cc=thippeswamy.havalige@amd.com \
--cc=tim609@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox