Re: [PATCH v6 1/7] reset: mpfs: add non-auxiliary bus probing

From: Conor Dooley <conor@kernel.org>
To: claudiu beznea <claudiu.beznea@tuxon.dev>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Daire McNamara <daire.mcnamara@microchip.com>,
	pierre-henry.moussay@microchip.com,
	valentina.fernandezalanis@microchip.com,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/7] reset: mpfs: add non-auxiliary bus probing
Date: Fri, 31 Oct 2025 10:58:29 +0000	[thread overview]
Message-ID: <20251031-mosaic-trimness-d683527a6866@spud> (raw)
In-Reply-To: <a996e76e-8201-4b72-b4fa-0ea9ac62e6b1@tuxon.dev>

[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]

On Fri, Oct 31, 2025 at 09:20:17AM +0200, claudiu beznea wrote:
> On 10/29/25 18:11, Conor Dooley wrote:
> > -static int mpfs_reset_probe(struct auxiliary_device *adev,
> > -			    const struct auxiliary_device_id *id)
> > +static int mpfs_reset_mfd_probe(struct platform_device *pdev)
> >   {
> > -	struct device *dev = &adev->dev;
> >   	struct reset_controller_dev *rcdev;
> > +	struct device *dev = &pdev->dev;
> > +	struct mpfs_reset *rst;
> > +
> > +	rst = devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL);
> > +	if (!rst)
> > +		return -ENOMEM;
> > +
> > +	rcdev = &rst->rcdev;
> > +	rcdev->dev = dev;
> > +	rcdev->ops = &mpfs_reset_ops;
> > +
> > +	rcdev->of_node = pdev->dev.parent->of_node;
> > +	rcdev->of_reset_n_cells = 1;
> > +	rcdev->of_xlate = mpfs_reset_xlate;
> > +	rcdev->nr_resets = MPFS_NUM_RESETS;
> > +
> > +	rst->regmap = device_node_to_regmap(pdev->dev.parent->of_node);
> > +	if (IS_ERR(rst->regmap))
> > +		dev_err_probe(dev, PTR_ERR(rst->regmap), "Failed to find syscon regmap\n");
> 
> Do you want to continue registering the reset controller here? rcdev->base
> is NULL, thus the reset controller ops will fail, if I'm not wrong.

Oh, good point. That line is missing a return.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv