* [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups
@ 2025-11-11 11:18 Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 1/2] mfd: simple-mfd-i2c: Make ID table style consistent Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2025-11-11 11:18 UTC (permalink / raw)
To: Lee Jones, linux-kernel, linux-riscv, spacemit; +Cc: Yixun Lan, Andy Shevchenko
Here is just a couple of ad-hoc cleanups. No behaviour changes.
Andy Shevchenko (2):
mfd: simple-mfd-i2c: Make ID table style consistent
mfd: simple-mfd-i2c: don't use "proxy" headers
drivers/mfd/simple-mfd-i2c.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
--
2.50.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/2] mfd: simple-mfd-i2c: Make ID table style consistent
2025-11-11 11:18 [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Andy Shevchenko
@ 2025-11-11 11:18 ` Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 2/2] mfd: simple-mfd-i2c: don't use "proxy" headers Andy Shevchenko
2025-11-19 16:17 ` [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2025-11-11 11:18 UTC (permalink / raw)
To: Lee Jones, linux-kernel, linux-riscv, spacemit; +Cc: Yixun Lan, Andy Shevchenko
The lines in the OF ID table are written in three different styles.
Choose the most common in the kernel and update accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/simple-mfd-i2c.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index 0a607a1e3ca1..5fd0ef3fa44a 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -114,11 +114,11 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
{ .compatible = "fsl,lx2160aqds-fpga" },
{ .compatible = "fsl,lx2160ardb-fpga" },
{ .compatible = "kontron,sl28cpld" },
- { .compatible = "maxim,max5970", .data = &maxim_max5970},
- { .compatible = "maxim,max5978", .data = &maxim_max5970},
- { .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
- { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
- { .compatible = "spacemit,p1", .data = &spacemit_p1, },
+ { .compatible = "maxim,max5970", .data = &maxim_max5970 },
+ { .compatible = "maxim,max5978", .data = &maxim_max5970 },
+ { .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705 },
+ { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a },
+ { .compatible = "spacemit,p1", .data = &spacemit_p1 },
{}
};
MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
--
2.50.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] mfd: simple-mfd-i2c: don't use "proxy" headers
2025-11-11 11:18 [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 1/2] mfd: simple-mfd-i2c: Make ID table style consistent Andy Shevchenko
@ 2025-11-11 11:18 ` Andy Shevchenko
2025-11-19 16:17 ` [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2025-11-11 11:18 UTC (permalink / raw)
To: Lee Jones, linux-kernel, linux-riscv, spacemit; +Cc: Yixun Lan, Andy Shevchenko
Update header inclusions to follow IWYU (Include What You Use) principle.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/simple-mfd-i2c.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index 5fd0ef3fa44a..8b751d8e3b5a 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -15,12 +15,18 @@
* will be subsequently registered.
*/
+#include <linux/array_size.h>
+#include <linux/dev_printk.h>
+#include <linux/err.h>
#include <linux/i2c.h>
-#include <linux/kernel.h>
#include <linux/mfd/core.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/regmap.h>
+#include <linux/stddef.h>
#include "simple-mfd-i2c.h"
--
2.50.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups
2025-11-11 11:18 [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 1/2] mfd: simple-mfd-i2c: Make ID table style consistent Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 2/2] mfd: simple-mfd-i2c: don't use "proxy" headers Andy Shevchenko
@ 2025-11-19 16:17 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2025-11-19 16:17 UTC (permalink / raw)
To: Lee Jones, linux-kernel, linux-riscv, spacemit, Andy Shevchenko; +Cc: Yixun Lan
On Tue, 11 Nov 2025 12:18:34 +0100, Andy Shevchenko wrote:
> Here is just a couple of ad-hoc cleanups. No behaviour changes.
>
> Andy Shevchenko (2):
> mfd: simple-mfd-i2c: Make ID table style consistent
> mfd: simple-mfd-i2c: don't use "proxy" headers
>
> drivers/mfd/simple-mfd-i2c.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> [...]
Applied, thanks!
[1/2] mfd: simple-mfd-i2c: Make ID table style consistent
commit: 81d2cc9272df8c01e36a963dd8b23ca585b68032
[2/2] mfd: simple-mfd-i2c: don't use "proxy" headers
commit: 46bddb5fbe7e3cb73204a952dbd4687cf0974ef5
--
Lee Jones [李琼斯]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-19 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 11:18 [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 1/2] mfd: simple-mfd-i2c: Make ID table style consistent Andy Shevchenko
2025-11-11 11:18 ` [PATCH v1 2/2] mfd: simple-mfd-i2c: don't use "proxy" headers Andy Shevchenko
2025-11-19 16:17 ` [PATCH v1 0/2] mfd: simple-mfd-i2c: a couple of cleanups Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).