Re: [PATCH] clk: spacemit: Fix module build for spacemit common ccu driver

From: Yixun Lan <dlan@gentoo.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Inochi Amaoto <inochiama@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Haylen Chu <heylenay@4d2.org>,
	Brian Masney <bmasney@redhat.com>,
	Alex Elder <elder@riscstar.com>,
	Akhilesh Patil <akhilesh@ee.iitb.ac.in>,
	linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
	Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH] clk: spacemit: Fix module build for spacemit common ccu driver
Date: Tue, 16 Dec 2025 06:18:53 +0800	[thread overview]
Message-ID: <20251215221853-GYB1903981@gentoo.org> (raw)
In-Reply-To: <EE6920993009E270+aT94cmKTM0tHn8Ly@kernel.org>

Hi Troy,

On 10:54 Mon 15 Dec     , Troy Mitchell wrote:
> On Mon, Dec 15, 2025 at 07:29:37AM +0800, Inochi Amaoto wrote:
> > For build spacemit common clock driver as a module, the build
> > process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally
> > and EXPORT_SYMBOL() for every exposed symbol. Otherwise, the
> > build will fail.
> > 
> > Add these missing hints, so the driver can be built as a module.
> > 
> > Fixes: 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC")
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Thanks.
> 
> Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>

I think it's more proper to use reviewed-by here, for acked-by, it's
up to subsystem maintainer or original patch author for signifying
explict agreement or acceptance of patch inclusion..

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv