From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7A07D5C0EA for ; Tue, 16 Dec 2025 14:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/OnRoZSpWE8wHG9khucHWlBq+AQJMU3A3HikZyuyOA4=; b=yK9rnB/HenufsC wEoT0J0LorJu6ehO/P5r34MDOzd453myj/A/K52Prw2ptMSBAP9qTfRPgd/r1ZdfMFfjoV+S7N9tA HypnwxzmrKgVvlYqpbCx40ddlAyLznFFm//IR/hCERJJLsfKrz8ZVexyX9KgdKLvE9zyxgRk1CjmM cD/h7CitiO0fOyEFaAjJ0KdvTVdNYKLIanfX56QnmCozWEIi0DXv1zzQICXyO2KwYMDlQHKCxghW2 Mypc29dEwiF2A5/Yvwiyz34QUM0QKuZ5DhFFJAyl/O59k0p5vHsXoYIne59SAz0a8fJErEM+p2WTt Jy5CGbflFtl/6t+BwaIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVWME-00000005O43-0akF; Tue, 16 Dec 2025 14:48:58 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vVWMA-00000005O2L-3m8y for linux-riscv@lists.infradead.org; Tue, 16 Dec 2025 14:48:56 +0000 Received: from localhost (unknown [116.232.18.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 5DCAD340E96; Tue, 16 Dec 2025 14:48:51 +0000 (UTC) Date: Tue, 16 Dec 2025 22:48:45 +0800 From: Yixun Lan To: Inochi Amaoto Cc: Michael Turquette , Stephen Boyd , Haylen Chu , Brian Masney , Troy Mitchell , Alex Elder , Akhilesh Patil , linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Longbin Li Subject: Re: [PATCH] clk: spacemit: Fix module build for spacemit common ccu driver Message-ID: <20251216144845-GYC1903981@gentoo.org> References: <20251214232938.668293-1-inochiama@gmail.com> <20251215221202-GYA1903981@gentoo.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251215221202-GYA1903981@gentoo.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251216_064855_019967_39D51B67 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi On 06:12 Tue 16 Dec , Yixun Lan wrote: > Hi Inochi, > > On 07:29 Mon 15 Dec , Inochi Amaoto wrote: > > For build spacemit common clock driver as a module, the build > > process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally > > and EXPORT_SYMBOL() for every exposed symbol. Otherwise, the > > build will fail. > > > > Add these missing hints, so the driver can be built as a module. > > > > Fixes: 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC") > > Signed-off-by: Inochi Amaoto > looks good, thanks > > Reviewed-by: Yixun Lan > On my second thought, since all functions only used in spacemit clock driver, how about using symbol namespaces? please refer the doc https://www.kernel.org/doc/Documentation/kbuild/namespaces.rst or check drivers/clk/meson/ for example.. -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv