Re: [PATCH v5 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86

From: Xie Yuanbin <qq570070308@gmail.com>
To: tglx@linutronix.de
Cc: acme@kernel.org, adrian.hunter@intel.com, agordeev@linux.ibm.com,
	akpm@linux-foundation.org, alex@ghiti.fr,
	alexander.shishkin@linux.intel.com, andreas@gaisler.com,
	anshuman.khandual@arm.com, aou@eecs.berkeley.edu, arnd@arndb.de,
	borntraeger@linux.ibm.com, bp@alien8.de, bsegall@google.com,
	dave.hansen@linux.intel.com, davem@davemloft.net,
	david@kernel.org, dietmar.eggemann@arm.com, frederic@kernel.org,
	gor@linux.ibm.com, hca@linux.ibm.com, hpa@zytor.com,
	irogers@google.com, james.clark@linaro.org, jolsa@kernel.org,
	juri.lelli@redhat.com, justinstitt@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux@armlinux.org.uk, llvm@lists.linux.dev,
	lorenzo.stoakes@oracle.com, luto@kernel.org,
	mark.rutland@arm.com, mathieu.desnoyers@efficios.com,
	max.kellermann@ionos.com, mgorman@suse.de, mingo@redhat.com,
	morbo@google.com, namhyung@kernel.org, nathan@kernel.org,
	nick.desaulniers+lkml@gmail.com, nysal@linux.ibm.com,
	palmer@dabbelt.com, paulmck@kernel.org, peterz@infradead.org,
	pjw@kernel.org, qq570070308@gmail.com, riel@surriel.com,
	rostedt@goodmis.org, ryan.roberts@arm.com,
	segher@kernel.crashing.org, sparclinux@vger.kernel.org,
	svens@linux.ibm.com, thuth@redhat.com, urezki@gmail.com,
	vincent.guittot@linaro.org, vschneid@redhat.com, x86@kernel.org
Subject: Re: [PATCH v5 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86
Date: Tue, 16 Dec 2025 23:49:51 +0800	[thread overview]
Message-ID: <20251216154951.631-1-qq570070308@gmail.com> (raw)
In-Reply-To: <87345beoq2.ffs@tglx>

On Mon, 15 Dec 2025 16:42:13 +0100, Thomas Gleixner wrote:
> These Reported-by and Closes tags are just wrong. This is a new patch
> and the robot reported failures against earlier versions. The robot
> report is very clear about that:
>
>   "If you fix the issue in a separate patch/commit (i.e. not just a new version of
>    the same patch/commit), kindly add following tags
>      Reported-by:...
>      Closes:..."
>
> No?
>
> [...]
>
> Please move the '#define enter_....' under the inline function. That's
> way simpler to read.

Thanks for replying, I will improve it in the V6 patch.

>> +/*
>> + * Please ignore the name of this function.  It should be called
>> + * switch_to_kernel_thread().
>
> And why is it not renamed then?
>
>> + *
>> + * enter_lazy_tlb() is a hint from the scheduler that we are entering a
>
> We enter a kernel thread? AFAIK the metaverse has been canceled.
>
>> + * kernel thread or other context without an mm.  Acceptable implementations
>> + * include doing nothing whatsoever, switching to init_mm, or various clever
>> + * lazy tricks to try to minimize TLB flushes.
>> + *
>> + * The scheduler reserves the right to call enter_lazy_tlb() several times
>> + * in a row.  It will notify us that we're going back to a real mm by
>
> It will notify us by sending email or what?

I didn't write any comments, I just moved its location.

As for the content of the comment, I think it has nothing to do with this
patch. If the content of the comment needs to be modified, it should be
modified in another patch?

Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv