From: Yixun Lan <dlan@gentoo.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Haylen Chu <heylenay@4d2.org>,
Alex Elder <elder@riscstar.com>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Charles Mirabile <cmirabil@redhat.com>,
Brian Masney <bmasney@redhat.com>,
Akhilesh Patil <akhilesh@ee.iitb.ac.in>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH v4 0/2] clk: spacemit: Fix module build for spacemit common ccu driver
Date: Fri, 19 Dec 2025 17:53:19 +0800 [thread overview]
Message-ID: <20251219095319-GYA1955339@gentoo.org> (raw)
In-Reply-To: <20251219012819.440972-1-inochiama@gmail.com>
Hi Inochi,
On 09:28 Fri 19 Dec , Inochi Amaoto wrote:
> Currently, the SPACEMIT_CCU entry is only a switch for enabling entry
> SPACEMIT_K1_CCU. It does not guide the build for common clock codes
> even if it is a tristate entry. This makes this entry useless.
>
> Change the Makefile to add a separate build for common clock logic,
> so the SPACEMIT_CCU entry takes effect, also add necessary
> MODULE_LICENSE()/MODULE_DESCRIPTION()/EXPORT_SYMBOL() for the module
> build.
>
> This patch mostly fix the build problem, and it should serve as a
> basic for the incoming K3 clock driver. See link.
>
> Link: https://lore.kernel.org/all/20251217001833-GYE1903981@gentoo.org
>
this series looks good to me, so
Reviewed-by: Yixun Lan <dlan@gentoo.org>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-12-19 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 1:28 [PATCH v4 0/2] clk: spacemit: Fix module build for spacemit common ccu driver Inochi Amaoto
2025-12-19 1:28 ` [PATCH v4 1/2] clk: spacemit: Respect Kconfig setting when building modules Inochi Amaoto
2025-12-19 1:28 ` [PATCH v4 2/2] clk: spacemit: Hide common clock driver from user controller Inochi Amaoto
2025-12-19 9:53 ` Yixun Lan [this message]
2025-12-25 2:22 ` [PATCH v4 0/2] clk: spacemit: Fix module build for spacemit common ccu driver Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251219095319-GYA1955339@gentoo.org \
--to=dlan@gentoo.org \
--cc=akhilesh@ee.iitb.ac.in \
--cc=bmasney@redhat.com \
--cc=cmirabil@redhat.com \
--cc=elder@riscstar.com \
--cc=heylenay@4d2.org \
--cc=inochiama@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox