From: Yixun Lan <dlan@gentoo.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Haylen Chu <heylenay@4d2.org>,
Guodong Xu <guodong@riscstar.com>,
Inochi Amaoto <inochiama@gmail.com>, Yao Zi <me@ziyao.cc>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: soc: spacemit: k3: add clock support
Date: Mon, 5 Jan 2026 15:55:10 +0800 [thread overview]
Message-ID: <20260105075510-GYA2078702@gentoo.org> (raw)
In-Reply-To: <20260105-copper-warthog-of-mathematics-883f7c@quoll>
Hi Krzysztof,
On 08:48 Mon 05 Jan , Krzysztof Kozlowski wrote:
> On Sat, Jan 03, 2026 at 03:44:16PM +0800, Yixun Lan wrote:
> > Add compatible strings for clock drivers to support Spacemit K3 SoC,
> > also includes all the defined clock IDs.
> >
> > The SpacemiT K3 SoC clock IP is scattered over several different blocks,
> > which are APBC, APBS, APMU, DCIU, MPMU, all of them are capable of
> > generating clock and reset signals. APMU and MPMU have additional Power
> > Domain management functionality.
> >
> > Following is a brief list that shows devices managed in each block:
> >
> > APBC: UART, GPIO, PWM, SPI, TIMER, I2S, IR, DR, TSEN, IPC, CAN
> > APBS: various PPL clocks control
> > APMU: CCI, CPU, CSI, ISP, LCD, USB, QSPI, DMA, VPU, GPU, DSI, PCIe, EMAC..
> > DCID: SRAM, DMA, TCM
> > MPMU: various PLL1 derived clocks, UART, WATCHDOG, I2S
> >
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> > ---
..
> > @@ -28,7 +30,7 @@ properties:
> > "#clock-cells":
> > const: 1
> > description:
> > - See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> > + See corresponding file under <dt-bindings/clock/> for valid indices.
>
> List two paths, better. Generic path to clock directory is obvious and
> not helping.
>
ok, will do
> > @@ -39,7 +43,7 @@ properties:
> > "#clock-cells":
> > const: 1
> > description:
> > - See <dt-bindings/clock/spacemit,k1-syscon.h> for valid indices.
> > + See corresponding file under <dt-bindings/clock/> for valid indices.
>
> Same problem here.
>
ditto
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
thanks, I will wait few days for incoming reviews, then update
> Best regards,
> Krzysztof
>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-01-05 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 7:44 [PATCH v4 0/5] Add clock support for SpacemiT K3 SoC Yixun Lan
2026-01-03 7:44 ` [PATCH v4 1/5] dt-bindings: soc: spacemit: k3: add clock support Yixun Lan
2026-01-05 7:48 ` Krzysztof Kozlowski
2026-01-05 7:55 ` Yixun Lan [this message]
2026-01-03 7:44 ` [PATCH v4 2/5] clk: spacemit: ccu_mix: add inverted enable gate clock Yixun Lan
2026-01-03 7:44 ` [PATCH v4 3/5] clk: spacemit: ccu_pll: add plla type clock Yixun Lan
2026-01-03 7:44 ` [PATCH v4 4/5] clk: spacemit: k3: extract common header Yixun Lan
2026-01-03 7:44 ` [PATCH v4 5/5] clk: spacemit: k3: add the clock tree Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105075510-GYA2078702@gentoo.org \
--to=dlan@gentoo.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guodong@riscstar.com \
--cc=heylenay@4d2.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=me@ziyao.cc \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox