From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE3A7C79F9D for ; Mon, 5 Jan 2026 15:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NUeamwJQ2JS+fT+O37+lsZ+lFxcXlJYAI2hkuxOhDGs=; b=Y2JkZKVJc/9u3h HwijPmVumfynENrS+e1+mubYzKM3RRc8hOcaTajH9on0m0ZhoP5E/xWG8oQi6TCdCmLQIzT4u5m42 z4nQbWTpzokS1vprE9UMfOvLqY4R3Xld7HDUb37/Fa9GIA1Fpx2WuodEDpYFV3ZghpJQauynGTkdy BA9ysXe6GH0jJfDw71Uoh6YBJ3dYNpvkFaBX6lgYiuS0VA8N6zgN+SWOLNvxrYSy9D0OReFutRftf 1DBGEvPHu9eXfH9TsUVSv/zLDeQvFMuAIMtRrCKj5wml76R7j/A4PE31oS7VU28fO/uoShhxun2fr YeG0iUupjnh1+6a6h29Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcmnM-0000000BdDx-3tsg; Mon, 05 Jan 2026 15:47:00 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcmnL-0000000BdDO-0vxQ for linux-riscv@lists.infradead.org; Mon, 05 Jan 2026 15:46:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0287260010; Mon, 5 Jan 2026 15:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73A02C19422; Mon, 5 Jan 2026 15:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767628017; bh=6g43xgupT7X9snTe66W9SSmrOVZbRjTg76SexCt4z9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Si87D+/ouqiUp/V/VfYSNsvLz+wcGQXYrs1TH00tsHqVG41Nh0GT6/LQ3O2ztTuBt i8MTyZcXjm49WCnxVXo6bBF3LB6QsN5aNgUHtoAwUTaDJGwUtzWBKMhdvRbxyphTk4 6BIAPBrXP4Nar22gXW4uNsnvhvyqnq84iD0AAKtCNbd50Y4rCkV5ogB2/z9W97SaQe 2bQud1buFeK5ek2nKMpY0P8eNWsq1jKXNHMe9WikiDRqkFM/dDvpWeQu90O7q6h760 3BjyyRtQc8O5ohyTiC2IgHoMRUExf/DznPKiB/qtiCFd+u2ftX/em7Dye1zSfY2rmZ GYNZf+LFvw0Kw== Date: Mon, 5 Jan 2026 09:46:56 -0600 From: Rob Herring To: Icenowy Zheng Subject: Re: [PATCH v4 2/9] dt-bindings: display: add verisilicon,dc Message-ID: <20260105154656.GA2585570-robh@kernel.org> References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> <20251224161205.1132149-3-zhengxingda@iscas.ac.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251224161205.1132149-3-zhengxingda@iscas.ac.cn> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Drew Fustini , Heiko Stuebner , dri-devel@lists.freedesktop.org, Guo Ren , Laurent Pinchart , Andrzej Hajda , linux-riscv@lists.infradead.org, David Airlie , Yao Zi , Simona Vetter , Robert Foss , Jernej Skrabec , Michal Wilczynski , devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , Jonas Karlman , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , linux-kernel@vger.kernel.org, Philipp Zabel , Han Gao , Krzysztof Kozlowski , Fu Wei Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Dec 25, 2025 at 12:11:58AM +0800, Icenowy Zheng wrote: > From: Icenowy Zheng > > Verisilicon has a series of display controllers prefixed with DC and > with self-identification facility like their GC series GPUs. > > Add a device tree binding for it. > > Depends on the specific DC model, it can have either one or two display > outputs, and each display output could be set to DPI signal or "DP" > signal (which seems to be some plain parallel bus to HDMI controllers). > > Signed-off-by: Icenowy Zheng > Signed-off-by: Icenowy Zheng > --- > Changes in v4: > - Added a comment for "verisilicon,dc" that says the ID/revision is > discoverable via registers. > - Removed clock minItems constraint w/o specific compatible strings. > > Changes in v3: > - Added SoC-specific compatible string, and arm the binding with clock / > port checking for the specific SoC (with a 2-output DC). > > Changes in v2: > - Fixed misspelt "versilicon" in title. > - Moved minItems in clock properties to be earlier than items. > - Re-aligned multi-line clocks and resets in example. > > .../bindings/display/verisilicon,dc.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/verisilicon,dc.yaml > > diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > new file mode 100644 > index 0000000000000..fe64cc1466690 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/verisilicon,dc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Verisilicon DC-series display controllers > + > +maintainers: > + - Icenowy Zheng > + > +properties: > + $nodename: > + pattern: "^display@[0-9a-f]+$" > + > + compatible: > + items: > + - enum: > + - thead,th1520-dc8200 > + - const: verisilicon,dc # DC IPs have discoverable ID/revision registers > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: DC Core clock > + - description: DMA AXI bus clock > + - description: Configuration AHB bus clock > + - description: Pixel clock of output 0 > + - description: Pixel clock of output 1 > + > + clock-names: > + items: > + - const: core > + - const: axi > + - const: ahb > + - const: pix0 > + - const: pix1 > + > + resets: > + items: > + - description: DC Core reset > + - description: DMA AXI bus reset > + - description: Configuration AHB bus reset > + > + reset-names: > + items: > + - const: core > + - const: axi > + - const: ahb > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: The first output channel , endpoint 0 should be No space before comma. Or perhaps should be a period instead. > + used for DPI format output and endpoint 1 should be used > + for DP format output. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: The second output channel if the DC variant > + supports. Follow the same endpoint addressing rule with > + the first port. > + > + required: > + - port@0 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: thead,th1520-dc8200 > + then: > + properties: > + clocks: > + minItems: 5 That's already implicitly the min. Perhaps you wanted 'minItems: 4' on the clocks and clock-names definitions for versions with only 1 output? > + ports: > + required: > + - port@0 > + - port@1 It is valid to omit these if the output is present, but unused. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + display@ffef600000 { > + compatible = "thead,th1520-dc8200", "verisilicon,dc"; > + reg = <0xff 0xef600000 0x0 0x100000>; > + interrupts = <93 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk_vo CLK_DPU_CCLK>, > + <&clk_vo CLK_DPU_ACLK>, > + <&clk_vo CLK_DPU_HCLK>, > + <&clk_vo CLK_DPU_PIXELCLK0>, > + <&clk_vo CLK_DPU_PIXELCLK1>; > + clock-names = "core", "axi", "ahb", "pix0", "pix1"; > + resets = <&rst TH1520_RESET_ID_DPU_CORE>, > + <&rst TH1520_RESET_ID_DPU_AXI>, > + <&rst TH1520_RESET_ID_DPU_AHB>; > + reset-names = "core", "axi", "ahb"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; > + > + port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + dpu_out_dp1: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&hdmi_in>; > + }; > + }; > + }; > + }; > + }; > -- > 2.52.0 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv