From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCF55D277DA for ; Sat, 10 Jan 2026 09:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=92RTD51M1K9r5Dyw2akNO3yA1+mGMzBQkat7v8CvzP8=; b=BlovMTwjBgm+QR j4sT/KpQc4+hdxBzJCrWcfvx3Ef6RwZjmgeCp/kb2ZC80tjRLFm6ANALedNWX6FFZkemQNUclE+Bc OIugQ/cQkCdKN820Lya5Jvz+/2FUndf/MwcLZ++8jcUchZcwyse0EedurfU9I22rej4ionH6UX2E2 XOE0f4bGdeyIKirhA7wZWRJz2D4c8zG5Kret8/OTcndc5txRrtcMxhv3N4UPiWGGeOvUKGq8TrRwz udrua4sOgPYq6gY0um+176nDv3E/E8nPXCdxg6SCoBEqMvQGyf6fWlFiU09xrRwhM1jgx2BP/JJ1I 4RXo9m53eU5Do1GJowCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1veVik-00000003NSD-0eJC; Sat, 10 Jan 2026 09:57:22 +0000 Received: from woodpecker.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1veVih-00000003NRq-3aX8 for linux-riscv@lists.infradead.org; Sat, 10 Jan 2026 09:57:21 +0000 Received: from localhost (unknown [116.232.18.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 5C4CE34106C; Sat, 10 Jan 2026 09:57:14 +0000 (UTC) Date: Sat, 10 Jan 2026 17:57:07 +0800 From: Yixun Lan To: Guodong Xu Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , Yangyu Chen , Paul Walmsley , Conor Dooley , Heinrich Schuchardt , Kevin Meng Zhang , Andrew Jones , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 11/11] riscv: dts: spacemit: add SpacemiT K3 Pico-ITX board device tree Message-ID: <20260110095707-GYA12783@gentoo.org> References: <20260110-k3-basic-dt-v4-0-d492f3a30ffa@riscstar.com> <20260110-k3-basic-dt-v4-11-d492f3a30ffa@riscstar.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260110-k3-basic-dt-v4-11-d492f3a30ffa@riscstar.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260110_015719_928116_DD07E98E X-CRM114-Status: GOOD ( 20.63 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Guodong, I have a minor comment for the subject, it's kind of little bit redundant.. so, how about (also apply to patch 10): [PATCH v4 10/11] riscv: dts: spacemit: add initial support for K3 SoC [PATCH v4 11/11] riscv: dts: spacemit: add K3 Pico-ITX board support On 13:18 Sat 10 Jan , Guodong Xu wrote: > K3 Pico-ITX is a 2.5-inch single-board computer equipted with a SpacemiT > K3 SoC. > > This minimal device tree enables booting into a serial console with UART > output. > > Signed-off-by: Guodong Xu > --- > v4: No change. > v3: No change. > v2: Add aliases node in this board DT. > Update the memory node to reflect the hardware truth. Address > starts at 0x100000000 (4G) boundary. > --- > arch/riscv/boot/dts/spacemit/Makefile | 1 + > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 38 ++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+) > > diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile > index 95889e7269d1..7e2b87702571 100644 > --- a/arch/riscv/boot/dts/spacemit/Makefile > +++ b/arch/riscv/boot/dts/spacemit/Makefile > @@ -4,3 +4,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb > dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb > dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb > dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb > +dtb-$(CONFIG_ARCH_SPACEMIT) += k3-pico-itx.dtb > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > new file mode 100644 > index 000000000000..037ce757e5bc > --- /dev/null > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > @@ -0,0 +1,38 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (c) 2025 SpacemiT (Hangzhou) Technology Co. Ltd > + * Copyright (c) 2025 Guodong Xu strictly, should update to cover current year - which is 2026 now > + */ > + > +#include "k3.dtsi" > + > +/ { > + model = "SpacemiT K3 Pico-ITX"; > + compatible = "spacemit,k3-pico-itx", "spacemit,k3"; > + > + aliases { > + serial0 = &uart0; .. > + serial2 = &uart2; > + serial3 = &uart3; > + serial4 = &uart4; > + serial5 = &uart5; > + serial6 = &uart6; > + serial7 = &uart7; > + serial8 = &uart8; > + serial9 = &uart9; > + serial10 = &uart10; I think we only add aliases for devices which actually enabled > + }; > + > + chosen { > + stdout-path = "serial0"; > + }; > + > + memory@100000000 { > + device_type = "memory"; > + reg = <0x1 0x00000000 0x4 0x00000000>; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > > -- > 2.43.0 > -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv