From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D181FD2D0E8 for ; Tue, 13 Jan 2026 12:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WEEtxk8Cwr/3Ax3WM7c+hKIOUWcR3v1vncXJ+J34Y+Q=; b=EMjyaNRgFulzLD RfDEDFtpprvJ9UjuloK74L0J5Bxs4CwnlbNBzf0tBav7qRrj/wWCWPkPEHEoMoJdhNT7DC8grYOux fFPIWFj6OeZ9Hv6MIQ11A/GtSOWSviuvc6VP1gKqRGuB0dt769JfkuZywyZW7AakGpISTPX2yvxfq MNGM5R2mFpdeNiKflMlkl3UORM/5qpVfGKA1+iZRfVhuV0IKmh+5jDTxqNcbSMp3Q+sykfOcA+Oxt 7RCdUtF/iBtSEQi5WvTcDp/f6SZZ0g5mC2dLZlEg0bIaYrsJGJ75gGFoTShRYHdw6PwAK1mR47Pk4 O+VlkQqsRit660NC+9kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfdk2-000000076aX-2urh; Tue, 13 Jan 2026 12:43:22 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vfdk1-000000076Zf-0nmI for linux-riscv@lists.infradead.org; Tue, 13 Jan 2026 12:43:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A0BBC600CB; Tue, 13 Jan 2026 12:43:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D97B0C2BC86; Tue, 13 Jan 2026 12:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768308200; bh=uVtGUyIWHyjoUK8L0H3DB3EX/vfhDouF0fbHo6dDlXk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lEefDc4ZMT1K6SasPRUSeFTJQq1vgaHpTZQxxl61W2ga8c/33ual9q6qDBFuBXtJH 6JtbR3fTxvP6zAEzzC3J/qXE7SRbE5kHbTba/g7Hyu5omNjM1F9mvOc6ISNysLP2fr FwmgVjaWiKZ4RUm6l6GnUFvzLIa+kLI3+KVO6geE9TLx9LjKFcqNX4ddQLS3f70M+O x8xYQ9ChMzNTl4vO/RA+az/2Xg0zgygRp13k9oAOgyC+tlkXMZaw+SPj0+PYjl00uD Ar9o4vZtRCOvjQZJ+LHA6jY9Oigu95NFwiIEmjkpw8UsqJ8dcb6pZY8GxuCI+WbliG WefgteHpR+7jw== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] riscv: word-at-a-time: improve find_zero() for Zbb Date: Tue, 13 Jan 2026 20:24:57 +0800 Message-ID: <20260113122457.27507-4-jszhang@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260113122457.27507-1-jszhang@kernel.org> References: <20260113122457.27507-1-jszhang@kernel.org> MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org In commit f915a3e5b018 ("arm64: word-at-a-time: improve byte count calculations for LE"), Linus improved the find_zero() for arm64 LE. Do the same optimization as he did: "do __ffs() on the intermediate value that found whether there is a zero byte, before we've actually computed the final byte mask.", so that we share the similar improvements: "The difference between the old and the new implementation is that "count_zero()" ends up scheduling better because it is being done on a value that is available earlier (before the final mask). But more importantly, it can be implemented without the insane semantics of the standard bit finding helpers that have the off-by-one issue and have to special-case the zero mask situation." Before the patch: 0000000000000000 : 0: c909 beqz a0,12 <.L1> 2: 60051793 clz a5,a0 6: 03f00513 li a0,63 a: 8d1d sub a0,a0,a5 c: 2505 addiw a0,a0,1 e: 4035551b sraiw a0,a0,0x3 0000000000000012 <.L1>: 12: 8082 ret After the patch: 0000000000000000 : 0: 60151513 ctz a0,a0 4: 810d srli a0,a0,0x3 6: 8082 ret 7 instructions vs 3 instructions! As can be seen, on RV64 w/ Zbb, the new "find_zero()" ends up just "ctz" plus the shift right that then ends up being subsumed by the "add to final length". But I have no HW platform which supports Zbb, so I can't get the performance improvement numbers by the last patch, only built and tested the patch on QEMU. Signed-off-by: Jisheng Zhang --- arch/riscv/include/asm/word-at-a-time.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/riscv/include/asm/word-at-a-time.h b/arch/riscv/include/asm/word-at-a-time.h index ca3d30741ed1..8c5ac6a72f7f 100644 --- a/arch/riscv/include/asm/word-at-a-time.h +++ b/arch/riscv/include/asm/word-at-a-time.h @@ -38,6 +38,9 @@ static inline unsigned long prep_zero_mask(unsigned long val, static inline unsigned long create_zero_mask(unsigned long bits) { + if (riscv_has_extension_likely(RISCV_ISA_EXT_ZBB)) + return bits; + bits = (bits - 1) & ~bits; return bits >> 7; } @@ -69,13 +72,19 @@ static inline long count_masked_bytes(long mask) static inline unsigned long find_zero(unsigned long mask) { if (riscv_has_extension_likely(RISCV_ISA_EXT_ZBB)) - return !mask ? 0 : ((__fls(mask) + 1) >> 3); + return __ffs(mask) >> 3; return count_masked_bytes(mask); } -/* The mask we created is directly usable as a bytemask */ -#define zero_bytemask(mask) (mask) +static inline unsigned long zero_bytemask(unsigned long bits) +{ + if (!riscv_has_extension_likely(RISCV_ISA_EXT_ZBB)) + return bits; + + bits = (bits - 1) & ~bits; + return bits >> 7; +} #endif /* !(defined(CONFIG_RISCV_ISA_ZBB) && defined(CONFIG_TOOLCHAIN_HAS_ZBB)) */ -- 2.51.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv