>On Fri, Jan 16, 2026 at 02:12:06PM -0600, Andrew Jones wrote:
>...
>> > @@ -1055,6 +1135,11 @@ static void riscv_iommu_iodir_update(struct riscv_iommu_device *iommu,
>> >  		/* Invalidate device context after update */
>> >  		riscv_iommu_cmd_iodir_inval_ddt(&cmd);
>> >  		riscv_iommu_cmd_iodir_set_did(&cmd, fwspec->ids[i]);
>> > +		/*
>> > +		 * For now, the SVA and PASID features have not yet been merged, the
>> > +		 * default configuration is inval_pdt=false and pc=NULL.
>> > +		 */
>> > +		riscv_iommu_iodir_iotinval(iommu, false, dc->iohgatp, dc, NULL);
>
>Shouldn't this iotinval come after the cmd-send below?

Yes, that's a typo on my side.
I’ll fix in v2.
>
>> >  		riscv_iommu_cmd_send(iommu, &cmd);
>> >  	}
>> >  
>> > -- 
>> > 2.50.1
>> >
>
>Thanks,
>drew
>
Thanks,
Fangyu