From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F562C44500 for ; Thu, 22 Jan 2026 12:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tnRfpOn6kJ/Gjirvvs/q24hG8wk3jibqZd4V4+USQRo=; b=KHSfCd0rg+/0z5 EV1LxIBhQLGyYugmauzBXm8XHeCXOUIgpSvG/1ENT1j2qeSlb6ycSP8OE3e7ki8+XgYVrgGMNervj fViHOnV0X1pjEZOe2Edd9Cdm7Q7aOq639iQx1+Q46I6XncpDLJAo0dMUcY3O8jDjeIhZuWnHnmrx8 PWMzAFV2TFIga+5TUA2PTxdWJ56QjyV0/LvO52zLDOHntTLI1XywiD6yhZZKFHk6qTNgl0Tn752ia j1/bQ5JmC6vuqCAPsfRVVr8smVBytfoaNrvD13EB+cpw9lCjH+8pg4iYC8W0dAKdCU+2tXq+/KziO P+YjOSzRALB0s9J+6B6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vitiT-000000073D7-2lxr; Thu, 22 Jan 2026 12:23:13 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vitiR-000000073Cm-1UDZ for linux-riscv@lists.infradead.org; Thu, 22 Jan 2026 12:23:12 +0000 Received: from localhost (unknown [116.232.27.242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 9116E341A11; Thu, 22 Jan 2026 12:23:09 +0000 (UTC) Date: Thu, 22 Jan 2026 20:23:05 +0800 From: Yixun Lan To: Guodong Xu Cc: Liam Girdwood , Mark Brown , Alex Elder , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Troy Mitchell , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties Message-ID: <20260122122305-GYD63789@gentoo.org> References: <20260122-spacemit-p1-v1-0-309be27fbff9@riscstar.com> <20260122-spacemit-p1-v1-2-309be27fbff9@riscstar.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260122-spacemit-p1-v1-2-309be27fbff9@riscstar.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260122_042311_443467_62579C79 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Guodong, On 17:43 Thu 22 Jan , Guodong Xu wrote: > Add supply properties that match the P1 PMIC's actual hardware topology > where each buck converter has its own VIN pin and LDO groups share > common input pins. Supply names are defined according to the pinout > names in the P1 datasheet. > While checking schematics/docs, I found the SWIN/SWOUT are not described in the dt-binding? is this intentional? I have no problem if you plan to implement it separately later, just curious to ask.. In Bananapi F3/Jupiter board, it's used as LCD_VCC5V0 out > This allows different boards to describe their actual > power tree connections in devicetree rather than hardcoding supply > relationships in the driver. > > Signed-off-by: Guodong Xu > --- > .../devicetree/bindings/mfd/spacemit,p1.yaml | 58 +++++++++++++++++++++- > 1 file changed, 56 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > index c6593ac6ef6adb72fc48af570dc13fc9edf77ccb..abdc93b9a67b1872c8fe6955abd950622a0b69e8 100644 > --- a/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > +++ b/Documentation/devicetree/bindings/mfd/spacemit,p1.yaml > @@ -27,8 +27,41 @@ properties: > interrupts: > maxItems: 1 > > - vin-supply: > - description: Input supply phandle. > + vin1-supply: > + description: > + Power supply for BUCK1. Required if BUCK1 is defined. > + > + vin2-supply: > + description: > + Power supply for BUCK2. Required if BUCK2 is defined. > + > + vin3-supply: > + description: > + Power supply for BUCK3. Required if BUCK3 is defined. > + > + vin4-supply: > + description: > + Power supply for BUCK4. Required if BUCK4 is defined. > + > + vin5-supply: > + description: > + Power supply for BUCK5. Required if BUCK5 is defined. > + > + vin6-supply: > + description: > + Power supply for BUCK6. Required if BUCK6 is defined. > + > + aldoin-supply: > + description: > + Power supply for ALDO1-4. Required if any are defined. > + > + dldoin1-supply: > + description: > + Power supply for DLDO1-4. Required if any are defined. > + > + dldoin2-supply: > + description: > + Power supply for DLDO5-7. Required if any are defined. > > regulators: > type: object > @@ -50,6 +83,15 @@ unevaluatedProperties: false > > examples: > - | > + / { > + reg_vcc_5v: regulator-vcc-5v { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + }; > + > i2c { > #address-cells = <1>; > #size-cells = <0>; > @@ -58,6 +100,10 @@ examples: > compatible = "spacemit,p1"; > reg = <0x41>; > interrupts = <64>; > + vin1-supply = <®_vcc_5v>; > + vin5-supply = <®_vcc_5v>; > + aldoin-supply = <®_vcc_5v>; > + dldoin1-supply = <&buck5>; > > regulators { > buck1 { > @@ -68,6 +114,14 @@ examples: > regulator-always-on; > }; > > + buck5: buck5 { > + regulator-name = "buck5"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <3450000>; > + regulator-ramp-delay = <5000>; > + regulator-always-on; > + }; > + > aldo1 { > regulator-name = "aldo1"; > regulator-min-microvolt = <500000>; > > -- > 2.43.0 > -- Yixun Lan (dlan) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv