Re: [PATCH] dt-bindings: pinctrl: spacemit: fix drive-strength check warning

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2053 bytes --]

On Fri, Jan 30, 2026 at 07:22:15PM +0800, Yixun Lan wrote:
> The problem is that one value from drive-strength may match to more than
> two different enum groups which lead to DT complaint, switch to use 'anyOf'
> to fix this kind warning.
> 

Acked-by: Conor Dooley <conor.dooley@microchip.com>

And I guess:
Reported-by: Conor Dooley <conor.dooley@microchip.com>


> Fixes: c3efac0592f8 ("dt-bindings: pinctrl: spacemit: convert drive strength to schema format")
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
> Doing DT check with command: make dtbs_check W=1, will get this kind
> of warning message:
> 
> arch/riscv/boot/dts/spacemit/k1-musepi-pro.dtb: pinctrl@d401e000 (spacemit,k1-pinctrl): gmac0-cfg:gmac0-pins:drive-strength: 21 is valid under each of {'enum': [2, 4, 6, 7, 9, 11, 13, 14, 21, 23, 25, 26, 28, 30, 31, 33]}, {'enum': [11, 21, 32, 42]}
> 
> Instead of using more complicated minimum and maximum value of property
> with constrains of compatibles, we decide to use 'anyOf' to fix this
> warning.
> ---
>  Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> index f009fed87e6b..5194fa92fe93 100644
> --- a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> @@ -76,7 +76,7 @@ patternProperties:
>            drive-strength:
>              description:
>                typical current (in mA) when the output at high level.
> -            oneOf:
> +            anyOf:
>                - enum: [ 11, 21, 32, 42 ]
>                  description: For K1 SoC, 1.8V voltage output
>  
> 
> ---
> base-commit: 3fcdb264b61a5bb0eb3fb7272717468aa376a74c
> change-id: 20260130-k3-pinctrl-io-drv-fix-5b11752dae1f
> 
> Best regards,
> -- 
> Yixun Lan <dlan@kernel.org>
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv