From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52A15FEFB57 for ; Fri, 27 Feb 2026 14:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0tRMvGfroAWMx/8bbMSYgdTCJZgOhgrgY+Avgmcv7v0=; b=3jGzZmXkpqBCA9 PCs0c6kkBJiIKEqyWiCr3cw1+dI8KtWdmt/cNv/psZn4jhAef8dQIEz+pUpxfw/HePsuw25o/dtyn YdXB0HqIIQfIpCXyAHjwMPjxWnd55t2qHIMMzCZbtQernGUDebFMfyGe9gcCtTZHghwKJFIySuySk JNwcXUEd+I8wlCHTdzDiPSu7Dz1oTH6Ju3ynzLgECrj6biNIh+/XgWqUs7HINy6KHmoaMQYE0Eu09 xEAbayZOL7vCvSq1kmt/FKsaFDUzAy1ea3u5vg1dXSNGXNDO3OBaLw7dUikmZRo+u9yubTTXjkai6 PV+YWC1mFjWKYEPxFQng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvyam-00000008TmX-3hIN; Fri, 27 Feb 2026 14:13:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvyaj-00000008Tlr-2A4u; Fri, 27 Feb 2026 14:13:19 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 5A9ED68B05; Fri, 27 Feb 2026 15:13:11 +0100 (CET) Date: Fri, 27 Feb 2026 15:13:11 +0100 From: Christoph Hellwig To: Heiko Carstens Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 17/25] s390: move the XOR code to lib/raid/ Message-ID: <20260227141311.GA22216@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-18-hch@lst.de> <20260227090959.10882Af7-hca@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260227090959.10882Af7-hca@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260227_061317_707109_212447EF X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Feb 27, 2026 at 10:09:59AM +0100, Heiko Carstens wrote: > However, I just had a look at the s390 implementation and just saw that the > inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", > and "p2" are input operands, while all three of them are modified within > the inline assembly. Given that the function consists only of this inline > assembly I doubt that this causes any harm, however I still want to fix > this now; but your patch should apply fine with or without this fixed. Two comments on that: I thin kin the long run simply moving the implementation to a pure assembly file might be easier to maintain. Also with this series you can now optimize for more than 5 stripes, which should be the mormal case. I'll try to make sure we'll get units tests to help with that. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv