From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42990FEE4C4 for ; Sat, 28 Feb 2026 04:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FLjCXEpvoMTFrRSqfFuXsziZwh0NjyM+mgKMPBUvP6s=; b=HjmYWjTn86dqk7 jA8nfzFN6nquXdpxCONN+4dbQCEcrIlkjSaqce3PyyReS5p3lo7z5KQ73IfyQbkKP8cGUHkQu+4zF TCMx2LLmlGR1sd/c9radz73Ok7rdOhtDAcGdmOaHF1ZGlLrdTAHri70smE/nXiiM1+3o0tVNUmsHg S3T3esISxLYaZMAOh/TAFt9Qsyac368EgIH9erZz2sJSWBOccBagyoWBl+YEHSlSE3jcInawsclt1 KttArrWbumHdq5GKfX6b3wpU+EmWcgNvbSOO205HAXPlMy3bEZvEHi7crbjg4/JvO16dwwebgBl0L wqq/TWNEIHMW9l7oyhRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwByH-00000009U3p-08pj; Sat, 28 Feb 2026 04:30:29 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwBy5-00000009U3A-12Td; Sat, 28 Feb 2026 04:30:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3A6BB4388D; Sat, 28 Feb 2026 04:30:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 198B3C116D0; Sat, 28 Feb 2026 04:30:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772253010; bh=NxIyVYtgLysk+spkHOyEoka9HT1s3BaoNbqWwqQmPXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fyh0YCjcPmsVmzz5h+F1Yy8gWejjphUUrGeKnqhIxGQ+qjYtEztmeP1kaQL7ddsRN jdkA6zr3qARSLzOxvszanCJtbGe6MxgPdM+Z6+dhb7aZQXTNmMRzbGAktPG2fY5fUl TBJYgxI6xb9qhwF67ngcAYU9OKtc/uqzcX+3yEYAKMVGlX0rGBTQLNzUCfh3Qw8tog 0VEAgqbQJ3xpTSjCyP3w5YgI628hkJaD1By1DZb0TabsJZRA6BOO4+elbK3T8jYutF xqGj5SaKcx64Foh0YOFWYjXkw2x5ciOjaB0TEjg5I3513gVMPITkGZ7CF1NbrQ8JTi 72nJ1I+TSmVTQ== Date: Fri, 27 Feb 2026 20:30:06 -0800 From: Eric Biggers To: Christoph Hellwig Cc: Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Message-ID: <20260228043006.GA65277@quark> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260226151106.144735-4-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260227_203017_369682_D82C1B09 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Feb 26, 2026 at 07:10:15AM -0800, Christoph Hellwig wrote: > XOR_SELECT_TEMPLATE is only ever called with a NULL argument, so all the > ifdef'ery doesn't do anything. With our without this, the time travel > mode should work fine on CPUs that support AVX2, as the AVX2 > implementation is forced in this case, and won't work otherwise. > > Signed-off-by: Christoph Hellwig > --- > arch/um/include/asm/xor.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/um/include/asm/xor.h b/arch/um/include/asm/xor.h > index 647fae200c5d..c9ddedc19301 100644 > --- a/arch/um/include/asm/xor.h > +++ b/arch/um/include/asm/xor.h > @@ -4,21 +4,11 @@ > > #ifdef CONFIG_64BIT > #undef CONFIG_X86_32 > -#define TT_CPU_INF_XOR_DEFAULT (AVX_SELECT(&xor_block_sse_pf64)) > #else > #define CONFIG_X86_32 1 > -#define TT_CPU_INF_XOR_DEFAULT (AVX_SELECT(&xor_block_8regs)) > #endif > > #include > #include <../../x86/include/asm/xor.h> > -#include > - > -#ifdef CONFIG_UML_TIME_TRAVEL_SUPPORT > -#undef XOR_SELECT_TEMPLATE > -/* pick an arbitrary one - measuring isn't possible with inf-cpu */ > -#define XOR_SELECT_TEMPLATE(x) \ > - (time_travel_mode == TT_MODE_INFCPU ? TT_CPU_INF_XOR_DEFAULT : x) > -#endif I'm not following this change. Previously, in TT_MODE_INFCPU mode, XOR_SELECT_TEMPLATE(NULL) returned &xor_block_avx, &xor_block_sse_pf64, or &xor_block_8regs, causing the benchmark to be skipped. After this change, the benchmark starts being done on CPUs that don't support AVX. - Eric _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv