Re: [PATCH net-next v8 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC

Inochi Amaoto
2026-03-09T22:28:56Z

On Mon, Mar 09, 2026 at 11:57:51AM +0000, Russell King (Oracle) wrote:
> On Mon, Mar 09, 2026 at 08:42:44AM +0800, Inochi Amaoto wrote:
> > +static int spacemit_dwmac_update_irq_config(struct spacmit_dwmac *dwmac,
> > + struct stmmac_resources *stmmac_res)
> > +{
> > + unsigned int mask = CTRL_WAKE_IRQ_EN;
> > + unsigned int val = stmmac_res->wol_irq >= 0 ? CTRL_WAKE_IRQ_EN : 0;
>
> This looks like the last thing I can spot that needs to be addressed.
> netdev wants to see "reverse christmas tree" local variable
> declarations.
>
> Please reverse the order of these two declarations to achieve that.
>
> With that fixed:
>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Thanks!
>

Great, after some lookup, I find the variables in function
spacemit_set_phy_intf_sel() are also needed to reversed.
I will also fix this in the next version.

Regards,
Inochi