Re: [PATCH v5 1/2] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_acpi_id() on non-x86

Bjorn Helgaas
2026-03-10T17:53:18Z

On Tue, Mar 10, 2026 at 11:20:48AM +0800, Chengwen Feng wrote:
> To unify the CPU ACPI ID retrieval interface across architectures,
> rename the existing get_acpi_id_for_cpu() function to
> acpi_get_cpu_acpi_id() on arm64/riscv/loongarch platforms.
>
> This is a pure rename with no functional change, preparing for a
> consistent ACPI Processor UID retrieval interface across all ACPI-enabled
> platforms.

Really a question for the ACPI folks, but my preferences would be:

- Simpler name for the interface, e.g., "acpi_get_cpu_id()"

- Single prototype in generic header, e.g., include/linux/acpi.h

- Split the x86 part to a separate patch and maybe (a tangent, but
looks dubious to me) figure out whether/why xen needs xen_vcpu_id
to be ACPI CPU IDs

> Cc: stable@vger.kernel.org
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> arch/arm64/include/asm/acpi.h | 4 ++--
> arch/loongarch/include/asm/acpi.h | 2 +-
> arch/riscv/include/asm/acpi.h | 2 +-
> arch/riscv/kernel/acpi_numa.c | 2 +-
> drivers/acpi/pptt.c | 16 ++++++++--------
> drivers/acpi/riscv/rhct.c | 2 +-
> drivers/perf/arm_cspmu/arm_cspmu.c | 2 +-
> 7 files changed, 15 insertions(+), 15 deletions(-)