Re: [PATCH 10/27] alpha: move the XOR code to lib/raid/

Magnus Lindholm
2026-03-16T22:13:07Z

On Wed, Mar 11, 2026 at 8:06 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Move the optimized XOR code out of line into lib/raid.
>
> Note that the giant inline assembly block might be better off as a
> separate assembly source file now, but I'll leave that to the alpha
> maintainers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/alpha/include/asm/xor.h | 853 +----------------------------------
> lib/raid/xor/Makefile | 2 +
> lib/raid/xor/alpha/xor.c | 849 ++++++++++++++++++++++++++++++++++
> 3 files changed, 855 insertions(+), 849 deletions(-)
> create mode 100644 lib/raid/xor/alpha/xor.c
>

Hi,

I applied this patch and ran it on my UP2000+

The kernel builds and boots, and I verified the new lib/raid/xor/alpha
implementation using the XOR KUnit test, the test passed, see below:

[ 25.705064] KTAP version 1
[ 25.705064] # Subtest: xor
[ 25.705064] # module: xor_kunit
[ 25.705064] 1..1
[ 28.957992] # xor_test: Test should be marked slow (runtime:
3.253413330s)
[ 28.958969] ok 1 xor_test

Acked-by: Magnus Lindholm <linmag7@gmail.com>
Tested-by: Magnus Lindholm <linmag7@gmail.com>