From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C879F46453 for ; Mon, 16 Mar 2026 11:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SchxjJFUIg0054euqgF3OxJksoXvzrzvk+a8bL4R8Lo=; b=BPTKV4scyF453GdeAb6XfiL2Ra WyFO+tONuZgSuHEaJeaE+l6nrM2AomEAlwN+IuF2H+LncEhLW5gAiiAc+wgFckfD/ldMqiU+G8XJO DzuePJgauUUtoFwvs2Z4ldvATF9g9AQRycstdblJTZ9KNPO0P5CYBY/EK2fhbkVtR6qFcrkM2eo1v UI3YQh/+JhC1vFFEFSBB5KFnk0V3gsyVro80qv/NPVBMV+kS0mPdcI7GIve3dNTlUe3gldAIrFyK+ SEzVcHKbB7ALoPvasLirSD8NgsmChwXOBUgYJquHU6CHTLPeFS3zMnTXp06bOxTI4tLW0EU5k8WU8 uWg9HzeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w261g-00000003oib-0aSl; Mon, 16 Mar 2026 11:22:24 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w261e-00000003oiE-1NTw for linux-riscv@lists.infradead.org; Mon, 16 Mar 2026 11:22:23 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 86C4040E06; Mon, 16 Mar 2026 11:22:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44A30C19421; Mon, 16 Mar 2026 11:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773660141; bh=hZ7HCxXZH+KCGvedYMF3TeE2GVqJXuozWkiILmg+dJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LTLVCK+CdnGJygYTinaAMAF+FIIYL1H+vkvjx8oYuQMjaVC+XjhnpZuf0TKwRPYnp EMQuwlvUtIOb2UNxDoZABKAQch6s07FeBfppJPxUZPmzGRqVpHKqGmTY1Rzuqk7Xpo uAjB17JcB4VVqReeg+d+nj2pQ2HWKBSSSMD9VFG7kqkwFxN3pniM7EsbGrWcegbw2/ yJ7XW6MH65V4cSG+kN2ei+u2NoWi7l8ql/GGjh9KVbMftwNBvhCYMRHCXm1AUINn0J UW+8CozvVuszS0aKonYx7vohj6tRK/BnnPklcg2Ugjv+5JXh6pmbQrcrFPOWXAYSOA eG87AInFdt4lA== Date: Mon, 16 Mar 2026 11:22:16 +0000 From: Conor Dooley To: Jia Wang Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Andy Shevchenko , Greg Kroah-Hartman , Jiri Slaby , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Zhang Xincheng Subject: Re: [PATCH 1/2] riscv: ultrarisc: 8250_dw: support DP1000 uart Message-ID: <20260316-frayed-pretended-eba059554dcc@spud> References: <20260316-ultrarisc-serial-v1-0-c464f3e933a5@ultrarisc.com> <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com> MIME-Version: 1.0 In-Reply-To: <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260316_042222_405275_1C226841 X-CRM114-Status: GOOD ( 21.48 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7548872264300075359==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============7548872264300075359== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1+Bm8qKmqRdbiva4" Content-Disposition: inline --1+Bm8qKmqRdbiva4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2026 at 09:36:18AM +0800, Jia Wang wrote: > From: Zhang Xincheng >=20 > The UART of DP1000 does not support automatic detection of > buffer size. skip_autocfg needs to be set to true >=20 > Signed-off-by: Zhang Xincheng > Signed-off-by: Jia Wang $subject: riscv: ultrarisc: 8250_dw: support DP1000 uart Please update this to match other modifications to this file. "riscv: ultrariscv" doesn't belong at the start. > --- > drivers/tty/serial/8250/8250_dw.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/= 8250_dw.c > index db73b2ae17fa..6a2acf173331 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -56,6 +56,7 @@ > #define DW_UART_QUIRK_IS_DMA_FC BIT(3) > #define DW_UART_QUIRK_APMC0D08 BIT(4) > #define DW_UART_QUIRK_CPR_VALUE BIT(5) > +#define DW_UART_QUIRK_FIXED_TYPE BIT(6) > =20 > struct dw8250_platform_data { > u8 usr_reg; > @@ -514,6 +515,11 @@ static void dw8250_quirks(struct uart_port *p, struc= t dw8250_data *data) > data->data.dma.prepare_tx_dma =3D dw8250_prepare_tx_dma; > data->data.dma.prepare_rx_dma =3D dw8250_prepare_rx_dma; > } > + if (quirks & DW_UART_QUIRK_FIXED_TYPE) { > + p->flags |=3D UPF_FIXED_TYPE; > + p->type =3D PORT_16550A; > + data->skip_autocfg =3D true; > + } > if (quirks & DW_UART_QUIRK_APMC0D08) { > p->iotype =3D UPIO_MEM32; > p->regshift =3D 2; > @@ -789,6 +795,11 @@ static const struct dw8250_platform_data dw8250_skip= _set_rate_data =3D { > .quirks =3D DW_UART_QUIRK_SKIP_SET_RATE, > }; > =20 > +static const struct dw8250_platform_data dw8250_ultrarisc_dp1000_data = =3D { > + .usr_reg =3D DW_UART_USR, > + .quirks =3D DW_UART_QUIRK_FIXED_TYPE, > +}; > + > static const struct of_device_id dw8250_of_match[] =3D { > { .compatible =3D "snps,dw-apb-uart", .data =3D &dw8250_dw_apb }, > { .compatible =3D "cavium,octeon-3860-uart", .data =3D &dw8250_octeon_3= 860_data }, > @@ -796,6 +807,7 @@ static const struct of_device_id dw8250_of_match[] = =3D { > { .compatible =3D "renesas,rzn1-uart", .data =3D &dw8250_renesas_rzn1_d= ata }, > { .compatible =3D "sophgo,sg2044-uart", .data =3D &dw8250_skip_set_rate= _data }, > { .compatible =3D "starfive,jh7100-uart", .data =3D &dw8250_skip_set_ra= te_data }, > + { .compatible =3D "ultrarisc,dp1000-uart", .data =3D &dw8250_ultrarisc_= dp1000_data }, > { /* Sentinel */ } > }; > MODULE_DEVICE_TABLE(of, dw8250_of_match); >=20 > --=20 > 2.34.1 >=20 >=20 > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv --1+Bm8qKmqRdbiva4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCabfn5wAKCRB4tDGHoIJi 0v45AQD3hFtUbi/xAvY2OzMR5EdszsS2CzI9H3nNfQnqWUuVywD8CJ+C7OenjQXS FCfdsrcoF8ZN3KYfs+EfK29lh/SHYgs= =8Hwm -----END PGP SIGNATURE----- --1+Bm8qKmqRdbiva4-- --===============7548872264300075359== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============7548872264300075359==--