From: Andrew Morton <akpm@linux-foundation.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Suren Baghdasaryan <surenb@google.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] riscv: mm: add null check for find_vm_area in __set_memory
Date: Mon, 16 Mar 2026 08:44:55 -0700 [thread overview]
Message-ID: <20260316084455.bb44dd7baa47487f1e567ce9@linux-foundation.org> (raw)
In-Reply-To: <20260316151642.13738-1-osama.abdelkader@gmail.com>
On Mon, 16 Mar 2026 16:16:39 +0100 Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
> find_vm_area() can return NULL. Add a null check to avoid potential
> null pointer dereference, matching the pattern used by other arches.
>
> Fixes: 311cd2f6e253 ("riscv: Fix set_memory_XX() and set_direct_map_XX() by splitting huge linear mappings")
Three years ago.
> Cc: stable@vger.kernel.org
Why cc:stable? Has anyone ever hit this? Are we able to identify a
scenario where this bug might be triggered?
> --- a/arch/riscv/mm/pageattr.c
> +++ b/arch/riscv/mm/pageattr.c
> @@ -289,6 +289,10 @@ static int __set_memory(unsigned long addr, int numpages, pgprot_t set_mask,
> int i, page_start;
>
> area = find_vm_area((void *)start);
> + if (!area) {
> + ret = -EINVAL;
> + goto unlock;
> + }
> page_start = (start - (unsigned long)area->addr) >> PAGE_SHIFT;
>
> for (i = page_start; i < page_start + numpages; ++i) {
> --
> 2.43.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-16 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 15:16 [PATCH v2] riscv: mm: add null check for find_vm_area in __set_memory Osama Abdelkader
2026-03-16 15:44 ` Andrew Morton [this message]
2026-03-16 17:38 ` Lorenzo Stoakes (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316084455.bb44dd7baa47487f1e567ce9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=osama.abdelkader@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox