From: Conor Dooley <conor@kernel.org>
To: Yong-Xuan Wang <yongxuan.wang@sifive.com>
Cc: Paul Walmsley <pjw@kernel.org>,
Samuel Holland <samuel.holland@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
greentime.hu@sifive.com, vincent.chen@sifive.com,
zong.li@sifive.com
Subject: Re: [PATCH] riscv/sifive: remove warning in errata
Date: Mon, 27 Apr 2026 16:12:30 +0100 [thread overview]
Message-ID: <20260427-landside-bush-45bf90908635@spud> (raw)
In-Reply-To: <20260426-vendor-v1-1-041fbde8918f@sifive.com>
[-- Attachment #1.1: Type: text/plain, Size: 1232 bytes --]
On Sun, Apr 26, 2026 at 07:53:46PM -0700, Yong-Xuan Wang wrote:
> The patch_id of the availability checking for SiFive vendor extensions
> will always larger than ERRATA_SIFIVE_NUMBER. Remove this unnecessary
> warning.
I'm sorry, I don't quite understand this commit message. Where is the
other warning that makes this one unneeded?
I think the commit message needs to point out where that is.
Cheers,
Conor.
>
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
> ---
> arch/riscv/errata/sifive/errata.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/errata/sifive/errata.c b/arch/riscv/errata/sifive/errata.c
> index d0c61f86cba3..98edd9143321 100644
> --- a/arch/riscv/errata/sifive/errata.c
> +++ b/arch/riscv/errata/sifive/errata.c
> @@ -94,7 +94,6 @@ void sifive_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
> if (alt->vendor_id != SIFIVE_VENDOR_ID)
> continue;
> if (alt->patch_id >= ERRATA_SIFIVE_NUMBER) {
> - WARN(1, "This errata id:%d is not in kernel errata list", alt->patch_id);
> continue;
> }
>
>
> ---
> base-commit: ddbf9c76c4020bf63a0799b00faad40caa3de6c2
> change-id: 20260426-vendor-4b4427e0b670
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-04-27 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 2:53 [PATCH] riscv/sifive: remove warning in errata Yong-Xuan Wang
2026-04-27 15:12 ` Conor Dooley [this message]
2026-04-29 14:56 ` Yong-Xuan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427-landside-bush-45bf90908635@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=vincent.chen@sifive.com \
--cc=yongxuan.wang@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox