From: Yixun Lan <dlan@kernel.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>,
Troy Mitchell <troy.mitchell@linux.dev>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Michael Opdenacker <michael.opdenacker@rootcommit.com>,
Alexandre Ghiti <alex@ghiti.fr>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org,
Margherita Milani <margherita.milani@amarulasolutions.com>,
linux-riscv@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
spacemit@lists.linux.dev,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v8 8/9] riscv: dts: spacemit: k1-bananapi-f3: add SD card support with UHS modes
Date: Fri, 8 May 2026 23:10:51 +0000 [thread overview]
Message-ID: <20260508231051-GKC3590877@kernel.org> (raw)
In-Reply-To: <20260508225341-GKB3590877@kernel.org>
On 22:53 Fri 08 May , Yixun Lan wrote:
> Hi Iker, Troy,
>
..
> I would object to add CONFIG_I2C_K1 as hard dependency, the reason is
> that the spacemit sdhci driver (sdhci-of-k1.c) has no used i2c
> api/function, it's just need I2C function via an indirect requirement,
> which sdhci -> regulator(p1) -> i2c, besides, from the hardware design
> perspective, it just happens that K1 use P1(via I2C) as PMIC, it's
> totally possible(even in theory) to use other PMIC as power supply
> control which may not be I2C interface (maybe use SPI, for example)
>
> If we want to solve this more gracefully, I'm in favor to add explict
> option enabled in defconfig..
>
or I think it's better we do this way..
+++ b/drivers/i2c/busses/Kconfig
@@ -794,6 +794,7 @@ config I2C_K1
tristate "SpacemiT K1 I2C adapter"
depends on ARCH_SPACEMIT || COMPILE_TEST
depends on OF
+ default ARCH_SPACEMIT
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-05-08 23:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 8:02 [PATCH v8 0/9] riscv: spacemit: enable SD card support with UHS modes for OrangePi RV2 Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 1/9] dt-bindings: mmc: spacemit,sdhci: add pinctrl support for voltage switching Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 2/9] mmc: sdhci-of-k1: enable essential clock infrastructure for SD operation Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 3/9] mmc: sdhci-of-k1: add regulator and pinctrl voltage switching support Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 4/9] mmc: sdhci-of-k1: add comprehensive SDR tuning support Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 5/9] riscv: dts: spacemit: k1: add SD card controller and pinctrl support Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 6/9] riscv: dts: spacemit: k1-orangepi-rv2: add PMIC and power infrastructure Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 7/9] riscv: dts: spacemit: k1-orangepi-rv2: add SD card support with UHS modes Iker Pedrosa
2026-04-13 8:02 ` [PATCH v8 8/9] riscv: dts: spacemit: k1-bananapi-f3: " Iker Pedrosa
2026-05-07 8:20 ` Margherita Milani
2026-05-07 9:53 ` Iker Pedrosa
2026-05-07 10:45 ` Troy Mitchell
2026-05-08 22:53 ` Yixun Lan
2026-05-08 23:10 ` Yixun Lan [this message]
2026-05-11 8:01 ` Iker Pedrosa
2026-05-07 18:28 ` Aurelien Jarno
2026-05-08 22:27 ` Yixun Lan
2026-04-13 8:02 ` [PATCH v8 9/9] riscv: dts: spacemit: k1-musepi-pro: " Iker Pedrosa
2026-04-13 8:07 ` [PATCH v8 0/9] riscv: spacemit: enable SD card support with UHS modes for OrangePi RV2 Krzysztof Kozlowski
2026-04-14 7:12 ` Iker Pedrosa
2026-04-14 8:13 ` Troy Mitchell
2026-04-16 8:18 ` Iker Pedrosa
2026-04-23 9:44 ` Krzysztof Kozlowski
2026-04-23 12:42 ` Anand Moon
2026-05-07 9:57 ` Iker Pedrosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508231051-GKC3590877@kernel.org \
--to=dlan@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ikerpedrosam@gmail.com \
--cc=javierm@redhat.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=margherita.milani@amarulasolutions.com \
--cc=michael.opdenacker@rootcommit.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox