Re: [PATCH v3 0/6] spacemit: k1-musepi-pro: add missing devices

[Yixun Lan <dlan@kernel.org>]

Andre,
 
 Thanks for pushing this new version, overall, this series looks good to me,
Although there are few quite trivial issues, which I could help to fix it while
applying, let's give community some time to test and review..

 P.S I haven't run it on musepi board, but trust you tested all functions..

On 09:19 Wed 13 May     , Andre Heider wrote:
> Add the missing devices with their required regulators. The regulators are named after
> their label in the vendor schematics[0].
> 
> v3:
> - drop reg_usb_vbus, non-controllable and served only as vin-supply
> - fixed regulator-vcc-4v0 typo
> - fold addition of pmic regulator labels into the pmic patch
> - eeprom is a GT24C02B, fixed commit message
> - added reg_qspi_vcc1v833
> - fixed uboot nor name offset
> - add missing "reg_" prefix for reg_pcie_vcc_3v3
> - drop pcie{1,2}'s vpcie3v3-supply, it's already specified on the root ports
> 
> v2:
> - drop reg_vcc_5v0_sys as per "non-controllable" review comments on
>   similar patches for other boards (kept the root reg_usb_vbus for though)
> - add reg_vcc_4v0 instead as p1 vin?-supply, misread the schematics
> - drop mpcie_vcc_3v3 and use pcie_vcc_3v3 for pcie2* too
>   ("non-controllable" again)
> - all of the above makes it consistent with other k1 boards
> 
> v1: https://lore.kernel.org/spacemit/20260505160623.1369347-1-a.heider@gmail.com/T/#t
> 
> $ cat /sys/kernel/debug/regulator/regulator_summary
>  regulator                      use open bypass  opmode voltage current     min     max
> ---------------------------------------------------------------------------------------
>  regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
>  PCIE_VCC3V3                      5    4      0 unknown  3300mV     0mA  3300mV  3300mV
>     ca400000.pcie:pcie@0-vpcie3v3   1                                 0mA     0mV     0mV
>     ca800000.pcie:pcie@0-vpcie3v3   1                                 0mA     0mV     0mV
>     ca800000.pcie-vpcie3v3        1                                 0mA     0mV     0mV
>     ca400000.pcie-vpcie3v3        1                                 0mA     0mV     0mV
>  VCC4V0                           8   10      0 unknown  4000mV     0mA  4000mV  4000mV
>     buck1                         1    0      0 unknown  1050mV     0mA   500mV  3450mV
>     buck2                         1    0      0 unknown   900mV     0mA   500mV  3450mV
>     buck3                         1    1      0 unknown  1800mV     0mA   500mV  1800mV
>        2-0050-vcc                 0                                 0mA     0mV     0mV
>     buck4                         2    2      0 unknown  3300mV     0mA   500mV  3300mV
>        d4280000.mmc-vmmc          0                                 0mA  3300mV  3300mV
>        QSPI_VCC1833               2    1      0 unknown  1833mV     0mA  1833mV  1833mV
>           spi0.0-vcc              1                                 0mA     0mV     0mV
>     buck5                         3    7      0 unknown  2100mV     0mA   500mV  3450mV
>        dldo1                      0    0      0 unknown  1200mV     0mA   500mV  3400mV
>        dldo2                      0    0      0 unknown   500mV     0mA   500mV  3400mV
>        dldo3                      0    0      0 unknown   500mV     0mA   500mV  3400mV
>        dldo4                      1    0      0 unknown  1800mV     0mA   500mV  3400mV
>        dldo5                      0    0      0 unknown   500mV     0mA   500mV  3400mV
>        dldo6                      1    0      0 unknown  1800mV     0mA   500mV  3400mV
>        dldo7                      0    0      0 unknown   500mV     0mA   500mV  3400mV
>     buck6                         1    0      0 unknown  1100mV     0mA   500mV  3450mV
>     aldo1                         1    1      0 unknown  3300mV     0mA   500mV  3400mV
>        d4280000.mmc-vqmmc         1                                 0mA     0mV     0mV
>     aldo2                         0    0      0 unknown   500mV     0mA   500mV  3400mV
>     aldo3                         0    0      0 unknown   500mV     0mA   500mV  3400mV
>     aldo4                         0    0      0 unknown   500mV     0mA   500mV  3400mV
>  5V_VBUS                          2    1      0 unknown  5000mV     0mA  5000mV  5000mV
>     c0a00000.usb-vbus             1                                 0mA     0mV     0mV
>  VCC5V0_HUB                       2    1      0 unknown  5000mV     0mA  5000mV  5000mV
>     c0a00000.usb:hub@1-vdd        1                                 0mA     0mV     0mV
> 
> [0] https://github.com/spacemit-com/docs-product/blob/main/en/k1_muse_pi_pro/pi_pro_hw.md
> 
> Andre Heider (6):
>   riscv: dts: spacemit: k1-musepi-pro: add PMIC and power infrastructure
>   riscv: dts: spacemit: k1-musepi-pro: add 24c02 eeprom
>   riscv: dts: spacemit: k1-musepi-pro: enable QSPI and add SPI NOR
>   riscv: dts: spacemit: k1-musepi-pro: enable USB 3 ports
>   riscv: dts: spacemit: k1-musepi-pro: enable PCIe ports
>   riscv: dts: spacemit: k1-musepi-pro: set default console baud rate
> 
>  .../riscv/boot/dts/spacemit/k1-musepi-pro.dts | 309 +++++++++++++++++-
>  1 file changed, 308 insertions(+), 1 deletion(-)
> 
> -- 
> 2.53.0
> 

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv