From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A132CD98CF for ; Fri, 12 Jun 2026 08:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=musGTOKAX+u3NmU0nCgpFE6VVcrr7wCUaTtIMDyN82I=; b=StewxMUOKKCJyaQIqNbN7ldyYE 2A5d6VgJ+9gin4/C+XiC3vIUqMfSV0RynDpRG9kZpi2V6tsJIy5I4ywO6wP5b7XgI5wpRQCI1xzBf cqDVAdmmyaGaWWw+wqtlpH7k68Nq4hL5laGViEooPzbktE1UJ7OpA2F+KFVHRy0469Bu6lgz/PXeJ OdBO2y2On1VxuhMy54NORSJbiqAO2w0b9ysyfas3wH10Ot+uuLJn73RENRSAVSisu8pa2AcfSWd9p 3Ka0hMuqvyCQ+uNYc6sQKwH7HFVoPNz1u1vtEbhCfbwifcY7QQKNr2ZHprUOk++J08cILi1ZNw2At zSiYbvxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXxSh-0000000AauT-01lh; Fri, 12 Jun 2026 08:41:59 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXxSd-0000000Aatt-2K5v; Fri, 12 Jun 2026 08:41:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1781253717; x=1812789717; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cJS4+U+Lvd9JiTFvDEcycO1GrMxgHTDXXvhAFBUdHBY=; b=rn5Vab6uWHYXd1rjInpzacx/i9ApDbJQIQ7WtIOeC3zQXDO+WTCSL/a+ p8tVZiSkk53fQr0hMwaWkiCfTqyj+tSTWG6evFK5wnJgtSGrrd/B/fsFQ f2ckYMxMvl2UA97xxXtQwX2TjjjptF4gvHouvS4N3RhEKjj8zsbF+ltXj 9rqfMuWoIEn/z9XDbDR8/f3XP2LvUmOTtHbJfS78rxYptrns5AJ1bSC9/ YNUnsYYU5R2bfBWTKkvujfVUD6RWoE2G82RS63PMLdDROFgY818ER3qoN QZ2l/rwwwX0LrYToVVAPfxLfG7QnIC0Vtb9NEUPKX0nQM4Y8t0F/8d9sd Q==; X-CSE-ConnectionGUID: XuaeUrWDQs68NJpIlx5NwQ== X-CSE-MsgGUID: /IzbyA5FSWGqN1HaIZcVPg== X-IronPort-AV: E=Sophos;i="6.24,200,1774335600"; d="asc'?scan'208";a="59017390" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jun 2026 01:41:56 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Fri, 12 Jun 2026 01:41:53 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58 via Frontend Transport; Fri, 12 Jun 2026 01:41:48 -0700 Date: Fri, 12 Jun 2026 09:41:02 +0100 From: Conor Dooley To: Guodong Xu CC: Jonathan Corbet , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Zong Li , Deepak Gupta , Anup Patel , Atish Patra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Chen Wang , Inochi Amaoto , , , , , , Paul Walmsley , Conor Dooley , , , , , Palmer Dabbelt , Qingwei Hu Subject: Re: [PATCH v4 09/16] riscv: Add Zic64b to cpufeature and hwprobe Message-ID: <20260612-frays-feast-e631e3aa047d@wendy> References: <20260611-rva23u64-hwprobe-v2-v4-0-3f01a2449488@gmail.com> <20260611-rva23u64-hwprobe-v2-v4-9-3f01a2449488@gmail.com> MIME-Version: 1.0 In-Reply-To: <20260611-rva23u64-hwprobe-v2-v4-9-3f01a2449488@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260612_014155_886836_5425DA21 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2200072793137523145==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============2200072793137523145== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yeEbaUwKYQ4BJ0tH" Content-Disposition: inline --yeEbaUwKYQ4BJ0tH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 11, 2026 at 04:12:46PM -0400, Guodong Xu wrote: > From: Qingwei Hu >=20 > Zic64b mandates 64-byte naturally aligned cache blocks and is a > mandatory extension of the RVA22 and RVA23 profiles. Allocate a > RISCV_ISA_EXT_ZIC64B id, parse "zic64b" from the ISA string with a > validate callback that requires each cbom/cbop/cboz cache block size to > be 64 bytes when it is present, and export it through hwprobe. >=20 > Link: https://lists.riscv.org/g/tech-unprivileged/topic/question_about_zi= c64b_and/119631059 > Signed-off-by: Qingwei Hu > Co-developed-by: Guodong Xu > Signed-off-by: Guodong Xu > +static int riscv_ext_zic64b_validate(const struct riscv_isa_ext_data *da= ta, > + const unsigned long *isa_bitmap) > +{ > + /* > + * Zic64b mandates 64-byte naturally aligned cache blocks; cross-check = the > + * cbom/cbop/cboz block-size (when declared) device-tree properties to > + * avoid inconsistency. > + */ > + if ((riscv_cbom_block_size && riscv_cbom_block_size !=3D 64) || > + (riscv_cbop_block_size && riscv_cbop_block_size !=3D 64) || > + (riscv_cboz_block_size && riscv_cboz_block_size !=3D 64)) { > + pr_err("Zic64b detected in ISA string, disabling as a CBO block size i= s not 64 bytes\n"); > + return -EINVAL; > + } > + > + return 0; > +} I'm inclined to object to this, but we don't have validation on ACPI stuff to be able to mandate that people fill in the rhct entries. Reviewed-by: Conor Dooley --yeEbaUwKYQ4BJ0tH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaivGHgAKCRB4tDGHoIJi 0lFLAQDha3cantxsp/CPLOnAf10qvhl6aJAKsPOLD54gW9K0AQD+I9ggy4JDJWBL AjJkB9ffVB058Go53e93Vc4lz51wNQw= =4eTb -----END PGP SIGNATURE----- --yeEbaUwKYQ4BJ0tH-- --===============2200072793137523145== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============2200072793137523145==--