From: Ivy Lopez <skunkolee@gmail.com>
To: conor.dooley@microchip.com
Cc: alex@ghiti.fr, andrew.jones@oss.qualcomm.com,
aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, palmer@dabbelt.com,
pjw@kernel.org
Subject: Re: [PATCH] riscv: hwprobe: require both F and D extensions for RISCV_HWPROBE_IMA_FD
Date: Mon, 17 Aug 2026 15:15:07 -0600 [thread overview]
Message-ID: <20260817211507.28685-1-skunkolee@gmail.com> (raw)
In-Reply-To: <20260817-unmade-dyslexic-4bb4acf535af@wendy>
On Mon, Aug 17, 2026 at 03:14:36PM +0100, Conor Dooley wrote:
> The kernel never supports F without D, so this cannot occur.
> riscv_isa_extension_available(NULL, f) always returns false if D is not
> also present.
>
> If anything, the code in has_fpu() should be changed to only check D and
> not F to match expectations elsewhere, or F and D for the same reason.
Ah ok, thanks for the clarification.. I hadn't realized F-without-D is
already structurally impossible here, so this patch doesn't change
actual behavior.
Would you prefer a v2 that fixes has_fpu() instead (checking D only,
or F && D, whichever matches the intended semantics elsewhere), or
would you rather I just drop this patch since RISCV_HWPROBE_IMA_FD already
behaves correctly in practice?
Happy to send whichever you'd find useful!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2026-08-17 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 0:32 [PATCH] riscv: hwprobe: require both F and D extensions for RISCV_HWPROBE_IMA_FD Ivy Lopez
2026-08-17 14:14 ` Conor Dooley
2026-08-17 21:15 ` Ivy Lopez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817211507.28685-1-skunkolee@gmail.com \
--to=skunkolee@gmail.com \
--cc=alex@ghiti.fr \
--cc=andrew.jones@oss.qualcomm.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox