From: Yixun Lan <dlan@kernel.org>
To: Bruno Banelli <bbanelli@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Ze Huang <huang.ze@linux.dev>, Alex Elder <elder@riscstar.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT
Date: Tue, 25 Aug 2026 22:27:50 +0000 [thread overview]
Message-ID: <20260825222750-GKB631715@kernel.org> (raw)
In-Reply-To: <20260825052158.66367-1-bbanelli@gmail.com>
Hi Bruno,
On 07:21 Tue 25 Aug , Bruno Banelli wrote:
> PHY_SPACEMIT_K1_PCIE has "default ARCH_SPACEMIT", but
> PHY_SPACEMIT_K1_USB2, twelve lines below it in the same file, does not.
> Since the symbol is also absent from arch/riscv/configs/defconfig, a
> plain "make defconfig" build for a SpacemiT K1 board ends up with the
> USB 2.0 PHY driver disabled.
>
> dwc3-generic-plat needs that PHY, so the result is a kernel with no
> working USB at all on boards such as the Milk-V Jupiter, where all four
> USB 3.0 type-A ports hang off the single dwc3 controller.
>
> Give it the same default as its sibling.
>
> Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
Looks good to me
Reviewed-by: Yixun Lan <dlan@kernel.org>
--
Yixun Lan (dlan)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2026-08-25 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 5:21 [PATCH] phy: spacemit: enable K1 USB 2.0 PHY by default on ARCH_SPACEMIT Bruno Banelli
2026-08-25 22:27 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825222750-GKB631715@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=bbanelli@gmail.com \
--cc=elder@riscstar.com \
--cc=huang.ze@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox