Re: [PATCH 2/4] dt-bindings: mmc: spacemit,sdhci: Add tx delay property

[Yixun Lan <dlan@kernel.org>]

Hi Krzysztof,

On 15:00 Thu 03 Sep     , Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 07:03:13AM +0000, Yixun Lan wrote:
> > From: Long Wan <long.wan@linux.spacemit.com>
> > 
> > Introduce a vendor specific property to configure the step count of TX
> > delay line which should be applied before RX tuning, compensating for
> > board level trace differences. The TX delay line result comes from test
> > out of real board which vary from different hardware layout.
> > 
> > Signed-off-by: Long Wan <long.wan@linux.spacemit.com>
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > index f35bf7ce08dd..3399a2d076dc 100644
> > --- a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> > @@ -63,6 +63,16 @@ properties:
> >    pinctrl-1:
> >      description: Optional pinctrl state for 1.8V UHS operation with "uhs" name
> >  
> > +  spacemit,tx-delay:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 0
> > +    maximum: 255
> 
> default: 0, I guess?
> 
It's actually 127, I will fix it in next version

Also in my second thought, I will change the data type to uint8
then drop this additional minimum/maximum property, which will
 also simplify the code with device_property_read_u8() a bit

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv