From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBE75C982D0 for ; Fri, 18 Sep 2026 01:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gE03/dffETUJq3NKp9XnXEkTtPDro5fEyGXY4tDWNMk=; b=cVso1KIyW9BZAU ezpBCl/kIH+Udvq5g32t/CcxofkZqC4N1KYxSd84DUEGU/aqcrtCbLq5rFEL605OFoJqpymC9i9EU liYHWXNoMwPEdjYoHd6BWoCTkLMgVhcGjOk0bHZz0ErbWYBN1Zth0V1FG3Hw2ILsFum2tU8OAM+VA pzfevLIUXH3dyOLfJq9IVJbTFFmN6OhWRoKJhEWTpXcoV7U5YNpF3z1vY1uU+VjqYP0PMUMYs3vUZ D6tSVY3V5shAgMVSsyUeG1j+XAf/efqOOEeUUt6ZF3za1dXaYFb7DgjFuldKAQ6LRZbodbcjb0+4n M7uIz0eXlQ4+EcKSGbZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7N4q-0000000D6ju-3wUQ; Fri, 18 Sep 2026 01:07:44 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7N4p-0000000D6jM-1t4C; Fri, 18 Sep 2026 01:07:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id ED5E4419AB; Fri, 18 Sep 2026 01:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58B681F00893; Fri, 18 Sep 2026 01:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789693662; bh=4K9MjrbYytfjUKZsWDZQNZLjwWqitvV2RncrKp6V+PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=k5cWkWseKfeadwsaVPXCsS8lvGsd+tdSmPOrVtqEMbk75KqTkD4zy+7En6LhD2ywa DaRsd83TwV0mOIZho690nEmO3idWB8XQkIziKwCh0GcwjjjU70EpJbTmEi/cF0GuaP /7/pXwyCpUq0e7QXW37qfDqLOT7I2G7zCvNO2mNiHwQarbF5EybADwKGrWUy41EbBI zTDD9URKYYpbd/eKGmEPGtH9D9AREbGz+aRY2dyE64e+faqRl2rwDc8cmsA58OEqGc WurYI1M8cJohHT6NtQSs49BdhFIdDtVANA86k0AT2mqjHWvvHIV+ycSb20M+TACXFn um2yh7n0v+EZQ== Date: Thu, 17 Sep 2026 18:07:29 -0700 From: Nathan Chancellor To: Kees Cook Cc: "Lorenzo Stoakes (ARM)" , Linus Torvalds , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Masahiro Yamada , Alexey Gladkov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Arnd Bergmann , Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Josh Poimboeuf , Peter Zijlstra , Miguel Ojeda , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Jonathan Corbet , Randy Dunlap , "Gustavo A. R. Silva" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe , linux-hardening@vger.kernel.org Subject: Re: [PATCH v3 10/20] kbuild: move the toolchain checks into init/Kconfig.toolchain Message-ID: <20260918010729.GB1585590@ax162> References: <20260917-build-speedup-v3-0-9ecf4163ff36@kernel.org> <20260917-build-speedup-v3-10-9ecf4163ff36@kernel.org> <202609171149.6454DC6@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202609171149.6454DC6@keescook> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2026 at 11:53:13AM -0700, Kees Cook wrote: > On Thu, Sep 17, 2026 at 05:06:20PM +0100, Lorenzo Stoakes (ARM) wrote: > > Move them into their own file, sourced from the top of init/Kconfig, so > > that the next commit can add to them without growing init/Kconfig further. > > > > No functional change. > > > > Assisted-by: LLM > > Signed-off-by: Lorenzo Stoakes (ARM) > > --- > > init/Kconfig | 197 +----------------------------------------------- > > init/Kconfig.toolchain | 198 +++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 199 insertions(+), 196 deletions(-) > > Yeah, totally right to move to a separate file. I think, however, I > would prefer this wasn't in init/ though. Kbuild uses scripts/ as its > Makefile.$topic dumping ground, and Kconfig.include also lives there. To > me, this new file should be scripts/Kconfig.toolchain instead. And > arguably, this should be included by the top-level Kconfig rather than > init/Kconfig... > > I defer to kbuild folks, though. We talked about this previously: https://lore.kernel.org/aqPW1FsBVYHSWl1r@gremlin/ I do feel like scripts/ is a better location given that these are really things internal to Kbuild but I also see where Lorenzo is coming from that scripts/ is a little weird for this to live for discoverability, especially if we want people to put checks here instead of in a Makefile directly. To be honest, it would be kind of nice to separate the Kbuild parts of scripts into their own directory to make it clear what Kbuild uses versus what users/contributors should use but that is obviously too big of a project to tackle as a prerequisite for this. -- Cheers, Nathan _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv