From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91292606A31D for ; Thu, 22 Oct 2026 00:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=XIFNG1CG; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=CKTmObd9; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=i32yvBGc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I0E4w4SbEGzif04ZWd/9XnFVLfn7L01SXQGIX09ZupY=; b=XIFNG1CGold8OP fxtJCE8NhTCrrkkdiZ/Ulx75p/wBI3iWEMjWGdIOwcfgWv9+KWAKjDgRApEK2IK3zxA/w37FQgW1n gbG07NUIWJU4nnII6LSX2XBcVi2OCvH3FGDxURaUeZRMyvz1mIIg7Z3/CBlCLgLG+rOu70xwWY4c3 rir6v4lN+FARKlz9b4/ZNT+SSUpcWe3nwjQGVJOQikb+DlWPnpjDr8fL97ZGnzW8DkN5SNoL0pOC9 gE5GRm4It82qo79lvA1qQok3FG848oIdBgVsuhnMdWcO3wA14ICwf/Bj6vRMF/l/FSestM3Pb5lKC F6ziF/Ps/L3DINYEfckQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJgij-0000000D694-3zHO; Thu, 22 Oct 2026 00:31:49 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJgig-0000000D687-3ezn for linux-riscv@lists.infradead.org; Thu, 22 Oct 2026 00:31:48 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69LKeNvL1154640 for ; Thu, 22 Oct 2026 00:31:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H/opNow+kHytu3G/NcD0sUoEO+o11bnVvWNwj42+U14=; b=CKTmObd9EYBRD8Es JW8RP6hHE2nV/jriTWLFK4Tj07MD2YQ/d+k3krx0ltsunPU1Cqkd265kNM9yKAU3 GEnCNnmIZVqdzmOaFvqwUFGMkR3jhOrDwVbvYrdhKxx40y/3PqS6OEdz4Y1mzA5r nc8kaRtBDStzSfIldolLvF/dk667tyPSl7AI/LeWGSrXbgSZl2mpo3K30Ew21v2d 6hYLTLvPXuNcUx8Ous6bX1zJ4wVog4riLz0NNXpV98/XnWjGQDy4Iramm7tFASVm hQQeeHZq2uT1zz50gd3ihZtkQZ1hZa24QON53S/ZDK8f4lAV6Lzg3Nt099ldullS qho3Mw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hf0cv1u9u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Oct 2026 00:31:45 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3425098ae4bso561610eec.0 for ; Wed, 21 Oct 2026 17:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792629105; x=1793233905; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=H/opNow+kHytu3G/NcD0sUoEO+o11bnVvWNwj42+U14=; b=i32yvBGc+TQB5r7OAgq3QfbnrPs+/hRSJKrzqQSEREJjON47dAZNCjKM5jfqc+tffF oxKkm4OcatFa21kuLq4K4MTAs6TImDEH/7q4leUWVpx0mc/yeHWsed1Gk/DeF9jtq/Ee RhTijxHOSg7tDKXnoithYM6DNNK0oaIIWz3vI7zHCbWUpA9Iy8YDUXOoE1Sm9+piP7KG wKBw/BPnwdewYwpuPLvVmL0hL6LUzW62Z5da5mGzFV1NQ3LnhRLzCCfhCIUABRw3w+Bm qCD2fVwxrIckHgP7BZfw2m4CoD1J+BLdIkTlD+2WWpDMn1ZfJQTQ31FJu6UxOx9qD2nK z26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792629105; x=1793233905; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H/opNow+kHytu3G/NcD0sUoEO+o11bnVvWNwj42+U14=; b=UJvL5nOqDlJ311cjK9PPJk2LyPsC9rQ4ul0s77iHA4l0r7G4Eis58pkdgi/HyLEMU6 5AmcHAhzF9t68WmlFATeJnvu+Ghu+/HZpQUsCH1o4h/C103FzA1bBWvZVRVLW2A9LXpk sHYt3WWk6rwSzSBPoTGQaENDALRhZfKGvyNQ+6Uy5sWmAd0cMbQl/PQ77b6DmGgBFRcg iH2hQXPrhlLFOJ8lV4CLLDxbm4sVox2lm/R0H0cawBU2Ny5+qm7gt4L7Gufj0pqVR98Z PYnaB9fhugLQHLnFtjTPEMaRLdXbqJATiW8Lb3OT3NgvnyJrlLT06FDbdoLFy52SQVT/ uL5A== X-Forwarded-Encrypted: i=1; AKwUvByDoWV1BgCH/OrITWV6xjgwIeUgM2rXbu6AChgkpv4kdQiEtnFPDXOhm2yzn+aHDxqZ0O0EUVFYMhVYmg==@lists.infradead.org X-Gm-Message-State: AFq9FYKJvjGZU7tqSEmkJiZtrFmTmLIeaGF7XxtAdMjJINgL3lTJVZAe t68MFrT31Wr/KfCOeN+uzq0gAlMlBIXrEsSYfu1T5edygS6qVi61dOlVSN0nmtcpbQ9BzGpkK+2 xnkQlexQWuYmUBvNp11TtalR/gGywsLKmcYSDemDTGEK08O+5pDdur4iECscA5eJ+d1UAubw= X-Gm-Gg: AYBFou0u5YlMx/CxXKMct3K+z4H+n6+9KCMOmU1QgdAwCz1iCRpFH9IE7pZXA+aPx7F fct9V4cnIaaIYiCATTq597tZ38IMS1M8Hu7z0c22jR78Yz08riAR/axIioqaUIR0phrRDvFwp6T NKd16y/zv+AwJf0GUEjde94ZDhv4LUirNVcwj9s9ZfAvenb+VGJ+SYcN9xxD5wL5cz68xxh0/fv AMpjKclDE+hO0OvgYqHNeTwhKTCQ3LJ0yxZ2LmeU9pZatmcV8NlhcqXKhaL3EwiYPCkxBlxufrf mJYdohGbvdhGmfl3vXkI8gpc6EFpeS7Zq3STRdWc5EGXTMZml4C0tzIgw6mR0ZMV8wXdpyeCGk6 Zm9MsGL6GlbwMGlr3U/BZTPUzl3VBLfNHVrwpqakyXZj6KWac7XTm+A== X-Received: by 2002:a05:701b:4192:10b0:143:808b:b178 with SMTP id a92af1059eb24-192f5c29bf4mr1174138c88.26.1792629104432; Wed, 21 Oct 2026 17:31:44 -0700 (PDT) X-Received: by 2002:a05:701b:4192:10b0:143:808b:b178 with SMTP id a92af1059eb24-192f5c29bf4mr1174090c88.26.1792629103886; Wed, 21 Oct 2026 17:31:43 -0700 (PDT) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1903a180ca2sm8819002c88.6.2026.10.21.17.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 17:31:43 -0700 (PDT) Date: Wed, 21 Oct 2026 17:31:16 -0700 From: Jonathan Cameron To: Jason Gunthorpe Cc: Alexandre Ghiti , Albert Ou , Ard Biesheuvel , Arnd Bergmann , Catalin Marinas , Jonathan Corbet , David Sterba , Ilias Apalodimas , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Randy Dunlap , Simon Glass , Shuah Khan , Nick Terrell , Will Deacon , Alexandre Ghiti , Conor Dooley , linux-integrity@vger.kernel.org, Palmer Dabbelt , patches@lists.linux.dev, Piotr =?ISO-8859-1?Q?Kr=F3l?= , Ross Philipson , Sami Tolvanen , Song Shuai Subject: Re: [PATCH v2 15/15] efi/arm64: Implement ARM64 DRTM in the stub Message-ID: <20261021173116.00000df9@oss.qualcomm.com> In-Reply-To: <20261021233909.GX3008132@nvidia.com> References: <0-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> <15-v2-989a18390eb1+486-arm64_drtm_jgg@nvidia.com> <20261021111115.00004c5c@oss.qualcomm.com> <20261021233909.GX3008132@nvidia.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Archived-By: MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=NrRE4MdJ c=1 sm=1 tr=0 ts=6ad95971 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=Ikd4Dj_1AAAA:8 a=j7B8HJC98GV4A_3RkYkA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: RSwW3v8J4En_PLGu36keFcKEfbvmlN_- X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIyMDAwMSBTYWx0ZWRfX+V2XlsYi3eje U/e6g0u2kDIw3aFRreZp3xDXu2gz+JyBPuIYjL0Yf9o+m6xK/Y62MRQMI5QzRvBYTpQ5uPIAaGL FY6LdYmBFQnFb++TgxnXUThANFzS3WI= X-Proofpoint-GUID: RSwW3v8J4En_PLGu36keFcKEfbvmlN_- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIyMDAwMSBTYWx0ZWRfX+mEi46FBdlV1 wpE/pT01/9Xy2gAXytr28agZHMwwlBRL9y6Xc6U7PCJ/enyQiXbsWdwv40pUWRVLUwIEmv97sXF Ko+Wn5Wq5EfboX6PB5j+jpfFGa4aMbZY/KP0PkcbwwZnqd96l4eC1h4Ve4eqNigrWHF+AWv7NfB Hf5YwqDWQtn3aP4epyE5a3nda8F3kjRIZFlXlPBy5L2IYSVkg1ngsbEcE5vPCdG2w6WrdMRS2Cy 6kv1HgjsO/0EDCi2FJa68NaGRJ1YWM5z0as0cQaOTB5H4DvWMlhwGvGyb6KN2+RlYpQx0g2TwU0 fUZvbIIdKrLNzMANFVoNI23s/8SWtotK80lnJb29yMCXfNdOWXrSVJ4aBhyNkN2H1NyCtDvxgea AToz9AJLSvmUTrx0oQlsq3/B9UatCzkqJnIlTc3kD0aTUOLlx0VwMws2TC/RWvPgBFt3pJM7PF5 ogHoxoV12haALyIf1pg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-21_06,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610220001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261021_173146_961229_D4C82737 X-CRM114-Status: GOOD ( 47.57 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, 21 Oct 2026 20:39:09 -0300 Jason Gunthorpe wrote: > On Wed, Oct 21, 2026 at 11:11:15AM -0700, Jonathan Cameron wrote: > > On Fri, 2 Oct 2026 20:31:52 -0300 > > Jason Gunthorpe wrote: > > > > > Provide an implementation of the CONFIG_EFI_STUB_DRTM protocol for ARM64 > > > DEN0113 >= v1.1. > > > > > > First, it queries the FW for support and collects all the > > > information. This is needed to compute the extra_size, which comes > > > from FW reporting how much memory it needs during the launch for the > > > DLME Data and DCE-owned data. The generic stub ensures there is > > > trailing memory after Image for this. > > > > > > Then the DRTM_PARAMETERS launch structure is computed using the > > > offsets in the efi_info. > > > > > > Finally, the stub does ExitBootServices and calls the actual launch. > > > > > > The feature discovery process is deliberately fairly verbose to help > > > debug any FW weirdness in the field. Enable it with efi=debug > > > > > > It looks something like: > > > > > > EFI stub: DRTM: interface version 1.4 > > > EFI stub: DEBUG: DRTM: TPM algorithm 0xc, TPM hashing unavailable, PCR schemas 0x1 > > > EFI stub: DEBUG: DRTM: minimum DLME data 73728 bytes, Normal-world DCE 0 bytes > > > EFI stub: Decompressing Linux Kernel... > > > EFI stub: Generating empty DTB > > > EFI stub: Exiting boot services... > > > EFI stub: DEBUG: DRTM: will launch, selected launch features 0x0 > > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x000f0510] > > > > > > Eventually the launch'd kernel is going to require built in crypto > > > libraries that match what the FW is using so it can validate some of the > > > information left behind during early boot. Refuse to launch if these are > > > not built in and build in the most common ones from the ARM64_DRTM > > > kconfig. > > > > > > One nit, if the platform does not support SMC then using drtm=auto may > > > crash on the SMC op. As far as I can tell there is no way to discover SMC > > > support through EFI. Learning it from the ACPI FADT is doable and costs > > > about 250 lines of code. > > > > Ouch. Sounds like a must have if there is no easier way. > > Yeah, maybe so. I will include the patch in the next version. Though > I'm not keen on it and I don't know very much about ACPI. > > > > +/* True if SMCCC 1.0 or later is available. */ > > > +static bool efi_arm64_psci_smccc_compatible(void) > > > +{ > > > + struct arm_smccc_res res; > > > + s32 status; > > > + > > > + arm_smccc_1_1_smc(PSCI_0_2_FN_PSCI_VERSION, &res); > > > > A function that is meant to check for smccc 1.0 is using the > > smccc_1_1 namespaced calls? Maybe add a comment on why that > > is ok to do. Is anyone actually using SMCCC 1.0 on systems like this? > > This is a good point, I didn't quite get all these details at the > time, but yeah, technically we have to use the 1.0 calling convention > due the register clobber differnces. The other reason is we can't use > the kernels 1.0 helper since it is an asm function not an assembly.. > > Fixing everything I came with this: > > /* > * Discovery must tolerate SMCCC 1.0 clobbering x0-x17. The EFI stub cannot > * call the kernel's out-of-line SMCCC helper, so issue these calls inline. > */ > static u32 efi_arm64_smc_1_0(u32 function, u32 arg) > { > register unsigned long x0 asm("x0") = function; > register unsigned long x1 asm("x1") = arg; > > asm volatile("smc #0" > : "+r" (x0), "+r" (x1) > : > : "x2", "x3", "x4", "x5", "x6", "x7", "x8", "x9", > "x10", "x11", "x12", "x13", "x14", "x15", "x16", > "x17", "cc", "memory"); > > return x0; > } > > /* True if SMCCC 1.1 or later in the 1.x series is available. */ > static bool efi_arm64_psci_smccc_compatible(void) > { > u32 version; > s32 status; > > version = efi_arm64_smc_1_0(PSCI_0_2_FN_PSCI_VERSION, 0); > if ((s32)version < 0) > return false; > > if (PSCI_VERSION_MAJOR(version) < 1) > return false; > > status = efi_arm64_smc_1_0(PSCI_1_0_FN_PSCI_FEATURES, > ARM_SMCCC_VERSION_FUNC_ID); > if (status < 0) > return false; > > version = efi_arm64_smc_1_0(ARM_SMCCC_VERSION_FUNC_ID, 0); > return (version >> 16) == 1 && version >= ARM_SMCCC_VERSION_1_1; > } > > efistub can get away with this inline asm since it isn't 32 bit and it > doesn't deal with quirks. Smells plausible to me. > > > I a bit surprised we don't have a common helper for this - > > I guess the version checks are often explicit in a particular > > driver being bound. > > The PSCI stuff in the kernel is all very early when establishing what > the channel is and is done only once. Here is a bit different > since we only accept the smc instruction used by drtm.. > > And even if there was a helper we can't really call it from zboot.. True enough. I was just hoping there was code to compare this with :) > > Thanks, > Jason _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv