From: Conor Dooley <conor@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
Valentina Fernandez <valentina.fernandezalanis@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: mpfs-mssio: remove unused mutex
Date: Fri, 30 Oct 2026 18:12:14 +0000 [thread overview]
Message-ID: <20261030181214.2448140-3-conor@kernel.org> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
The pinctrl core creates a mutex that is used to protect things like the
generic dt node mapping functions. The (currently) unused mutex was added
when the driver was in RFC state and contained a custom dt node mapping
function, and used the driver's own mutex to protect it. The driver
probably could have borrowed the core's, but this is moot since the merged
version of the driver no longer has a custom dt node mapper. Remove the
unused mutex.
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
CC: Conor Dooley <conor.dooley@microchip.com>
CC: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Linus Walleij <linusw@kernel.org>
CC: linux-riscv@lists.infradead.org
CC: linux-gpio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
index 8da0c5312ce3..17c6d4190053 100644
--- a/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
+++ b/drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c
@@ -56,7 +56,6 @@ struct mpfs_pinctrl {
struct device *dev;
struct regmap *regmap;
struct regmap *sysreg_regmap;
- struct mutex mutex;
struct pinctrl_desc desc;
};
@@ -677,7 +676,6 @@ static int mpfs_pinctrl_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct mpfs_pinctrl *pctrl;
- int ret;
pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL);
if (!pctrl)
@@ -703,10 +701,6 @@ static int mpfs_pinctrl_probe(struct platform_device *pdev)
pctrl->dev = dev;
- ret = devm_mutex_init(dev, &pctrl->mutex);
- if (ret)
- return ret;
-
platform_set_drvdata(pdev, pctrl);
pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
--
2.53.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
reply other threads:[~2026-10-30 18:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030181214.2448140-3-conor@kernel.org \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox