Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Sandie Cao <sandie.cao@deepcomputing.io>
Cc: Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree <devicetree@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	spacemit <spacemit@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support
Date: Mon, 16 Nov 2026 12:59:31 +0000	[thread overview]
Message-ID: <20261116125931-GKC100890@kernel.org> (raw)
In-Reply-To: <407ce3d77416bb2522b7906b0df3d5adf02c27ee.63da97eb.e7e5.488f.8751.a4a1c53db9df@feishu.cn>

Hi Sandie,

On 17:52 Mon 16 Nov     , Sandie Cao wrote:
> Hi, Yixun:
> 
> > From: "Yixun Lan"<dlan@kernel.org>
> > Date:  Mon, Nov 16, 2026, 16:24
> 
> > > 
> > > In version 1 [1],  the patch is cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>;
> > > but K3_GPIO(88) is fake cd-gpio, it's tied low on board.
> > So, there is gpio cd pin, but didn't work? it's hard to say without
> > the schematic, but can you check with hardware people, if it
> > can be fixed with SoC's internal GPIO BIAS pullup or pulldown?
> > So, gpio pin is able to reflect card insert status
> > 
> > 
> 
> I did check with our hardware team, and the answer is: 
> there is a CD net on the slot, routed to K3_GPIO(88), but it is hard-tied
>  to GND on the board. (v1 of this series used 
> cd-gpios = <&gpio K3_GPIO(88) GPIO_ACTIVE_LOW>, which of course
> always reports "card present".) It is a direct connection to GND, not a
> strap resistor, so the SoC's internal bias cannot pull it up.
> 
Ok, so there is CD pin, but with hardware design flaw, it's indeed broken,
that's "broken-cd" property for

> > > So In version2 [2], the patch changes to non-removable.
> > > And In version3 [3], add comment. 
> > > 
> > > The options: cd-gpio, non-removable, broken-cd  all work on this board.
> > > 
> > it works, but does not reflect the hardware status
> > 
> > > We just need to detect the SD card when bootup, don't need the driver 
> > > to detect hot-plug event , non-removable should be suitable and faster, 
> > > we recomment to use non-removable.
> > > 
> > No, this isn't a valid reason, it's use case should have nothing to do
> > with the property.
> > 
> > My point is: if the gpio cd pin still doesn't work, and the SD card is
> > actually physical plugable, then should use "broken-cd".
> 
> The SD card slot is onboard [1],  put the board into casing, there is no
> way to plugin/ plugout the card. So there is no card-detect event that can
> ever happen at runtime.
> 
No, if open the case, the card is still plugable.. 

> If you still prefer broken-cd,  I will follow in next version. 
> 
Yes, please update

> [1]: https://deepcomputing.io/dc-roma-risc-v-mainboard-iii-unveiled-at-fosdem-powered-by-spacemit-k3-for-framework-laptop-13/
> 
> Best regards
> Sandie

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2026-11-16 12:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  3:31 [PATCH v4 0/3] Enable USB and SD for Deepcomputing FML13V05 board Sandie Cao
2026-11-09  3:32 ` [PATCH v4 1/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add P1 PMIC regulator tree Sandie Cao
2026-11-09  6:38   ` Troy Mitchell
2026-11-09  3:33 ` [PATCH v4 2/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: add USB controller and USB phy support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:30   ` Yixun Lan
2026-11-16  2:54     ` Sandie Cao
2026-11-09  3:33 ` [PATCH v4 3/3] riscv: dts: spacemit: k3-deepcomputing-fml13v05: Enable SD card support Sandie Cao
2026-11-09  6:20   ` Troy Mitchell
2026-11-14  7:55   ` Yixun Lan
2026-11-16  6:49     ` Sandie Cao
2026-11-16  8:23       ` Yixun Lan
2026-11-16  9:52         ` Sandie Cao
2026-11-16 12:59           ` Yixun Lan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116125931-GKC100890@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox