From: William Qiu <william.qiu@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<devicetree@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: syscon: Add StarFive syscon doc
Date: Wed, 8 Mar 2023 13:59:28 +0800 [thread overview]
Message-ID: <20e56116-ab76-fa8c-b321-d32c8b24a6be@starfivetech.com> (raw)
In-Reply-To: <39ba7357-541b-a70e-5793-91bb9e038938@linaro.org>
On 2023/3/7 17:00, Krzysztof Kozlowski wrote:
> On 07/03/2023 03:46, William Qiu wrote:
>> Add documentation to describe StarFive System Controller Registers.
>
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching). This is not "syscon" subsystem, but rather
> starfive.
>
Will update.
>>
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> .../bindings/soc/starfive/jh7110-syscon.yaml | 41 +++++++++++++++++++
>> MAINTAINERS | 5 +++
>> 2 files changed, 46 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>> new file mode 100644
>> index 000000000000..72c8850602b5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/starfive/jh7110-syscon.yaml
>
> Filename: starfive,jh7110-syscon.yaml
>
Will update.
Thanks for taking times to review this patch series.
Best regards
William
>
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-08 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 2:46 [PATCH v5 0/2] StarFive's SDIO/eMMC driver support William Qiu
2023-03-07 2:46 ` [PATCH v5 1/2] dt-bindings: syscon: Add StarFive syscon doc William Qiu
2023-03-07 9:00 ` Krzysztof Kozlowski
2023-03-08 5:59 ` William Qiu [this message]
2023-03-07 2:46 ` [PATCH v5 2/2] mmc: starfive: Add initialization of prev_err William Qiu
2023-03-07 12:51 ` Emil Renner Berthing
2023-03-09 15:02 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e56116-ab76-fa8c-b321-d32c8b24a6be@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox